Skip to content

publish grpcio-compiler 0.4.3 to crates.io (along with grpcio) #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dwerner opened this issue Jan 9, 2019 · 5 comments
Closed

publish grpcio-compiler 0.4.3 to crates.io (along with grpcio) #272

dwerner opened this issue Jan 9, 2019 · 5 comments
Labels
Build Compilation, environment

Comments

@dwerner
Copy link
Contributor

dwerner commented Jan 9, 2019

I landed a PR which brings in protobuf 2.1 serde_derive support, but I don't think a new version of grpcio-compiler has been published which exposes this feature.
@siddontang
Copy link
Contributor

PTAL @overvenus

@overvenus overvenus mentioned this issue Jan 10, 2019
Merged
@overvenus
Copy link
Member

@dwerner Sorry for the inconvenience. To support serde, we need to upgrade the protobuf to 2.1+ which is unfortunately not included in v0.4.2. As for grpcio-compiler, I dont think it need to upgrade, because it does not generate protobuf structs.

Will release 0.4.3 once we merge #273. Also, please let me know if #273 works for you.

@dwerner
Copy link
Contributor Author

dwerner commented Jan 10, 2019

#273 looks good to me! Thanks. I'll update the title to reflect 0.4.3 instead of 0.4.2

@dwerner dwerner changed the title publish grpcio-compiler 0.4.2 to crates.io publish grpcio-compiler 0.4.3 to crates.io (along with grpcio) Jan 10, 2019
@overvenus
Copy link
Member

FYI, grpcio/compiler v0.4.3 is released.

@dwerner
Copy link
Contributor Author

dwerner commented Jan 25, 2019

Thanks for the update, looks great!

@dwerner dwerner closed this as completed Jan 25, 2019
@dwerner dwerner mentioned this issue Jan 25, 2019
Merged
@ice1000 ice1000 added the Build Compilation, environment label Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build Compilation, environment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@siddontang @dwerner @overvenus @ice1000