Skip to content

Commit fa4cbdf

Browse files
committed
submit
1 parent 6c08fe9 commit fa4cbdf

File tree

7 files changed

+36
-10
lines changed

7 files changed

+36
-10
lines changed

Flicks.gif

16.2 MB
Loading
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
{
2+
"images" : [
3+
{
4+
"idiom" : "universal",
5+
"scale" : "1x"
6+
},
7+
{
8+
"idiom" : "universal",
9+
"filename" : "poster.png",
10+
"scale" : "2x"
11+
},
12+
{
13+
"idiom" : "universal",
14+
"filename" : "poster-1.png",
15+
"scale" : "3x"
16+
}
17+
],
18+
"info" : {
19+
"version" : 1,
20+
"author" : "xcode"
21+
}
22+
}
Loading
Loading

Flicks/MoviesViewController.swift

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ class MoviesViewController: UIViewController, UITableViewDataSource, UITableView
120120
let imageURLRequest_low = URLRequest(url: imageURL_low!)
121121
let imageURL_high = URL(string: "\(NetworkUtil.poster_base_url_high_res)\(posterPath)")
122122
let imageURLRequest_high = URLRequest(url: imageURL_high!)
123-
124123

125124
cell.posterImage.setImageWith(imageURLRequest_low, placeholderImage: nil, success: { (lowResImageRequest, lowResImageResponse, lowResImage) in
126125

@@ -145,13 +144,6 @@ class MoviesViewController: UIViewController, UITableViewDataSource, UITableView
145144
}, failure: { (request, response, error) in
146145
// error handling
147146
})
148-
149-
150-
151-
152-
153-
154-
155147
} else {
156148
cell.posterImage.image = nil
157149
}

README.md

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
**Flicks** is a movies app using the [The Movie Database API](http://docs.themoviedb.apiary.io/#).
44

5-
Time spent: **5** hours spent in total
5+
Time spent: **6** hours spent in total
66

77
## User Stories
88

@@ -28,6 +28,7 @@ The following **additional** features are implemented:
2828

2929
- [x] Use official Movie DB theme colors
3030
- [x] Display movie release date in a human readable format
31+
- [x] Display movie voting average
3132

3233
## Video Walkthrough
3334

@@ -39,7 +40,18 @@ GIF created with [LiceCap](http://www.cockos.com/licecap/).
3940

4041
## Notes
4142

42-
Describe any challenges encountered while building the app.
43+
1. I didn't have much experience working with Storyboard directly. I found manually dragging and moving UI components a little bit inconvenient. But I got used to it very quickly. There is some limitations to Storyboard such as you cannot put a UISearchBar on the NavigationItem. I had to do this programmatically. Another thing I found more easier doing things programmatically is subviews. With code, it is very easy to see when and where a specific view is being added to a subview. However in Storyboard it just kind of works magically. Even though Storyboard does work for almost everything else, I still believe in doing everything programtically is much more easier to deal with : )
44+
45+
2. This is my first time implementing a UITabBarController. The structure has now been very clear to me: UITabBarController -> UINavigationController -> UIViewController.
46+
47+
3. I didn't solve the issue where TableView will load "wrong" images first and then suddenly change to the correct ones. It is because TableViewCells are being reused. I tried setting image of the cell to nil in cellForRow but it didn't work.
48+
49+
4. No auto-layout is implemented.
50+
51+
5. I didn't have much time to work on the CollectionView. I will update it once I have time.
52+
53+
6. I spent a lot of time learning ScrollView. The contentSize property of the ScrollView is a little hard to understand.
54+
4355

4456
## License
4557

0 commit comments

Comments
 (0)