Skip to content

Commit c71a8ec

Browse files
committed
Add prettier instructions to PR template and contribution guide
1 parent 7cf2950 commit c71a8ec

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
3. If you've changed APIs, update the documentation.
66
4. Ensure the test suite passes (`npm test`).
77
5. Make sure your code lints (`npm run lint`).
8-
6. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`).
9-
7. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes.
10-
8. If you haven't already, complete the [CLA](https://code.facebook.com/cla).
8+
6. Format your code with [prettier](https://github.com/prettier/prettier) (`npm run prettier`).
9+
7. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`).
10+
8. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes.
11+
9. If you haven't already, complete the CLA.

docs/contributing/how-to-contribute.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,10 @@ The core team is monitoring for pull requests. We will review your pull request
8181
3. If you've changed APIs, update the documentation.
8282
4. Ensure the test suite passes (`npm test`).
8383
5. Make sure your code lints (`npm run lint`).
84-
6. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`).
85-
7. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes.
86-
8. If you haven't already, complete the CLA.
84+
6. Format your code with [prettier](https://github.com/prettier/prettier) (`npm run prettier`).
85+
7. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`).
86+
8. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes.
87+
9. If you haven't already, complete the CLA.
8788

8889
### Contributor License Agreement (CLA)
8990

0 commit comments

Comments
 (0)