fix: Prevent double application of the transform (#176)

Author: fatfisz

.gitignore

@@ -1,5 +1,5 @@
 .DS_Store
-node_modules/
+/node_modules/
 npm-debug.log
 lib/
 coverage/

src/utils.js

@@ -50,7 +50,12 @@ export function mapPathString(nodePath, state) {
 
   const modulePath = getRealPath(nodePath.node.value, state);
   if (modulePath) {
+    if (nodePath.node.pathResolved) {
+      return;
+    }
+
     nodePath.replaceWith(state.types.stringLiteral(modulePath));
+    nodePath.node.pathResolved = true;
   }
 }
 

test/index.test.js

@@ -509,6 +509,62 @@ describe('module-resolver', () => {
         });
       });
     });
+
+    describe('multiple alias application', () => {
+      it('should resolve the cyclic alias only once', () => {
+        const fileName = path.resolve('test/testproject/src/app.js');
+        const cycleAliasTransformerOpts = {
+          babelrc: false,
+          plugins: [
+            [plugin, {
+              alias: {
+                first: 'second',
+                second: 'first',
+              },
+            }],
+            [plugin, {
+              alias: {
+                first: 'second',
+                second: 'first',
+              },
+            }],
+          ],
+          filename: fileName,
+        };
+
+        testWithImport(
+          'first',
+          'second',
+          cycleAliasTransformerOpts,
+        );
+      });
+
+      it('should resolve the prefix alias only once', () => {
+        const fileName = path.resolve('test/testproject/src/app.js');
+        const cycleAliasTransformerOpts = {
+          babelrc: false,
+          plugins: [
+            [plugin, {
+              alias: {
+                prefix: 'prefix/lib',
+              },
+            }],
+            [plugin, {
+              alias: {
+                prefix: 'prefix/lib',
+              },
+            }],
+          ],
+          filename: fileName,
+        };
+
+        testWithImport(
+          'prefix/test',
+          'prefix/lib/test',
+          cycleAliasTransformerOpts,
+        );
+      });
+    });
   });
 
   describe('with custom cwd', () => {