Skip to content

Commit 15cef93

Browse files
weiznichhawkw
authored andcommittedSep 29, 2023
fix(api): add explicit futures-core dep to fix broken builds (#453)
This PR adds an explicit dependency to futures-core for `console-api` to fix broken builds. Without this fix I get the following errors: ``` error[E0433]: failed to resolve: use of undeclared crate or module `futures_core` --> /home/weiznich/.cargo/registry/src/index.crates.io-6f17d22bba15001f/console-api-0.5.0/src/generated/rs.tokio.console.instrument.rs:275:34 | 275 | type WatchUpdatesStream: futures_core::Stream< | ^^^^^^^^^^^^ use of undeclared crate or module `futures_core` error[E0433]: failed to resolve: use of undeclared crate or module `futures_core` --> /home/weiznich/.cargo/registry/src/index.crates.io-6f17d22bba15001f/console-api-0.5.0/src/generated/rs.tokio.console.instrument.rs:289:38 | 289 | type WatchTaskDetailsStream: futures_core::Stream< | ^^^^^^^^^^^^ use of undeclared crate or module `futures_core` error[E0433]: failed to resolve: use of undeclared crate or module `futures_core` --> /home/weiznich/.cargo/registry/src/index.crates.io-6f17d22bba15001f/console-api-0.5.0/src/generated/rs.tokio.console.trace.rs:212:27 | 212 | type WatchStream: futures_core::Stream< | ^^^^^^^^^^^^ use of undeclared crate or module `futures_core` ``` The somewhat funny thing is that only happened after I've updated some unrelated dependencies. It worked before, but after looking at the relevant code I'm really surprised that it ever compiled without error.
1 parent 1ecf257 commit 15cef93

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed
 

‎console-api/Cargo.toml

+1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ tonic = { version = "0.9", default-features = false, features = [
3737
prost = "0.11"
3838
prost-types = "0.11"
3939
tracing-core = "0.1.17"
40+
futures-core = "0.3"
4041

4142
[dev-dependencies]
4243
tonic-build = { version = "0.9", default-features = false, features = [

0 commit comments

Comments
 (0)
Please sign in to comment.