Merge branch 'fix/overview' into fix/schema

Author: eisbilir

src/common/challenge-helper.js

@@ -365,7 +365,7 @@ class ChallengeHelper {
         }
       });
     });
-    if (overview && overview.totalPrizesInCents) {
+    if (overview && !_.isUndefined(overview.totalPrizesInCents)) {
       overview.totalPrizes = overview.totalPrizesInCents / 100;
       delete overview.totalPrizesInCents;
     }

src/services/ChallengeService.js

@@ -1283,7 +1283,6 @@ async function getChallenge(currentUser, id, checkIfExists) {
   if (challenge.status !== constants.challengeStatuses.Completed) {
     _.unset(challenge, "winners");
   }
-  convertPrizeSetValuesToDollars(challenge.prizeSets, challenge.overview);
 
   return challenge;
 }
@@ -1410,6 +1409,7 @@ async function validateWinners(winners, challengeId) {
  */
 async function updateChallenge(currentUser, challengeId, data) {
   const challenge = await challengeDomain.lookup(getLookupCriteria("id", challengeId));
+  convertPrizeSetValuesToDollars(challenge.prizeSets, challenge.overview);
 
   const projectId = _.get(challenge, "projectId");
 
@@ -1641,20 +1641,6 @@ async function updateChallenge(currentUser, challengeId, data) {
         `Cannot update prizeSets for challenges with status: ${finalStatus}!`
       );
     }
-    const prizeSetsGroup = _.groupBy(data.prizeSets, "type");
-    if (
-      !prizeSetsGroup[constants.prizeSetTypes.ChallengePrizes] &&
-      _.get(challenge, "overview.totalPrizes")
-    ) {
-      // remove the totalPrizes if challenge prizes are empty
-      data.overview = challenge.overview = _.omit(challenge.overview, ["totalPrizes"]);
-    } else {
-      const totalPrizes = helper.sumOfPrizes(
-        prizeSetsGroup[constants.prizeSetTypes.ChallengePrizes][0].prizes
-      );
-      _.assign(challenge, { overview: { totalPrizes } });
-      _.assign(data, { overview: { totalPrizes } });
-    }
   }
 
   let phasesUpdated = false;