Skip to content

Commit f8e9a7f

Browse files
ThomasKranitsaseisbilir
authored andcommitted
allow admins/m2m to change the timelineTemplateId
1 parent cd525b2 commit f8e9a7f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/services/ChallengeService.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1613,8 +1613,8 @@ async function updateChallenge(currentUser, challengeId, data) {
16131613
// TODO: Fix this Tech Debt once legacy is turned off
16141614
const finalStatus = data.status || challenge.status;
16151615
const finalTimelineTemplateId = data.timelineTemplateId || challenge.timelineTemplateId;
1616-
const timelineTemplateChanged = false;
1617-
if (!_.get(data, "legacy.pureV5") && !_.get(challenge, "legacy.pureV5")) {
1616+
let timelineTemplateChanged = false;
1617+
if (!currentUser.isMachine && !hasAdminRole(currentUser) && !_.get(data, "legacy.pureV5") && !_.get(challenge, "legacy.pureV5")) {
16181618
if (
16191619
finalStatus !== constants.challengeStatuses.New &&
16201620
finalTimelineTemplateId !== challenge.timelineTemplateId
@@ -1747,7 +1747,7 @@ async function updateChallenge(currentUser, challengeId, data) {
17471747
const { track, type } = await challengeHelper.validateAndGetChallengeTypeAndTrack({
17481748
typeId: challenge.typeId,
17491749
trackId: challenge.trackId,
1750-
timelineTemplateId: challenge.timelineTemplateId,
1750+
timelineTemplateId: timelineTemplateChanged ? finalTimelineTemplateId : challenge.timelineTemplateId,
17511751
});
17521752

17531753
if (_.get(type, "isTask")) {

0 commit comments

Comments
 (0)