Merge pull request #352 from topcoder-platform/develop

jmgasper · web-flow · commit 28f4fe01c180 · 2024-05-17T05:28:42.000Z
Hotfix for issue seen in prod
diff --git a/src/services/SubmissionService.js b/src/services/SubmissionService.js
@@ -253,7 +253,7 @@ async function listSubmissions (authUser, query) {
     let hasReviewInES = false
     if (submission.review) {
       _.forEach(submission.review, (review) => {
-        if (review.metadata && review.metadata.source) {
+        if (review && review.metadata && review.metadata.source) {
           if (review.metadata.source === 'Online Review') {
             hasReviewInES = true
           }

Original file line number	Diff line number	Diff line change
`@@ -253,7 +253,7 @@ async function listSubmissions (authUser, query) {`
`253`	`253`	`let hasReviewInES = false`
`254`	`254`	`if (submission.review) {`
`255`	`255`	`_.forEach(submission.review, (review) => {`
`256`		`- if (review.metadata && review.metadata.source) {`
	`256`	`+ if (review && review.metadata && review.metadata.source) {`
`257`	`257`	`if (review.metadata.source === 'Online Review') {`
`258`	`258`	`hasReviewInES = true`
`259`	`259`	`}`