Support Sphinx 7.3 and drop 3.8 support (#163)

Author: gaborbernat

.github/workflows/check.yml

@@ -24,14 +24,13 @@ jobs:
           - "3.11"
           - "3.10"
           - "3.9"
-          - "3.8"
     steps:
       - name: setup python for tox
         uses: actions/setup-python@v5
         with:
           python-version: "3.12"
       - name: install tox
-        run: python -m pip install tox
+        run: python -m pip install tox-uv
       - uses: actions/checkout@v4
       - name: setup python for test ${{ matrix.py }}
         uses: actions/setup-python@v5

.pre-commit-config.yaml

@@ -20,10 +20,10 @@ repos:
       - id: tox-ini-fmt
         args: ["-p", "fix"]
   - repo: https://github.com/tox-dev/pyproject-fmt
-    rev: "1.7.0"
+    rev: "1.8.0"
     hooks:
       - id: pyproject-fmt
-        additional_dependencies: ["tox>=4.12.1"]
+        additional_dependencies: ["tox>=4.14.2"]
   - repo: https://github.com/astral-sh/ruff-pre-commit
     rev: "v0.3.7"
     hooks:

pyproject.toml

@@ -2,7 +2,7 @@
 build-backend = "hatchling.build"
 requires = [
   "hatch-vcs>=0.4",
-  "hatchling>=1.18",
+  "hatchling>=1.24",
 ]
 
 [project]
@@ -14,8 +14,8 @@ keywords = [
   "sphinx",
 ]
 license = "MIT"
-maintainers = [{ name = "Bernat Gabor", email = "[email protected]" }]  # noqa: E999
-requires-python = ">=3.8"
+maintainers = [{ name = "Bernat Gabor", email = "[email protected]" }] # noqa: E999
+requires-python = ">=3.9"
 classifiers = [
   "Development Status :: 5 - Production/Stable",
   "Environment :: Console",
@@ -25,7 +25,6 @@ classifiers = [
   "License :: OSI Approved :: MIT License",
   "Operating System :: OS Independent",
   "Programming Language :: Python :: 3 :: Only",
-  "Programming Language :: Python :: 3.8",
   "Programming Language :: Python :: 3.9",
   "Programming Language :: Python :: 3.10",
   "Programming Language :: Python :: 3.11",
@@ -38,12 +37,13 @@ dynamic = [
   "version",
 ]
 dependencies = [
-  "sphinx>=7.1.2",
+  "sphinx>=7.3.5",
 ]
 optional-dependencies.test = [
   "covdefaults>=2.3",
-  "pytest>=7.4.3",
-  "pytest-cov>=4.1",
+  "defusedxml>=0.7.1", # needed for sphinx.testing
+  "pytest>=8.1.1",
+  "pytest-cov>=5",
 ]
 urls.Documentation = "https://github.com/tox-dev/sphinx-argparse-cli#sphinx-argparse-cli"
 urls.Homepage = "https://github.com/tox-dev/sphinx-argparse-cli"
@@ -62,33 +62,33 @@ line-length = 120
 line-length = 120
 target-version = "py38"
 lint.select = ["ALL"]
-lint.isort = {known-first-party = ["sphinx_argparse_cli"], required-imports = ["from __future__ import annotations"]}
+lint.isort = { known-first-party = ["sphinx_argparse_cli"], required-imports = ["from __future__ import annotations"] }
 lint.ignore = [
-  "ANN101",  # no type annotation for self
-  "ANN401",  # allow Any as type annotation
-  "D203",  # `one-blank-line-before-class` (D203) and `no-blank-line-before-class` (D211) are incompatible
-  "D212",  # `multi-line-summary-first-line` (D212) and `multi-line-summary-second-line` (D213) are incompatible
-  "S104",  # Possible binding to all interface
+  "ANN101", # no type annotation for self
+  "ANN401", # allow Any as type annotation
+  "D203",   # `one-blank-line-before-class` (D203) and `no-blank-line-before-class` (D211) are incompatible
+  "D212",   # `multi-line-summary-first-line` (D212) and `multi-line-summary-second-line` (D213) are incompatible
+  "S104",   # Possible binding to all interface
   "COM812", # Conflict with formatter
   "ISC001", # Conflict with formatter
   "CPY",    # No copyright statements
 ]
 [tool.ruff.lint.per-file-ignores]
 "tests/**/*.py" = [
-  "S101",  # asserts allowed in tests...
-  "FBT",  # don"t care about booleans as positional arguments in tests
-  "INP001", # no implicit namespace
-  "D",  # don"t care about documentation in tests
-  "S603",  # `subprocess` call: check for execution of untrusted input
-  "PLR2004",  # Magic value used in comparison, consider replacing with a constant variable
-  "PLR2004",  # Magic value used in comparison, consider replacing with a constant variable
+  "S101",    # asserts allowed in tests...
+  "FBT",     # don"t care about booleans as positional arguments in tests
+  "INP001",  # no implicit namespace
+  "D",       # don"t care about documentation in tests
+  "S603",    # `subprocess` call: check for execution of untrusted input
+  "PLR2004", # Magic value used in comparison, consider replacing with a constant variable
+  "PLR2004", # Magic value used in comparison, consider replacing with a constant variable
   "PLR0913", # any number of arguments in tests
   "PLR0917", # any number of arguments in tests
   "PLC2701", # private import
 ]
 "roots/**/*.py" = [
-  "INP001",  # no namespace
-  "D",  # no docs
+  "INP001", # no namespace
+  "D",      # no docs
 ]
 
 [tool.codespell]

tests/conftest.py

@@ -1,11 +1,11 @@
 from __future__ import annotations
 
+from pathlib import Path
 from typing import TYPE_CHECKING
 
 import pytest
 from docutils import __version__ as docutils_version
 from sphinx import __display_version__ as sphinx_version
-from sphinx.testing.path import path
 
 if TYPE_CHECKING:
     from _pytest.config import Config
@@ -19,8 +19,8 @@ def pytest_report_header(config: Config) -> str:  # noqa: ARG001
 
 
 @pytest.fixture(scope="session", name="rootdir")
-def root_dir() -> path:
-    return path(__file__).parent.parent.abspath() / "roots"
+def root_dir() -> Path:
+    return Path(__file__).parents[1].absolute() / "roots"
 
 
 def pytest_configure(config: Config) -> None:

tox.ini

@@ -7,7 +7,6 @@ env_list =
     py311
     py310
     py39
-    py38
     type
     pkg_check
 skip_missing_interpreters = true
@@ -32,10 +31,9 @@ commands =
 
 [testenv:fix]
 description = run static analysis and style check using flake8
-base_python = python3.10
 skip_install = true
 deps =
-    pre-commit>=3.5
+    pre-commit>=3.7
 pass_env =
     HOMEPATH
     PROGRAMDATA
@@ -46,8 +44,8 @@ commands =
 [testenv:type]
 description = run type check on code base
 deps =
-    mypy==1.7.1
-    types-docutils>=0.20.0.3
+    mypy==1.9
+    types-docutils>=0.20.0.20240406
 set_env =
     {tty:MYPY_FORCE_COLOR = 1}
 commands =
@@ -56,23 +54,22 @@ commands =
 
 [testenv:pkg_check]
 description = check that the long description is valid
-base_python = python3.10
 skip_install = true
 deps =
-    build[virtualenv]>=1.0.3
-    twine>=4.0.2
+    build[virtualenv]>=1.2.1
+    twine>=5
 change_dir = {toxinidir}
 commands =
     python -m build --sdist --wheel -o {envtmpdir} .
     twine check {envtmpdir}/*
 
 [testenv:dev]
 description = generate a DEV environment
-base_python = python3.10
 package = editable
 extras =
     docs
     test
 commands =
     python -m pip list --format=columns
     python -c 'import sys; print(sys.executable)'
+uv_seed = true