Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Commit 02ec91f

Browse files
authored
docs: Update project documentation (#130)
* docs: Update docs for project * Update developer.md * Update developer.md * Update CONTRIBUTING.md
1 parent c7a8fb7 commit 02ec91f

File tree

3 files changed

+20
-24
lines changed

3 files changed

+20
-24
lines changed

CONTRIBUTING.md

+16
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ today! As a contributor, here are the guidelines we would like you to follow:
66
- [Code of Conduct](#coc)
77
- [Found a Bug?](#found-bug)
88
- [Submit an Issue](#submit-issue)
9+
- [Submit an Pull Request](#pull-req)
910
- [Development Process](#dev)
1011

1112
## <a name="coc"></a> Code of Conduct
@@ -27,5 +28,20 @@ We want to fix all the issues as soon as possible, but before fixing a bug we ne
2728

2829
You can file new issues by filling out our [new issue form](https://github.com/trimox/angular-mdc-web/issues/new).
2930

31+
## <a name="pull-req"></a> Submit a Pull Request
32+
When submitting PRs, make sure you're following our commit message conventions; our commit-msg hook should automatically enforce this. We also use [commitizen](https://www.npmjs.com/package/commitizen), which you can use to auto-format commit messages for you.
33+
34+
Commit message type must be one of the following:
35+
* **feat**: A new feature
36+
* **fix**: A bug fix
37+
* **docs**: Documentation only changes
38+
* **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
39+
* **refactor**: A code change that neither fixes a bug nor adds a feature
40+
* **perf**: A code change that improves performance
41+
* **test**: Adding missing or correcting existing tests
42+
* **chore**: Changes to the build process or auxiliary tools and libraries such as documentation generation
43+
44+
When submitting PRs for large changes, be sure to include an adequate background in the description so that reviewers of the PR know what the changes entail at a high-level, the motivations for making these changes, and what they affect.
45+
3046
## <a name="dev"></a> Development Process
3147
Check out our [Developer guide](https://github.com/trimox/angular-mdc-web/blob/master/docs/developer.md).

docs/developer.md

+2-18
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@
33
- [Infrastructure and Tooling](#tools)
44
- [Setup your development environment](#setup)
55
- [Running the Development Server](#dev-server)
6-
- [Linting / Testing](#lint)
6+
- [Linting](#lint)
77
- [Building](#build)
88
- [Code Style](#code-style)
9-
- [Submit Pull Request](#pull-req)
109

1110
## <a name="tools"></a> Infrastructure and Tooling
1211

@@ -38,7 +37,7 @@ npm run start
3837
```
3938
After your development server is running, open a browser to url: http://localhost:4000
4039

41-
## <a name="lint"></a> Linting / Testing
40+
## <a name="lint"></a> Linting
4241
```
4342
npm run lint:ts # Lints typescript using tslint
4443
npm run lint:css # Lints (S)CSS using stylelint
@@ -54,18 +53,3 @@ npm run build # Builds Angular MDC inside of dist/
5453
We follow [Google's JavaScript Style Guide](https://google.github.io/styleguide/jsguide.html) and our entire coding style is enforced automatically through the use of linters.
5554
* [tslint rules](https://github.com/trimox/angular-mdc-web/blob/master/tslint.json)
5655
* [stylelint config](https://github.com/trimox/angular-mdc-web/blob/master/.stylelint-config.yaml)
57-
58-
## <a name="pull-req"></a> Submit a Pull Request
59-
When submitting PRs, make sure you're following our commit message conventions; our commit-msg hook should automatically enforce this. We also use [commitizen](https://www.npmjs.com/package/commitizen), which you can use to auto-format commit messages for you.
60-
61-
Commit message type must be one of the following:
62-
* **feat**: A new feature
63-
* **fix**: A bug fix
64-
* **docs**: Documentation only changes
65-
* **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
66-
* **refactor**: A code change that neither fixes a bug nor adds a feature
67-
* **perf**: A code change that improves performance
68-
* **test**: Adding missing or correcting existing tests
69-
* **chore**: Changes to the build process or auxiliary tools and libraries such as documentation generation
70-
71-
When submitting PRs for large changes, be sure to include an adequate background in the description so that reviewers of the PR know what the changes entail at a high-level, the motivations for making these changes, and what they affect.

docs/getting-started.md

+2-6
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ export class ExampleModule { }
2929

3030
### Or individual components
3131
```ts
32-
import { FabModule, MenuModule } from '@angular-mdc/web';
32+
import { MdcFabModule, MdcMenuModule } from '@angular-mdc/web';
3333

3434
@NgModule({
3535
...
36-
imports: [FabModule, MenuModule],
36+
imports: [MdcFabModule, MdcMenuModule],
3737
...
3838
})
3939
export class ExampleModule { }
@@ -51,10 +51,6 @@ Alternatively, you can use a CDN.
5151
```html
5252
<link href="https://unpkg.com/material-components-web/dist/material-components-web.css" rel="stylesheet">
5353
```
54-
Or link directly to the node_modules file.
55-
```html
56-
<link href="node_modules/material-components-web/dist/material-components-web.css" rel="stylesheet">
57-
```
5854

5955
## <a name="step4"></a> Step 4: Include Material Design Icons
6056
Add the [Material Design Icons](https://material.io/icons/) collection to your `index.html`.

0 commit comments

Comments
 (0)