From 21c54c31e3c9e370eb0c1a0c3be5a95301b06aff Mon Sep 17 00:00:00 2001 From: nnshah1 Date: Wed, 15 May 2024 05:03:58 -0700 Subject: [PATCH 1/2] update to use logging macros for JSON values --- src/onnxruntime.cc | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/onnxruntime.cc b/src/onnxruntime.cc index b71c1da..c706f27 100644 --- a/src/onnxruntime.cc +++ b/src/onnxruntime.cc @@ -936,11 +936,8 @@ ModelState::AutoCompleteConfig() } if (TRITONSERVER_LogIsEnabled(TRITONSERVER_LOG_VERBOSE)) { - triton::common::TritonJson::WriteBuffer buffer; - RETURN_IF_ERROR(ModelConfig().PrettyWrite(&buffer)); - LOG_MESSAGE( - TRITONSERVER_LOG_INFO, - (std::string("post auto-complete:\n") + buffer.Contents()).c_str()); + LOG_JSON_VALUE( + TRITONSERVER_LOG_VERBOSE, "post auto-complete:", ModelConfig()); } return nullptr; // success @@ -2828,13 +2825,13 @@ TRITONBACKEND_Initialize(TRITONBACKEND_Backend* backend) RETURN_IF_ERROR( TRITONBACKEND_BackendConfig(backend, &backend_config_message)); + LOG_JSON_MESSAGE( + TRITONSERVER_LOG_INFO, "backend configuration:", backend_config_message); + const char* buffer; size_t byte_size; RETURN_IF_ERROR(TRITONSERVER_MessageSerializeToJson( backend_config_message, &buffer, &byte_size)); - LOG_MESSAGE( - TRITONSERVER_LOG_INFO, - (std::string("backend configuration:\n") + buffer).c_str()); triton::common::TritonJson::Value backend_config; TRITONSERVER_Error* err = nullptr; From 8df77c1777f44289e451cd12d620b444f2a4c0cb Mon Sep 17 00:00:00 2001 From: nnshah1 Date: Wed, 15 May 2024 14:08:49 -0700 Subject: [PATCH 2/2] updated based on review comments --- src/onnxruntime.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/onnxruntime.cc b/src/onnxruntime.cc index c706f27..cbaf6f3 100644 --- a/src/onnxruntime.cc +++ b/src/onnxruntime.cc @@ -2825,7 +2825,7 @@ TRITONBACKEND_Initialize(TRITONBACKEND_Backend* backend) RETURN_IF_ERROR( TRITONBACKEND_BackendConfig(backend, &backend_config_message)); - LOG_JSON_MESSAGE( + LOG_SERVER_MESSAGE( TRITONSERVER_LOG_INFO, "backend configuration:", backend_config_message); const char* buffer;