fix: PDOStatement remove conn

Author: levydsa

flake.nix

@@ -32,6 +32,11 @@
               php
               turso-cli
             ] ++ lib.optionals stdenv.isDarwin [ iconv ];
+
+            shellHook = ''
+              export TURSO_URL=$(turso db show --url php-test)
+              export TURSO_AUTH_TOKEN=$(turso db tokens create -e 1d php-test)
+            '';
           };
       });
 }

src/PDO.php

@@ -87,7 +87,6 @@ public function prepare(string $query, array $options = []): PDOStatement|false
         return new PDOStatement(
             $prepare,
             $query,
-            $conn,
         );
     }
 
@@ -101,6 +100,7 @@ public function errorInfo(): array
         throw new \Exception('Not implemented');
     }
 
+    #[\ReturnTypeWillChange]
     public function lastInsertId(?string $name = null): string|int|false
     {
         return $this->conn->lastInsertId();

src/PDOStatement.php

@@ -11,7 +11,7 @@ class PDOStatement extends \PDOStatement
     private ?int $affectedRows = null;
     private ?int $mode = PDO::FETCH_BOTH;
 
-    public function __construct(private Statement $statement, string $query, private Connection $conn)
+    public function __construct(private Statement $statement, string $query)
     {
         $this->query = $query;
     }

tests/Test.php

@@ -122,6 +122,36 @@ public function testEmbeddedReplica(): void
         }
     }
 
+    public function testRemoteReplica(): void
+    {
+        $db = new Database(
+            url: getenv('TURSO_URL'),
+            authToken: getenv('TURSO_AUTH_TOKEN'),
+        );
+        $conn = $db->connect();
+
+        $conn->execute('drop table if exists test');
+        $conn->execute('create table test (i integer, r real, t text)');
+
+        $max = 20;
+
+        foreach (range(0, $max - 1) as $i) {
+            $stmt = $conn->prepare('insert into test values (:a, :b, :c)');
+            $stmt->bind([
+                ":a" => $i,
+                ":b" => exp($i / 10),
+                ":c" => strval(exp($i / 10))
+            ]);
+            $stmt->execute();
+        }
+
+        foreach ($conn->query('select * from test') as $i => $row) {
+            $this->assertSame($row->i, $i);
+            # $this->assertSame($row->r, exp($i / 10));
+            $this->assertSame($row->t, strval(exp($i / 10)));
+        }
+    }
+
     public function testBlob(): void
     {
         $db = new Database();
@@ -195,8 +225,31 @@ public function testPDORemoteFetchObj(): void
 
         foreach ($rows as $i => $row) {
             $this->assertSame($row->i, $i);
-            $this->assertSame($row->r, exp($i / 10));
             $this->assertSame($row->t, strval(exp($i / 10)));
         }
     }
+
+    public function testPDOTransaction(): void
+    {
+        $pdo = new \Libsql\PDO();
+
+        $tx = $pdo->beginTransaction();
+
+        $pdo->exec('create table test(i integer)');
+
+        $pdo->exec('insert into test values (0)');
+        $pdo->exec('insert into test values (1)');
+        $pdo->exec('insert into test values (2)');
+
+        $statement = $pdo->prepare('select * from test');
+        $statement->execute();
+        $statement->setFetchMode(\Libsql\PDO::FETCH_OBJ);
+        $rows = $statement->fetchAll();
+
+        foreach ($rows as $i => $row) {
+            $this->assertSame($row->i, $i);
+        }
+
+        $tx = $pdo->commit();
+    }
 }