Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockquote examples mismatch between typography and card #41292

Closed
3 tasks done
FlorentTorregrosa opened this issue Mar 12, 2025 · 0 comments · Fixed by #41295
Closed
3 tasks done

Blockquote examples mismatch between typography and card #41292

FlorentTorregrosa opened this issue Mar 12, 2025 · 0 comments · Fixed by #41295

Comments

@FlorentTorregrosa
Copy link

Prerequisites

Describe the issue

In documentation, Content > Typography > Naming a source:

The HTML spec requires that blockquote attribution be placed outside the <blockquote>. When providing attribution, wrap your <blockquote> in a <figure> and use a <figcaption> or a block level element (e.g., <p>) with the .blockquote-footer class. Be sure to wrap the name of the source work in <cite> as well.

<figure>
  <blockquote class="blockquote">
    <p>A well-known quote, contained in a blockquote element.</p>
  </blockquote>
  <figcaption class="blockquote-footer">
    Someone famous in <cite title="Source Title">Source Title</cite>
  </figcaption>
</figure>

In documentation, Components > Card > Header and Footer, there is an example of a quote with source in a card but the HTML does not match the example in typography:

<div class="card">
  <div class="card-header">
    Quote
  </div>
  <div class="card-body">
    <blockquote class="blockquote mb-0">
      <p>A well-known quote, contained in a blockquote element.</p>
      <footer class="blockquote-footer">Someone famous in <cite title="Source Title">Source Title</cite></footer>
    </blockquote>
  </div>
</div>

The source is not outside the blockquote tag and not in a figcaption.

I found the related PR:

And regarding the PRs, I think it is the example in card which should be updated.

If I got confirmation that it is that which should be fixed, I can try to provide a PR.

Reduced test cases

The card example should contain something like that in for its HTML, Maybe CSS will need to be adapted because currently not looking exactly like the documentation example:

<div class="card">
  <div class="card-header">
    Quote
  </div>
  <div class="card-body">
    <figure class="mb-0">
      <blockquote class="blockquote">
        <p>A well-known quote, contained in a blockquote element.</p>
      </blockquote>
      <figcaption class="blockquote-footer">
        Someone famous in <cite title="Source Title">Source Title</cite>
      </figcaption>
    </figure>
  </div>
</div>

What operating system(s) are you seeing the problem on?

Linux

What browser(s) are you seeing the problem on?

No response

What version of Bootstrap are you using?

v5.3.3

viniciusvts added a commit to viniciusvts/bootstrap that referenced this issue Mar 13, 2025
viniciusvts added a commit to viniciusvts/bootstrap that referenced this issue Mar 13, 2025
@mdo mdo added this to v5.3.6 Apr 10, 2025
@github-project-automation github-project-automation bot moved this to To do in v5.3.6 Apr 10, 2025
mdo pushed a commit that referenced this issue Apr 11, 2025
* fix: blockquote mismatch in card

Refs: #41292

* fix: blockquote mismatch in reboot

Refs: #41292
@github-project-automation github-project-automation bot moved this from To do to Done in v5.3.6 Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants