Merge pull request #606 from tweenjs/remove-string-arg-from-start-method

trusktr · web-flow · commit d8b4f09fb3e2 · 2021-04-26T20:53:53.000-07:00
remove support for string arguments to start and mark the argument as…
diff --git a/src/Tween.ts b/src/Tween.ts
@@ -78,7 +78,7 @@ export class Tween<T extends UnknownProps> {
 		return this
 	}
 
-	start(time?: number): this {
+	start(time: number = now()): this {
 		if (this._isPlaying) {
 			return this
 		}
@@ -108,7 +108,7 @@ export class Tween<T extends UnknownProps> {
 
 		this._isChainStopped = false
 
-		this._startTime = time !== undefined ? (typeof time === 'string' ? now() + parseFloat(time) : time) : now()
+		this._startTime = time
 		this._startTime += this._delayTime
 
 		this._setupProperties(this._object, this._valuesStart, this._valuesEnd, this._valuesStartRepeat)

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ export class Tween<T extends UnknownProps> {`
`78`	`78`	`return this`
`79`	`79`	`}`
`80`	`80`
`81`		`- start(time?: number): this {`
	`81`	`+ start(time: number = now()): this {`
`82`	`82`	`if (this._isPlaying) {`
`83`	`83`	`return this`
`84`	`84`	`}`
`@@ -108,7 +108,7 @@ export class Tween<T extends UnknownProps> {`
`108`	`108`
`109`	`109`	`this._isChainStopped = false`
`110`	`110`
`111`		`- this._startTime = time !== undefined ? (typeof time === 'string' ? now() + parseFloat(time) : time) : now()`
	`111`	`+ this._startTime = time`
`112`	`112`	`this._startTime += this._delayTime`
`113`	`113`
`114`	`114`	`this._setupProperties(this._object, this._valuesStart, this._valuesEnd, this._valuesStartRepeat)`