Skip to content
This repository was archived by the owner on Nov 8, 2017. It is now read-only.

Deprecation types option #298

Open
Frexuz opened this issue Nov 8, 2016 · 3 comments
Open

Deprecation types option #298

Frexuz opened this issue Nov 8, 2016 · 3 comments

Comments

@Frexuz
Copy link

Frexuz commented Nov 8, 2016

https://developers.google.com/maps/documentation/javascript/places?csw=1#deprecation

Should change your API accordingly :)

Awesome project btw!

@chrisli30
Copy link

chrisli30 commented Dec 12, 2016

I really like this library which saved me a lot of work on UI so I researched Google and made "types" work again in #301 .

  1. Google has changed the parameter from "types" to "type", but most of type values remain unchanged.

  2. Regardless, the only change we need to make is to explicitly call a new method setTypes() of AutoComplete. For example, I added this line right after autocomplete object initialization.
    this.autocomplete.setTypes(options.types);

@chrisli30
Copy link

I did test locally but didn't check in test code due to lake of cleanness. Hope it helps!

@aemkei
Copy link
Member

aemkei commented Jan 12, 2017

This is true for "text search requests" but looks like, AutoComplete is not affected: https://developers.google.com/maps/documentation/javascript/3.exp/reference#AutocompleteOptions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants