Skip to content

Commit 09cf248

Browse files
committed
Revert the somewhat unrelated mig log -> mig state log naming changes in PR75
as they may interfere with existing deployments. We should really rename the migridX syslog volumes in LOG_ROOT to something syslog'ish instead to reduce any confusion. Use just 'log' for the mig state log volume name to fit with naming of all other mig state subdirs.
1 parent 628f974 commit 09cf248

4 files changed

+42
-42
lines changed

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ initdirs: initcomposevars
121121
mkdir -p ${PERSISTENT_ROOT}/wwwpublic-vgrid
122122
mkdir -p ${PERSISTENT_ROOT}/wwwpublic-download
123123
mkdir -p ${PERSISTENT_ROOT}/secrets
124-
mkdir -p ${LOG_ROOT}/migstatelog
124+
mkdir -p ${LOG_ROOT}/miglog
125125
mkdir -p ${LOG_ROOT}/migrid
126126
mkdir -p ${LOG_ROOT}/migrid-io
127127
mkdir -p ${LOG_ROOT}/migrid-openid

docker-compose_development.yml

+14-14
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ services:
6363
env_file:
6464
- migrid-httpd.env
6565
# NOTE: public hosts should create users through sign up and run like this
66-
command: /app/docker-entry.sh -V
66+
command: /app/docker-entry.sh -V -c
6767

6868
# The migrid core services including httpd and tightly integrated services
6969
# like job handling (grid script, monitor, sshmux, imnoty and vmproxy)
@@ -121,7 +121,7 @@ services:
121121
source: state
122122
target: /home/mig/state
123123
- type: volume
124-
source: migstate-log
124+
source: log
125125
target: /home/mig/state/log
126126
# NOTE: for read-only vgrids/workgroups we need a local 'ro' bind-mount
127127
- type: bind
@@ -181,7 +181,7 @@ services:
181181
source: state
182182
target: /home/mig/state
183183
- type: volume
184-
source: migstate-log
184+
source: log
185185
target: /home/mig/state/log
186186
# NOTE: we don't need read-only vgrids/workgroups in the openid container
187187
# NOTE: mig_system_run is a shared volatile cache which gains from using host tmpfs
@@ -227,7 +227,7 @@ services:
227227
source: state
228228
target: /home/mig/state
229229
- type: volume
230-
source: migstate-log
230+
source: log
231231
target: /home/mig/state/log
232232
# NOTE: for read-only vgrids/workgroups we need a local 'ro' bind-mount
233233
- type: bind
@@ -277,7 +277,7 @@ services:
277277
source: state
278278
target: /home/mig/state
279279
- type: volume
280-
source: migstate-log
280+
source: log
281281
target: /home/mig/state/log
282282
# NOTE: for read-only vgrids/workgroups we need a local 'ro' bind-mount
283283
- type: bind
@@ -326,7 +326,7 @@ services:
326326
source: state
327327
target: /home/mig/state
328328
- type: volume
329-
source: migstate-log
329+
source: log
330330
target: /home/mig/state/log
331331
# NOTE: for read-only vgrids/workgroups we need a local 'ro' bind-mount
332332
- type: bind
@@ -408,6 +408,14 @@ volumes:
408408

409409
# NOTE: we don't bother setting up persistent data outside state here
410410

411+
log:
412+
# Volume used to contain the mig state log folder shared by all containers
413+
driver: local
414+
driver_opts:
415+
type: none
416+
device: ${LOG_ROOT}/miglog
417+
o: bind
418+
411419
migrid-syslog:
412420
# Volume used for exposing migrid container system log
413421
driver: local
@@ -447,11 +455,3 @@ volumes:
447455
type: none
448456
device: ${LOG_ROOT}/migrid-ftps
449457
o: bind
450-
451-
migstate-log:
452-
# Volume used to contain the migrid state log
453-
driver: local
454-
driver_opts:
455-
type: none
456-
device: ${LOG_ROOT}/migstatelog
457-
o: bind

docker-compose_development_gdp.yml

+14-14
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ services:
121121
source: state
122122
target: /home/mig/state
123123
- type: volume
124-
source: migstate-log
124+
source: log
125125
target: /home/mig/state/log
126126
# NOTE: for read-only vgrids/workgroups we need a local 'ro' bind-mount
127127
- type: bind
@@ -185,7 +185,7 @@ services:
185185
source: state
186186
target: /home/mig/state
187187
- type: volume
188-
source: migstate-log
188+
source: log
189189
target: /home/mig/state/log
190190
# NOTE: we don't need read-only vgrids/workgroups in the openid container
191191
# NOTE: mig_system_run is a shared volatile cache which gains from using host tmpfs
@@ -231,7 +231,7 @@ services:
231231
source: state
232232
target: /home/mig/state
233233
- type: volume
234-
source: migstate-log
234+
source: log
235235
target: /home/mig/state/log
236236
# NOTE: for read-only vgrids/workgroups we need a local 'ro' bind-mount
237237
- type: bind
@@ -281,7 +281,7 @@ services:
281281
source: state
282282
target: /home/mig/state
283283
- type: volume
284-
source: migstate-log
284+
source: log
285285
target: /home/mig/state/log
286286
# NOTE: for read-only vgrids/workgroups we need a local 'ro' bind-mount
287287
- type: bind
@@ -330,7 +330,7 @@ services:
330330
source: state
331331
target: /home/mig/state
332332
- type: volume
333-
source: migstate-log
333+
source: log
334334
target: /home/mig/state/log
335335
# NOTE: for read-only vgrids/workgroups we need a local 'ro' bind-mount
336336
- type: bind
@@ -411,9 +411,17 @@ volumes:
411411
type: none
412412
device: ${DOCKER_MIGRID_ROOT}/state
413413
o: bind
414-
414+
415415
# NOTE: we don't bother setting up persistent data outside state here
416416

417+
log:
418+
# Volume used to contain the mig state log folder shared by all containers
419+
driver: local
420+
driver_opts:
421+
type: none
422+
device: ${LOG_ROOT}/miglog
423+
o: bind
424+
417425
migrid-syslog:
418426
# Volume used for exposing migrid container system log
419427
driver: local
@@ -453,11 +461,3 @@ volumes:
453461
type: none
454462
device: ${LOG_ROOT}/migrid-ftps
455463
o: bind
456-
457-
migstate-log:
458-
# Volume used to contain the migrid state log
459-
driver: local
460-
driver_opts:
461-
type: none
462-
device: ${LOG_ROOT}/migstatelog
463-
o: bind

docker-compose_production_bind.yml

+13-13
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ services:
102102
source: state
103103
target: /home/mig/state
104104
- type: volume
105-
source: migstate-log
105+
source: log
106106
target: /home/mig/state/log
107107
- type: volume
108108
source: secrets
@@ -228,7 +228,7 @@ services:
228228
source: state
229229
target: /home/mig/state
230230
- type: volume
231-
source: migstate-log
231+
source: log
232232
target: /home/mig/state/log
233233
- type: volume
234234
source: secrets
@@ -347,7 +347,7 @@ services:
347347
source: state
348348
target: /home/mig/state
349349
- type: volume
350-
source: migstate-log
350+
source: log
351351
target: /home/mig/state/log
352352
- type: volume
353353
source: secrets
@@ -465,7 +465,7 @@ services:
465465
source: state
466466
target: /home/mig/state
467467
- type: volume
468-
source: migstate-log
468+
source: log
469469
target: /home/mig/state/log
470470
- type: volume
471471
source: secrets
@@ -583,7 +583,7 @@ services:
583583
source: state
584584
target: /home/mig/state
585585
- type: volume
586-
source: migstate-log
586+
source: log
587587
target: /home/mig/state/log
588588
- type: volume
589589
source: secrets
@@ -935,6 +935,14 @@ volumes:
935935
device: ${PERSISTENT_ROOT}/vgrid_files_writable
936936
o: bind
937937

938+
log:
939+
# Volume used to contain the mig state log folder shared by all containers
940+
driver: local
941+
driver_opts:
942+
type: none
943+
device: ${LOG_ROOT}/miglog
944+
o: bind
945+
938946
migrid-syslog:
939947
# Volume used for exposing migrid container system log
940948
driver: local
@@ -974,11 +982,3 @@ volumes:
974982
type: none
975983
device: ${LOG_ROOT}/migrid-ftps
976984
o: bind
977-
978-
migstate-log:
979-
# Volume used to contain the migrid state log
980-
driver: local
981-
driver_opts:
982-
type: none
983-
device: ${LOG_ROOT}/migstatelog
984-
o: bind

0 commit comments

Comments
 (0)