Skip to content

Commit 3163a17

Browse files
authored
Merge pull request #1526 from unoplatform/dev/erli/1525-fix-button-pointer-focused
fix: Wrap focus related states in a FocusStates vsg
2 parents 74567f3 + 7f3a9f1 commit 3163a17

File tree

1 file changed

+33
-4
lines changed

1 file changed

+33
-4
lines changed

src/library/Uno.Material/Styles/Controls/v2/Button.xaml

+33-4
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,9 @@
460460
<Setter Target="ElevatedView.Elevation" Value="{ThemeResource ElevatedButtonElevationDisabled}" />
461461
</VisualState.Setters>
462462
</VisualState>
463+
</VisualStateGroup>
463464

465+
<VisualStateGroup x:Name="FocusStates">
464466
<VisualState x:Name="Focused">
465467
<VisualState.Setters>
466468
<Setter Target="Root.Background" Value="{ThemeResource ElevatedButtonBackgroundFocused}" />
@@ -480,6 +482,8 @@
480482
<Setter Target="Root.BorderBrush" Value="{ThemeResource ElevatedButtonBorderBrushPointerFocused}" />
481483
</VisualState.Setters>
482484
</VisualState>
485+
486+
<VisualState x:Name="Unfocused" />
483487
</VisualStateGroup>
484488
</VisualStateManager.VisualStateGroups>
485489

@@ -596,6 +600,10 @@
596600
</VisualState.Setters>
597601
</VisualState>
598602

603+
604+
</VisualStateGroup>
605+
606+
<VisualStateGroup x:Name="FocusStates">
599607
<VisualState x:Name="Focused">
600608
<VisualState.Setters>
601609
<Setter Target="Root.Background" Value="{ThemeResource FilledButtonBackgroundFocused}" />
@@ -615,6 +623,8 @@
615623
<Setter Target="Root.BorderBrush" Value="{ThemeResource FilledButtonBorderBrushPointerFocused}" />
616624
</VisualState.Setters>
617625
</VisualState>
626+
627+
<VisualState x:Name="Unfocused" />
618628
</VisualStateGroup>
619629
</VisualStateManager.VisualStateGroups>
620630

@@ -730,7 +740,9 @@
730740
<Setter Target="Root.BorderBrush" Value="{ThemeResource FilledTonalButtonBorderBrushDisabled}" />
731741
</VisualState.Setters>
732742
</VisualState>
743+
</VisualStateGroup>
733744

745+
<VisualStateGroup x:Name="FocusStates">
734746
<VisualState x:Name="Focused">
735747
<VisualState.Setters>
736748
<Setter Target="Root.Background" Value="{ThemeResource FilledTonalButtonBackgroundFocused}" />
@@ -750,6 +762,8 @@
750762
<Setter Target="Root.BorderBrush" Value="{ThemeResource FilledTonalButtonBorderBrushPointerFocused}" />
751763
</VisualState.Setters>
752764
</VisualState>
765+
766+
<VisualState x:Name="Unfocused" />
753767
</VisualStateGroup>
754768
</VisualStateManager.VisualStateGroups>
755769

@@ -867,7 +881,9 @@
867881
<Setter Target="ContentPresenter.Foreground" Value="{ThemeResource OutlinedButtonForegroundDisabled}" />
868882
</VisualState.Setters>
869883
</VisualState>
884+
</VisualStateGroup>
870885

886+
<VisualStateGroup x:Name="FocusStates">
871887
<VisualState x:Name="Focused">
872888
<VisualState.Setters>
873889
<Setter Target="Root.Background" Value="{ThemeResource OutlinedButtonBackgroundFocused}" />
@@ -887,6 +903,8 @@
887903
<Setter Target="Root.BorderBrush" Value="{ThemeResource OutlinedButtonBorderBrushPointerFocused}" />
888904
</VisualState.Setters>
889905
</VisualState>
906+
907+
<VisualState x:Name="Unfocused" />
890908
</VisualStateGroup>
891909
</VisualStateManager.VisualStateGroups>
892910

@@ -995,7 +1013,9 @@
9951013
<Setter Target="Root.BorderBrush" Value="{ThemeResource TextButtonBorderBrushDisabled}" />
9961014
</VisualState.Setters>
9971015
</VisualState>
1016+
</VisualStateGroup>
9981017

1018+
<VisualStateGroup x:Name="FocusStates">
9991019
<VisualState x:Name="Focused">
10001020
<VisualState.Setters>
10011021
<Setter Target="Root.Background" Value="{ThemeResource TextButtonBackgroundFocused}" />
@@ -1015,6 +1035,8 @@
10151035
<Setter Target="Root.BorderBrush" Value="{ThemeResource TextButtonBorderBrushPointerFocused}" />
10161036
</VisualState.Setters>
10171037
</VisualState>
1038+
1039+
<VisualState x:Name="Unfocused" />
10181040
</VisualStateGroup>
10191041
</VisualStateManager.VisualStateGroups>
10201042

@@ -1096,16 +1118,23 @@
10961118
<Setter Target="PressedOverlay.Opacity" Value="{ThemeResource IconButtonOpacityVisibleState}" />
10971119
</VisualState.Setters>
10981120
</VisualState>
1099-
<VisualState x:Name="Focused">
1121+
<VisualState x:Name="Disabled">
11001122
<VisualState.Setters>
1101-
<Setter Target="FocusedOverlay.Opacity" Value="{ThemeResource IconButtonOpacityVisibleState}" />
1123+
<Setter Target="ContentPresenter.Foreground" Value="{ThemeResource IconButtonForegroundDisabled}" />
11021124
</VisualState.Setters>
11031125
</VisualState>
1104-
<VisualState x:Name="Disabled">
1126+
</VisualStateGroup>
1127+
1128+
<VisualStateGroup x:Name="FocusStates">
1129+
<VisualState x:Name="Focused">
11051130
<VisualState.Setters>
1106-
<Setter Target="ContentPresenter.Foreground" Value="{ThemeResource IconButtonForegroundDisabled}" />
1131+
<Setter Target="FocusedOverlay.Opacity" Value="{ThemeResource IconButtonOpacityVisibleState}" />
11071132
</VisualState.Setters>
11081133
</VisualState>
1134+
1135+
<VisualState x:Name="PointerFocused" />
1136+
1137+
<VisualState x:Name="Unfocused" />
11091138
</VisualStateGroup>
11101139
</VisualStateManager.VisualStateGroups>
11111140

0 commit comments

Comments
 (0)