Skip to content

Commit df2f6f8

Browse files
committed
Remove flag type generation code
and related tooling, given all of it has been replaced by ✨ generics magic ✨ Connected to #833
1 parent 04736d1 commit df2f6f8

18 files changed

+3
-771
lines changed

.github/workflows/cli.yml

-2
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,10 @@ jobs:
3434
env:
3535
GFLAGS: -tags urfave_cli_no_docs
3636
- run: make test
37-
- run: make -C cmd/urfave-cli-genflags
3837
- run: make check-binary-size
3938
env:
4039
GFLAGS: -tags urfave_cli_no_docs
4140
- run: make check-binary-size
42-
- run: make yamlfmt
4341
- if: matrix.go == '1.19.x' && matrix.os == 'ubuntu-latest'
4442
run: make generate
4543
- run: make diffcheck

.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
.envrc
66
.idea
77
/.local/
8-
/cmd/urfave-cli-genflags/urfave-cli-genflags
98
/site/
109
coverage.txt
1110
internal/*/built-example

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
GO_RUN_BUILD := go run internal/build/build.go
88

99
.PHONY: all
10-
all: generate vet test check-binary-size gfmrun yamlfmt
10+
all: generate vet test check-binary-size gfmrun
1111

1212
# NOTE: this is a special catch-all rule to run any of the commands
1313
# defined in internal/build/build.go with optional arguments passed

cli.go

-2
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,3 @@
2121
// app.Run(os.Args)
2222
// }
2323
package cli
24-
25-
//go:generate make -C cmd/urfave-cli-genflags run

cmd/urfave-cli-genflags/Makefile

-28
This file was deleted.

cmd/urfave-cli-genflags/README.md

-15
This file was deleted.

cmd/urfave-cli-genflags/generated.gotmpl

-87
This file was deleted.

cmd/urfave-cli-genflags/generated_altsrc.gotmpl

-29
This file was deleted.

cmd/urfave-cli-genflags/generated_test.gotmpl

-42
This file was deleted.

cmd/urfave-cli-genflags/go.mod

-15
This file was deleted.

cmd/urfave-cli-genflags/go.sum

-14
This file was deleted.

0 commit comments

Comments
 (0)