Skip to content

Remove allow(clippy::if_then_panic) from spread allocate tests #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HCastano opened this issue Nov 9, 2021 · 2 comments
Closed

Remove allow(clippy::if_then_panic) from spread allocate tests #1009

HCastano opened this issue Nov 9, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@HCastano
Copy link
Contributor

HCastano commented Nov 9, 2021

Follow up to #995.

As per the code:

The synstructure crate currently expands to code that has a single
panic inside an if block. We have to allow the following clippy
lint until the fixing PR has been merged:
PR: mystor/synstructure#50
@HCastano HCastano added the good first issue Good for newcomers label Nov 9, 2021
@HCastano HCastano mentioned this issue Nov 9, 2021
Merged
@cmichi
Copy link
Collaborator

cmichi commented Nov 9, 2021

Ahem: #1005

@HCastano
Copy link
Contributor Author

HCastano commented Nov 9, 2021

😄

@HCastano HCastano closed this as completed Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmichi @HCastano