feat: upgrade to node 18 (#16)

Author: joelkesler

README.md

@@ -85,9 +85,9 @@ As Mac OS has recently removed the bundled copy of Python 2.7, please see [this
 **Installing and Upgrading Node and NPM versions**\
 There is a handy command in your `.bash_profile` and `.zsh_profile` that will automatically install your chosen version of Node and NPM, re-install any global npm packages (like angular cli), and set the newly installed version as default.
 
-We use Node v16 at Vendasta. To upgrade to the latest version of Node 16, re-install global npm packages, and set it as default, run the following command:
+We use Node v18 at Vendasta. To upgrade to the latest version of Node 18, re-install global npm packages, and set it as default, run the following command:
 ```sh
-node-upgrade 16
+node-upgrade 18
 ```
 
 If you wish to install a version of node without reinstalling all global packages or setting it to be default, you can use NVM directly ([Official docs][nvm docs]):
@@ -202,7 +202,7 @@ export NODE_OPTIONS=--max_old_space_size=12000
 
 # Update Node to selected version and reinstall previous packages
 node-upgrade() {
-    new_version=${1:?"Please specify a version to upgrade to. Example: node-upgrade 16"}
+    new_version=${1:?"Please specify a version to upgrade to. Example: node-upgrade 18"}
     nvm install "$new_version" --reinstall-packages-from=current
     nvm alias default "$new_version"
     # nvm uninstall "$prev_ver"
@@ -268,7 +268,7 @@ export NODE_OPTIONS=--max_old_space_size=12000
 
 # Update Node to selected version and reinstall previous packages
 node-upgrade() {
-    readonly new_version=${1:?"Please specify a version to upgrade to. Example: node-upgrade 16"}
+    readonly new_version=${1:?"Please specify a version to upgrade to. Example: node-upgrade 18"}
     nvm install "$new_version" --reinstall-packages-from=current
     nvm alias default "$new_version"
     # nvm uninstall "$prev_ver"
@@ -359,7 +359,7 @@ getLastestNVM() {
 curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/$(getLastestNVM)/install.sh | bash
 export NVM_DIR="$HOME/.nvm"
 [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
-nvm install 16
+nvm install 18
 npm install --location=global @angular/cli
 npm install --location=global nx
 npm install --location=global husky
@@ -714,7 +714,7 @@ This script helps new developers at Vendasta setup their laptops quicker, lettin
 I have tried to make this script simple and useful. You will want to customize the installation and configuration to match the tools and services you use at your company.
 
 - At Vendasta, we are using Go, Angular, and Google Cloud. You most likely do not use all of these, so remove, change, and tweak to meet your needs.
-- We lock our Node version at 16 (using NVM) for best compatibility with Angular and NX. You will likely want to change this. 
+- We lock our Node version at 18 (using NVM) for best compatibility with Angular and NX. You will likely want to change this. 
 - To customize the [welcome logo](https://github.com/vendasta/setup-new-computer-script/blob/47b7c97f21b293e143a0566cafecec2cfc69c528/setup-new-computer.sh#L74-L90) and add a bit of style, I used the handy [Text to ASCII Art Generator](https://patorjk.com/software/taag/#p=testall&f=Isometric1&t=Vendasta)
 - When you update the script, remember to update the readme "What's Installed" section too
 - Be sure to update both the `.bash_profile` and `.zprofile`

setup-new-computer.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-VERSION="v3.2.0"
+VERSION="v3.3.0"
 #===============================================================================
 # title           setup-new-computer.sh
 # author          Joel Kesler 
@@ -161,7 +161,7 @@ export NODE_OPTIONS=--max_old_space_size=12000
 
 # Update Node to selected version and reinstall previous packages
 node-upgrade() {
-    new_version=\${1:?"Please specify a version to upgrade to. Example: node-upgrade 16"}
+    new_version=\${1:?"Please specify a version to upgrade to. Example: node-upgrade 18"}
     nvm install "\$new_version" --reinstall-packages-from=current
     nvm alias default "\$new_version"
     # nvm uninstall "\$prev_ver"
@@ -232,7 +232,7 @@ export NODE_OPTIONS=--max_old_space_size=12000
 
 # Update Node to selected version and reinstall previous packages
 node-upgrade() {
-    readonly new_version=\${1:?"Please specify a version to upgrade to. Example: node-upgrade 16"}
+    readonly new_version=\${1:?"Please specify a version to upgrade to. Example: node-upgrade 18"}
     nvm install "\$new_version" --reinstall-packages-from=current
     nvm alias default "\$new_version"
     # nvm uninstall "\$prev_ver"
@@ -487,7 +487,7 @@ printHeading "Installing Node and Angular CLI through NVM"
         [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
     printDivider
         echo "Installing Node..."
-        nvm install 16
+        nvm install 18
     printStep "Angular CLI"             "npm install --location=global @angular/cli"
     printStep "NX"                      "npm install --location=global nx"
     printStep "Husky"                   "npm install --location=global husky"