-
Notifications
You must be signed in to change notification settings - Fork 7
Make Redis truly optional for StreamableHTTPServerTransport #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
hey @patricksevat , thanks a lot for the PR! I just put up this draft of a slightly different approach: #3 I was planning on deprecating support for SSE going forward (since anthropic has already deprecated it), and as a result removing the reliance on Redis It looks pretty aligned with your change and i'll get your opinion on it when i flush it out more! |
Hey @quuu , thanks for letting me know. I can work with my fork for now. |
@patricksevat hey patrick, after further thought -- i like your incremental approach more for now while there's a longer term migration for my change! would you like to re-open your PR? tested your change locally and it was a great improvement otherwise I don't mind applying your patch ill update the docs accordingly after merging in your redis change :) |
@quuu cool, reopened! |
@patricksevat merged, will update this thread when I publish the next version, should be out by later today/ tomorrow after i re- set up the github action to do the release |
Still need to update docs, but this fix is live as of 0.4.1! |
@quuu awesome, I updated the version, works like expected! |
Uh oh!
There was an error while loading. Please reload this page.
First of all thanks for creating this package, it's great that you'll be supporting MCP as NextJS Route Handlers!
I'm currently working on a simple StreamableHTTPServerTransport MCP server, but out of the box it doesn't work due to the awaiting on
redisPromise
: https://github.com/vercel/mcp-adapter/blob/main/src/next/mcp-api-handler.ts#L202If I comment that line out, it works as expected.
I'm wondering if the whole redis logic could perhaps be extracted away into an own function and only be called within the
if
-blocks forurl.pathname === sseEndpoint
andurl.pathname === sseMessageEndpoint
. The readme lists redis as being optional.I'd be happy to open a PR with this change
The text was updated successfully, but these errors were encountered: