RSDK-8469 - Fix offline dial (#128)

Author: stuqdog

Cargo.lock

@@ -59,7 +59,7 @@ tracing = {version = "0.1.34"}
 tracing-subscriber = {version = "0.3.11", features = ["env-filter"]}
 viam-mdns = "3.0.1"
 webpki-roots = "0.21.1"
-webrtc = "0.11.0"
+webrtc = { git = "https://github.com/webrtc-rs/webrtc.git", rev = "88dff7b1dd6880aaa3d3f60894f1be51169a2f9d" }
 
 [dev-dependencies]
 async-stream = "0.3.3"

Cargo.toml

@@ -56,7 +56,7 @@
 const STATUS_CODE_UNKNOWN: i32 = 2;
 const STATUS_CODE_RESOURCE_EXHAUSTED: i32 = 8;
 
 pub const VIAM_MDNS_SERVICE_NAME: &'static str = "_rpc._tcp.local";
 
 type SecretType = String;
 
@@ -400,7 +400,7 @@
 
         let ifaces: HashMap<&str, Vec<&IpAddr>> =
             ifaces.iter().fold(HashMap::new(), |mut map, (k, v)| {
                 map.entry(k).or_insert(vec![]).push(v);
                 map
             });
 
@@ -827,7 +827,7 @@
         .map_err(anyhow::Error::from)
         .map(|_| ())
     {
-        log::error!("Error sending done or error update: {e}");
+        log::error!("Error sending done or error update: {e}")
     }
 }
 
@@ -881,7 +881,7 @@
 
 impl fmt::Display for CallerUpdateStats {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         let average_duration = &self.total_duration.as_millis() / &self.count;
         writeln!(
             f,
             "Caller update statistics: num_updates: {}, average_duration: {}ms, max_duration: {}ms",

examples/Cargo.lock

@@ -15,6 +15,7 @@
         data_channel_init::RTCDataChannelInit, data_channel_message::DataChannelMessage,
         RTCDataChannel,
     },
+    dtls::extension::extension_use_srtp::SrtpProtectionProfile,
     ice::mdns::MulticastDnsMode,
     ice_transport::ice_server::RTCIceServer,
     interceptor::registry::Registry,
@@ -112,7 +113,6 @@
         urls: ice_server.urls,
         username: ice_server.username,
         credential: ice_server.credential,
-        credential_type: webrtc::ice_transport::ice_credential_type::RTCIceCredentialType::Password,
     }
 }
 
@@ -145,7 +145,20 @@
         interceptor_registry::register_default_interceptors(registry, &mut media_engine)?;
 
     let mut setting_engine = SettingEngine::default();
+
+    // A recent commit to the upstream webrtc library added `Srtp_Aead_Aes_256_Gcm` to the
+    // list of default `SrtpProtectionProfile`s. This caused assertion failures upstream in
+    // the `GenericArray` crate, which prevented us from connecting properly. Removing this
+    // default (which is consistent with how `rust-utils` has operated for the past several
+    // years) prevents the upstream conflicts and lets us avoid navigating potential conflicts
+    // in reworking the upstream defaults.
+    let srtp_protection_profiles = vec![
+        SrtpProtectionProfile::Srtp_Aead_Aes_128_Gcm,
+        SrtpProtectionProfile::Srtp_Aes128_Cm_Hmac_Sha1_80,
+    ];
+    setting_engine.set_srtp_protection_profiles(srtp_protection_profiles);
     setting_engine.set_ice_multicast_dns_mode(MulticastDnsMode::QueryAndGather);
+    setting_engine.set_include_loopback_candidate(true);
 
     Ok(APIBuilder::new()
         .with_media_engine(media_engine)
@@ -305,14 +318,14 @@
         None => "0".to_string(),
     };
 
     match proto.status {
         Some(ref status) => {
             let key = HeaderName::from_str("Grpc-Message").unwrap();
             let val = HeaderValue::from_str(&status.message).unwrap();
             trailers.insert(key, val);
         }
         None => (),
     }
 
     let k = match HeaderName::from_str(status_name) {
         Ok(k) => k,