Skip to content

Commit 3ddaeb9

Browse files
stuqdogstuqdog
authored
RSDK-3008 - add misc-unused-params (#216)
1 parent a501844 commit 3ddaeb9

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+257
-279
lines changed

‎.clang-tidy

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
# readability-named-parameter: Useful to fix lints about unused parameters
77
# readability-implicit-bool-conversion: We have decided that !ptr-type is cleaner than ptr-type==nullptr
88
# readability-magic-numbers: This encourages useless variables and extra lint lines
9-
# misc-unused-parameters: TODO(RSDK-3008) remove this and fix all lints.
109
# misc-include-cleaner: TODO(RSDK-5479) this is overly finnicky, add IWYU support and fix.
1110
# readability-function-cognitive-complexity: No, complexity is subjective and sometimes necessary.
1211
# readability-else-after-return: No, this causes code complexification
@@ -26,7 +25,6 @@ Checks: >
2625
-readability-named-parameter,
2726
-readability-implicit-bool-conversion,
2827
-readability-magic-numbers,
29-
-misc-unused-parameters,
3028
-misc-include-cleaner,
3129
-readability-function-cognitive-complexity,
3230
-readability-else-after-return,

‎src/viam/examples/modules/simple/main.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class Printer : public GenericService {
4343
std::cout << "Printer " << Resource::name() << " will print " << to_print_ << std::endl;
4444
}
4545

46-
AttributeMap do_command(AttributeMap command) {
46+
AttributeMap do_command(const AttributeMap& command) {
4747
std::cout << "Received DoCommand request for Printer " << Resource::name() << std::endl;
4848
std::cout << "Printer " << Resource::name() << " has printed " << to_print_ << std::endl;
4949
return command;

‎src/viam/sdk/components/base/server.cpp

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -16,28 +16,27 @@ BaseServer::BaseServer(std::shared_ptr<ResourceManager> manager)
1616
: ResourceServer(std::move(manager)){};
1717

1818
::grpc::Status BaseServer::MoveStraight(
19-
::grpc::ServerContext* context,
19+
::grpc::ServerContext*,
2020
const ::viam::component::base::v1::MoveStraightRequest* request,
21-
::viam::component::base::v1::MoveStraightResponse* response) noexcept {
21+
::viam::component::base::v1::MoveStraightResponse*) noexcept {
2222
return make_service_helper<Base>(
2323
"BaseServer::MoveStraight", this, request)([&](auto& helper, auto& base) {
2424
base->move_straight(request->distance_mm(), request->mm_per_sec(), helper.getExtra());
2525
});
2626
}
2727

28-
::grpc::Status BaseServer::Spin(::grpc::ServerContext* context,
28+
::grpc::Status BaseServer::Spin(::grpc::ServerContext*,
2929
const ::viam::component::base::v1::SpinRequest* request,
30-
::viam::component::base::v1::SpinResponse* response) noexcept {
30+
::viam::component::base::v1::SpinResponse*) noexcept {
3131
return make_service_helper<Base>(
3232
"BaseServer::Spin", this, request)([&](auto& helper, auto& base) {
3333
base->spin(request->angle_deg(), request->degs_per_sec(), helper.getExtra());
3434
});
3535
}
3636

37-
::grpc::Status BaseServer::SetPower(
38-
::grpc::ServerContext* context,
39-
const ::viam::component::base::v1::SetPowerRequest* request,
40-
::viam::component::base::v1::SetPowerResponse* response) noexcept {
37+
::grpc::Status BaseServer::SetPower(::grpc::ServerContext*,
38+
const ::viam::component::base::v1::SetPowerRequest* request,
39+
::viam::component::base::v1::SetPowerResponse*) noexcept {
4140
return make_service_helper<Base>(
4241
"BaseServer::SetPower", this, request)([&](auto& helper, auto& base) {
4342
auto linear = Vector3::from_proto(request->linear());
@@ -47,9 +46,9 @@ ::grpc::Status BaseServer::SetPower(
4746
}
4847

4948
::grpc::Status BaseServer::SetVelocity(
50-
::grpc::ServerContext* context,
49+
::grpc::ServerContext*,
5150
const ::viam::component::base::v1::SetVelocityRequest* request,
52-
::viam::component::base::v1::SetVelocityResponse* response) noexcept {
51+
::viam::component::base::v1::SetVelocityResponse*) noexcept {
5352
return make_service_helper<Base>(
5453
"BaseServer::SetVelocity", this, request)([&](auto& helper, auto& base) {
5554
auto linear = Vector3::from_proto(request->linear());
@@ -58,26 +57,25 @@ ::grpc::Status BaseServer::SetVelocity(
5857
});
5958
}
6059

61-
::grpc::Status BaseServer::Stop(::grpc::ServerContext* context,
60+
::grpc::Status BaseServer::Stop(::grpc::ServerContext*,
6261
const ::viam::component::base::v1::StopRequest* request,
63-
::viam::component::base::v1::StopResponse* response) noexcept {
62+
::viam::component::base::v1::StopResponse*) noexcept {
6463
return make_service_helper<Base>("BaseServer::Stop", this, request)(
6564
[&](auto& helper, auto& base) { base->stop(helper.getExtra()); });
6665
}
6766

6867
::grpc::Status BaseServer::IsMoving(
69-
::grpc::ServerContext* context,
68+
::grpc::ServerContext*,
7069
const ::viam::component::base::v1::IsMovingRequest* request,
7170
::viam::component::base::v1::IsMovingResponse* response) noexcept {
72-
return make_service_helper<Base>(
73-
"BaseServer::IsMoving", this, request)([&](auto& helper, auto& base) {
71+
return make_service_helper<Base>("BaseServer::IsMoving", this, request)([&](auto&, auto& base) {
7472
const bool result = base->is_moving();
7573
response->set_is_moving(result);
7674
});
7775
}
7876

7977
::grpc::Status BaseServer::GetGeometries(
80-
::grpc::ServerContext* context,
78+
::grpc::ServerContext*,
8179
const ::viam::common::v1::GetGeometriesRequest* request,
8280
::viam::common::v1::GetGeometriesResponse* response) noexcept {
8381
return make_service_helper<Base>(
@@ -90,7 +88,7 @@ ::grpc::Status BaseServer::GetGeometries(
9088
}
9189

9290
::grpc::Status BaseServer::GetProperties(
93-
grpc::ServerContext* context,
91+
grpc::ServerContext*,
9492
const viam::component::base::v1::GetPropertiesRequest* request,
9593
viam::component::base::v1::GetPropertiesResponse* response) noexcept {
9694
return make_service_helper<Base>(
@@ -102,11 +100,11 @@ ::grpc::Status BaseServer::GetProperties(
102100
});
103101
}
104102

105-
::grpc::Status BaseServer::DoCommand(grpc::ServerContext* context,
103+
::grpc::Status BaseServer::DoCommand(grpc::ServerContext*,
106104
const viam::common::v1::DoCommandRequest* request,
107105
viam::common::v1::DoCommandResponse* response) noexcept {
108106
return make_service_helper<Base>(
109-
"BaseServer::DoCommand", this, request)([&](auto& helper, auto& base) {
107+
"BaseServer::DoCommand", this, request)([&](auto&, auto& base) {
110108
const AttributeMap result = base->do_command(struct_to_map(request->command()));
111109
*response->mutable_result() = map_to_struct(result);
112110
});

‎src/viam/sdk/components/board/server.cpp

Lines changed: 21 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ BoardServer::BoardServer(std::shared_ptr<ResourceManager> manager)
1414
: ResourceServer(std::move(manager)){};
1515

1616
::grpc::Status BoardServer::Status(
17-
::grpc::ServerContext* context,
17+
::grpc::ServerContext*,
1818
const ::viam::component::board::v1::StatusRequest* request,
1919
::viam::component::board::v1::StatusResponse* response) noexcept {
2020
return make_service_helper<Board>(
@@ -25,18 +25,17 @@ ::grpc::Status BoardServer::Status(
2525
});
2626
}
2727

28-
::grpc::Status BoardServer::SetGPIO(
29-
::grpc::ServerContext* context,
30-
const ::viam::component::board::v1::SetGPIORequest* request,
31-
::viam::component::board::v1::SetGPIOResponse* response) noexcept {
28+
::grpc::Status BoardServer::SetGPIO(::grpc::ServerContext*,
29+
const ::viam::component::board::v1::SetGPIORequest* request,
30+
::viam::component::board::v1::SetGPIOResponse*) noexcept {
3231
return make_service_helper<Board>(
3332
"BoardServer::SetGPIO", this, request)([&](auto& helper, auto& board) {
3433
board->set_gpio(request->pin(), request->high(), helper.getExtra());
3534
});
3635
}
3736

3837
::grpc::Status BoardServer::GetGPIO(
39-
::grpc::ServerContext* context,
38+
::grpc::ServerContext*,
4039
const ::viam::component::board::v1::GetGPIORequest* request,
4140
::viam::component::board::v1::GetGPIOResponse* response) noexcept {
4241
return make_service_helper<Board>(
@@ -45,7 +44,7 @@ ::grpc::Status BoardServer::GetGPIO(
4544
});
4645
}
4746

48-
::grpc::Status BoardServer::PWM(::grpc::ServerContext* context,
47+
::grpc::Status BoardServer::PWM(::grpc::ServerContext*,
4948
const ::viam::component::board::v1::PWMRequest* request,
5049
::viam::component::board::v1::PWMResponse* response) noexcept {
5150
return make_service_helper<Board>(
@@ -54,18 +53,17 @@ ::grpc::Status BoardServer::PWM(::grpc::ServerContext* context,
5453
});
5554
}
5655

57-
::grpc::Status BoardServer::SetPWM(
58-
::grpc::ServerContext* context,
59-
const ::viam::component::board::v1::SetPWMRequest* request,
60-
::viam::component::board::v1::SetPWMResponse* response) noexcept {
56+
::grpc::Status BoardServer::SetPWM(::grpc::ServerContext*,
57+
const ::viam::component::board::v1::SetPWMRequest* request,
58+
::viam::component::board::v1::SetPWMResponse*) noexcept {
6159
return make_service_helper<Board>(
6260
"BoardServer::SetPWM", this, request)([&](auto& helper, auto& board) {
6361
board->set_pwm_duty_cycle(request->pin(), request->duty_cycle_pct(), helper.getExtra());
6462
});
6563
}
6664

6765
::grpc::Status BoardServer::PWMFrequency(
68-
::grpc::ServerContext* context,
66+
::grpc::ServerContext*,
6967
const ::viam::component::board::v1::PWMFrequencyRequest* request,
7068
::viam::component::board::v1::PWMFrequencyResponse* response) noexcept {
7169
return make_service_helper<Board>(
@@ -76,27 +74,27 @@ ::grpc::Status BoardServer::PWMFrequency(
7674
}
7775

7876
::grpc::Status BoardServer::SetPWMFrequency(
79-
::grpc::ServerContext* context,
77+
::grpc::ServerContext*,
8078
const ::viam::component::board::v1::SetPWMFrequencyRequest* request,
81-
::viam::component::board::v1::SetPWMFrequencyResponse* response) noexcept {
79+
::viam::component::board::v1::SetPWMFrequencyResponse*) noexcept {
8280
return make_service_helper<Board>(
8381
"BoardServer::SetPWMFrequency", this, request)([&](auto& helper, auto& board) {
8482
board->set_pwm_frequency(request->pin(), request->frequency_hz(), helper.getExtra());
8583
});
8684
}
8785

88-
::grpc::Status BoardServer::DoCommand(grpc::ServerContext* context,
86+
::grpc::Status BoardServer::DoCommand(grpc::ServerContext*,
8987
const viam::common::v1::DoCommandRequest* request,
9088
viam::common::v1::DoCommandResponse* response) noexcept {
9189
return make_service_helper<Board>(
92-
"BoardServer::DoCommand", this, request)([&](auto& helper, auto& board) {
90+
"BoardServer::DoCommand", this, request)([&](auto&, auto& board) {
9391
const AttributeMap result = board->do_command(struct_to_map(request->command()));
9492
*response->mutable_result() = map_to_struct(result);
9593
});
9694
}
9795

9896
::grpc::Status BoardServer::ReadAnalogReader(
99-
::grpc::ServerContext* context,
97+
::grpc::ServerContext*,
10098
const ::viam::component::board::v1::ReadAnalogReaderRequest* request,
10199
::viam::component::board::v1::ReadAnalogReaderResponse* response) {
102100
if (!request) {
@@ -123,9 +121,9 @@ ::grpc::Status BoardServer::ReadAnalogReader(
123121
}
124122

125123
::grpc::Status BoardServer::WriteAnalog(
126-
::grpc::ServerContext* context,
124+
::grpc::ServerContext*,
127125
const ::viam::component::board::v1::WriteAnalogRequest* request,
128-
::viam::component::board::v1::WriteAnalogResponse* response) {
126+
::viam::component::board::v1::WriteAnalogResponse*) {
129127
if (!request) {
130128
return ::grpc::Status(::grpc::StatusCode::INVALID_ARGUMENT,
131129
"Called [Board::WriteAnalog] without a request");
@@ -148,7 +146,7 @@ ::grpc::Status BoardServer::WriteAnalog(
148146
}
149147

150148
::grpc::Status BoardServer::GetDigitalInterruptValue(
151-
::grpc::ServerContext* context,
149+
::grpc::ServerContext*,
152150
const ::viam::component::board::v1::GetDigitalInterruptValueRequest* request,
153151
::viam::component::board::v1::GetDigitalInterruptValueResponse* response) {
154152
if (!request) {
@@ -176,9 +174,9 @@ ::grpc::Status BoardServer::GetDigitalInterruptValue(
176174
}
177175

178176
::grpc::Status BoardServer::SetPowerMode(
179-
::grpc::ServerContext* context,
177+
::grpc::ServerContext*,
180178
const ::viam::component::board::v1::SetPowerModeRequest* request,
181-
::viam::component::board::v1::SetPowerModeResponse* response) noexcept {
179+
::viam::component::board::v1::SetPowerModeResponse*) noexcept {
182180
return make_service_helper<Board>(
183181
"BoardServer::SetPowerMode", this, request)([&](auto& helper, auto& board) {
184182
if (request->has_duration()) {
@@ -192,7 +190,7 @@ ::grpc::Status BoardServer::SetPowerMode(
192190
}
193191

194192
::grpc::Status BoardServer::GetGeometries(
195-
::grpc::ServerContext* context,
193+
::grpc::ServerContext*,
196194
const ::viam::common::v1::GetGeometriesRequest* request,
197195
::viam::common::v1::GetGeometriesResponse* response) noexcept {
198196
return make_service_helper<Board>(

‎src/viam/sdk/components/camera/camera.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ class Camera : public Component {
122122
/// @brief Send/receive arbitrary commands to the resource.
123123
/// @param Command the command to execute.
124124
/// @return The result of the executed command.
125-
virtual AttributeMap do_command(AttributeMap command) = 0;
125+
virtual AttributeMap do_command(const AttributeMap& command) = 0;
126126

127127
/// @brief Get the next image from the camera as a raw image.
128128
/// @param mime_type the desired mime_type of the image (does not guarantee output type).

‎src/viam/sdk/components/camera/client.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ CameraClient::CameraClient(std::string name, std::shared_ptr<grpc::Channel> chan
2222
stub_(viam::component::camera::v1::CameraService::NewStub(channel)),
2323
channel_(std::move(channel)){};
2424

25-
AttributeMap CameraClient::do_command(AttributeMap command) {
25+
AttributeMap CameraClient::do_command(const AttributeMap& command) {
2626
return make_client_helper(this, *stub_, &StubType::DoCommand)
2727
.with([&](auto& request) { *request.mutable_command() = map_to_struct(command); })
2828
.invoke([](auto& response) { return struct_to_map(response.result()); });

‎src/viam/sdk/components/camera/client.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class CameraClient : public Camera {
2323
public:
2424
using interface_type = Camera;
2525
CameraClient(std::string name, std::shared_ptr<grpc::Channel> channel);
26-
AttributeMap do_command(AttributeMap command) override;
26+
AttributeMap do_command(const AttributeMap& command) override;
2727
raw_image get_image(std::string mime_type, const AttributeMap& extra) override;
2828
image_collection get_images() override;
2929
point_cloud get_point_cloud(std::string mime_type, const AttributeMap& extra) override;

‎src/viam/sdk/components/camera/server.cpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,18 +16,18 @@ namespace sdk {
1616
CameraServer::CameraServer(std::shared_ptr<ResourceManager> manager)
1717
: ResourceServer(std::move(manager)){};
1818

19-
::grpc::Status CameraServer::DoCommand(::grpc::ServerContext* context,
19+
::grpc::Status CameraServer::DoCommand(::grpc::ServerContext*,
2020
const ::viam::common::v1::DoCommandRequest* request,
2121
::viam::common::v1::DoCommandResponse* response) noexcept {
2222
return make_service_helper<Camera>(
23-
"CameraServer::DoCommand", this, request)([&](auto& helper, auto& camera) {
23+
"CameraServer::DoCommand", this, request)([&](auto&, auto& camera) {
2424
const AttributeMap result = camera->do_command(struct_to_map(request->command()));
2525
*response->mutable_result() = map_to_struct(result);
2626
});
2727
}
2828

2929
::grpc::Status CameraServer::GetImage(
30-
::grpc::ServerContext* context,
30+
::grpc::ServerContext*,
3131
const ::viam::component::camera::v1::GetImageRequest* request,
3232
::viam::component::camera::v1::GetImageResponse* response) noexcept {
3333
return make_service_helper<Camera>(
@@ -42,11 +42,11 @@ ::grpc::Status CameraServer::GetImage(
4242
}
4343

4444
::grpc::Status CameraServer::GetImages(
45-
::grpc::ServerContext* context,
45+
::grpc::ServerContext*,
4646
const ::viam::component::camera::v1::GetImagesRequest* request,
4747
::viam::component::camera::v1::GetImagesResponse* response) noexcept {
4848
return make_service_helper<Camera>(
49-
"CameraServer::GetImages", this, request)([&](auto& helper, auto& camera) {
49+
"CameraServer::GetImages", this, request)([&](auto&, auto& camera) {
5050
const Camera::image_collection image_coll = camera->get_images();
5151
for (const auto& img : image_coll.images) {
5252
::viam::component::camera::v1::Image proto_image;
@@ -62,7 +62,7 @@ ::grpc::Status CameraServer::GetImages(
6262
}
6363

6464
::grpc::Status CameraServer::RenderFrame(
65-
::grpc::ServerContext* context,
65+
::grpc::ServerContext*,
6666
const ::viam::component::camera::v1::RenderFrameRequest* request,
6767
::google::api::HttpBody* response) noexcept {
6868
return make_service_helper<Camera>(
@@ -75,7 +75,7 @@ ::grpc::Status CameraServer::RenderFrame(
7575
}
7676

7777
::grpc::Status CameraServer::GetPointCloud(
78-
::grpc::ServerContext* context,
78+
::grpc::ServerContext*,
7979
const ::viam::component::camera::v1::GetPointCloudRequest* request,
8080
::viam::component::camera::v1::GetPointCloudResponse* response) noexcept {
8181
return make_service_helper<Camera>(
@@ -88,7 +88,7 @@ ::grpc::Status CameraServer::GetPointCloud(
8888
}
8989

9090
::grpc::Status CameraServer::GetGeometries(
91-
::grpc::ServerContext* context,
91+
::grpc::ServerContext*,
9292
const ::viam::common::v1::GetGeometriesRequest* request,
9393
::viam::common::v1::GetGeometriesResponse* response) noexcept {
9494
return make_service_helper<Camera>(
@@ -101,11 +101,11 @@ ::grpc::Status CameraServer::GetGeometries(
101101
}
102102

103103
::grpc::Status CameraServer::GetProperties(
104-
::grpc::ServerContext* context,
104+
::grpc::ServerContext*,
105105
const ::viam::component::camera::v1::GetPropertiesRequest* request,
106106
::viam::component::camera::v1::GetPropertiesResponse* response) noexcept {
107107
return make_service_helper<Camera>(
108-
"CameraServer::GetProperties", this, request)([&](auto& helper, auto& camera) {
108+
"CameraServer::GetProperties", this, request)([&](auto&, auto& camera) {
109109
const Camera::properties properties = camera->get_properties();
110110

111111
*response->mutable_distortion_parameters() =

‎src/viam/sdk/components/encoder/client.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ std::vector<GeometryConfig> EncoderClient::get_geometries(const AttributeMap& ex
4646
.invoke([](auto& response) { return GeometryConfig::from_proto(response); });
4747
};
4848

49-
AttributeMap EncoderClient::do_command(AttributeMap command) {
49+
AttributeMap EncoderClient::do_command(const AttributeMap& command) {
5050
return make_client_helper(this, *stub_, &StubType::DoCommand)
5151
.with([&](auto& request) { *request.mutable_command() = map_to_struct(command); })
5252
.invoke([](auto& response) { return struct_to_map(response.result()); });

‎src/viam/sdk/components/encoder/client.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class EncoderClient : public Encoder {
2626
void reset_position(const AttributeMap& extra) override;
2727
properties get_properties(const AttributeMap& extra) override;
2828
std::vector<GeometryConfig> get_geometries(const AttributeMap& extra) override;
29-
AttributeMap do_command(AttributeMap command) override;
29+
AttributeMap do_command(const AttributeMap& command) override;
3030

3131
// the `extra` param is frequently unnecessary but needs to be supported. Ideally, we'd
3232
// like to live in a world where implementers of derived classes don't need to go out of

‎src/viam/sdk/components/encoder/encoder.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ class Encoder : public Component {
104104
/// @brief Send/receive arbitrary commands to the resource.
105105
/// @param Command the command to execute.
106106
/// @return The result of the executed command.
107-
virtual AttributeMap do_command(AttributeMap command) = 0;
107+
virtual AttributeMap do_command(const AttributeMap& command) = 0;
108108

109109
/// @brief Returns `GeometryConfig`s associated with the calling encoder.
110110
/// @return The requested `GeometryConfig`s associated with the component.

0 commit comments

Comments
 (0)