Skip to content

Commit 67aba3e

Browse files
authoredJan 30, 2025··
fix discoverResources (#335)
1 parent f2fa7f0 commit 67aba3e

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed
 

‎lib/src/services/discovery.dart

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import 'package:grpc/grpc_connection_interface.dart';
22

33
import '../../protos/common/common.dart';
4-
import '../gen/common/v1/common.pb.dart';
54
import '../../protos/service/discovery.dart';
6-
import '../gen/service/discovery/v1/discovery.pbgrpc.dart';
75
import '../gen/app/v1/robot.pb.dart';
6+
import '../gen/common/v1/common.pb.dart';
7+
import '../gen/service/discovery/v1/discovery.pbgrpc.dart';
88
import '../resource/base.dart';
99
import '../robot/client.dart';
1010
import '../utils.dart';
@@ -30,7 +30,7 @@ class DiscoveryClient extends Resource implements ResourceRPCClient {
3030
/// // Example:
3131
/// var resources = await myDiscoveryService.discoverResources('myWebcam');
3232
/// ```
33-
Future<List<ComponentConfig>> discoverResources(String discoveryName, {Map<String, dynamic>? extra}) async {
33+
Future<List<ComponentConfig>> discoverResources({Map<String, dynamic>? extra}) async {
3434
final request = DiscoverResourcesRequest(name: name, extra: extra?.toStruct());
3535
final response = await client.discoverResources(request);
3636
return response.discoveries;

‎test/unit_test/services/discovery_test.dart

+2-4
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
1-
import 'package:fixnum/fixnum.dart';
21
import 'package:flutter_test/flutter_test.dart';
32
import 'package:mockito/mockito.dart';
43
import 'package:viam_sdk/protos/service/discovery.dart';
5-
import 'package:viam_sdk/src/gen/common/v1/common.pb.dart';
4+
import 'package:viam_sdk/src/gen/app/v1/robot.pb.dart';
65
import 'package:viam_sdk/src/gen/service/discovery/v1/discovery.pbgrpc.dart';
76
import 'package:viam_sdk/viam_sdk.dart';
8-
import 'package:viam_sdk/src/gen/app/v1/robot.pb.dart';
97

108
import '../mocks/mock_response_future.dart';
119
import '../mocks/service_clients_mocks.mocks.dart';
@@ -33,7 +31,7 @@ void main() {
3331
final expected = [ComponentConfig()];
3432
when(serviceClient.discoverResources(any))
3533
.thenAnswer((_) => MockResponseFuture.value(DiscoverResourcesResponse(discoveries: expected)));
36-
final response = await client.discoverResources('discoveryName');
34+
final response = await client.discoverResources();
3735
expect(response, equals(expected));
3836
});
3937
});

0 commit comments

Comments
 (0)
Please sign in to comment.