Skip to content

Commit 48f8f52

Browse files
committed
Fixes for syncing CA cert to dovecot and webmin
1 parent 23f0cc3 commit 48f8f52

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

Diff for: copycert-lib.pl

+2-1
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,8 @@ sub get_all_domain_service_ssl_certs
296296
if ((&same_cert_file($d->{'ssl_cert'}, $svc->{'cert'}) ||
297297
&same_cert_file($d->{'ssl_combined'}, $svc->{'cert'})) &&
298298
(!$svc->{'ca'} || -s $svc->{'ca'} < 16 || $svc->{'ca'} eq 'none' ||
299-
&same_cert_file_any($chain, $svc->{'ca'}))) {
299+
&same_cert_file_any($chain, $svc->{'ca'}) ||
300+
&same_cert_file_any($d->{'ssl_combined'}, $svc->{'ca'}))) {
300301
push(@rv, $svc);
301302
}
302303
}

Diff for: feature-ssl.pl

+5-1
Original file line numberDiff line numberDiff line change
@@ -462,11 +462,14 @@ sub modify_ssl
462462
$d->{'virt'} != $oldd->{'virt'} ||
463463
$d->{'dom'} ne $oldd->{'dom'} ||
464464
$d->{'home'} ne $oldd->{'home'}) {
465+
print STDERR "Updating service SSL certs\n";
465466
my %types = map { $_->{'id'}, $_ } &list_service_ssl_cert_types();
466467
foreach my $svc (&get_all_domain_service_ssl_certs($oldd)) {
468+
print STDERR "syncing svc=$svc->{'id'} d=$svc->{'d'}\n";
467469
next if (!$svc->{'d'});
468470
my $t = $types{$svc->{'id'}};
469471
my $func = "sync_".$svc->{'id'}."_ssl_cert";
472+
print STDERR "calling $func\n";
470473
next if (!defined(&$func));
471474
&$func($oldd, 0);
472475
if ($t->{'dom'} || $d->{'virt'}) {
@@ -1553,10 +1556,11 @@ sub setup_ipkeys
15531556
push(@ips, $d->{'ip'});
15541557
}
15551558
push(@ips, @dnames);
1559+
my $chain = &get_website_ssl_file($d, 'ca');
15561560
push(@ipkeys, { 'ips' => \@ips,
15571561
'key' => $d->{'ssl_key'},
15581562
'cert' => $d->{'ssl_cert'},
1559-
'extracas' => $d->{'ssl_chain'}, });
1563+
'extracas' => $chain, });
15601564
&webmin::save_ipkeys(\%miniserv, \@ipkeys);
15611565
&$putfunc(\%miniserv);
15621566
&register_post_action($postfunc);

0 commit comments

Comments
 (0)