From fd2d4ea3095e217763180bce9a1ff933af50fe7a Mon Sep 17 00:00:00 2001 From: Tim Nyborg Date: Thu, 27 Feb 2025 15:46:50 +0000 Subject: [PATCH 1/2] chore: correct EditableGeoJsonLayerProps typing to match use --- .../src/editable-layers/editable-geojson-layer.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/editable-layers/src/editable-layers/editable-geojson-layer.ts b/modules/editable-layers/src/editable-layers/editable-geojson-layer.ts index fa6784b3..1d010873 100644 --- a/modules/editable-layers/src/editable-layers/editable-geojson-layer.ts +++ b/modules/editable-layers/src/editable-layers/editable-geojson-layer.ts @@ -118,7 +118,7 @@ export type EditableGeoJsonLayerProps = EditableLayerProps & { mode?: any; modeConfig?: any; selectedFeatureIndexes?: number[]; - onEdit?: (updatedData?, editType?: string, featureIndexes?: number[], editContext?) => void; + onEdit?: (editAction: EditAction) => void; pickable?: boolean; pickingRadius?: number; @@ -140,8 +140,8 @@ export type EditableGeoJsonLayerProps = EditableLayerProps & { getLineColor?: Color | ((feature, isSelected, mode) => Color); getFillColor?: Color | ((feature, isSelected, mode) => Color); - getRadius?: number | ((f) => number); - getLineWidth?: number | ((f) => number); + getRadius?: number | ((feature, isSelected, mode) => number); + getLineWidth?: number | ((feature, isSelected, mode) => number); getTentativeLineColor?: Color | ((feature, isSelected, mode) => Color); getTentativeFillColor?: Color | ((feature, isSelected, mode) => Color); From 7904cf8bd0a4a11572a63a704891fb7e13574ca7 Mon Sep 17 00:00:00 2001 From: Tim Nyborg Date: Thu, 27 Feb 2025 15:49:03 +0000 Subject: [PATCH 2/2] chore: export SelectionLayerProps --- modules/editable-layers/src/editable-layers/selection-layer.ts | 2 +- modules/editable-layers/src/index.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/editable-layers/src/editable-layers/selection-layer.ts b/modules/editable-layers/src/editable-layers/selection-layer.ts index d0db6b20..ab8e9d5b 100644 --- a/modules/editable-layers/src/editable-layers/selection-layer.ts +++ b/modules/editable-layers/src/editable-layers/selection-layer.ts @@ -31,7 +31,7 @@ const MODE_CONFIG_MAP = { [SELECTION_TYPE.RECTANGLE]: {dragToDraw: true} }; -interface SelectionLayerProps extends CompositeLayerProps { +export interface SelectionLayerProps extends CompositeLayerProps { layerIds: any[]; onSelect: (info: any) => any; selectionType: string | null; diff --git a/modules/editable-layers/src/index.ts b/modules/editable-layers/src/index.ts index 7a5df49c..b9a39bb3 100644 --- a/modules/editable-layers/src/index.ts +++ b/modules/editable-layers/src/index.ts @@ -45,6 +45,7 @@ export type {GeoJsonEditModeType} from './edit-modes/geojson-edit-mode'; export type {GeoJsonEditModeConstructor} from './edit-modes/geojson-edit-mode'; export type {EditableGeoJsonLayerProps} from './editable-layers/editable-geojson-layer'; +export type {SelectionLayerProps} from './editable-layers/selection-layer'; export {GeoJsonEditMode} from './edit-modes/geojson-edit-mode';