You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hubble.gl tests are moving to browser-only tests and are failing since the ci test is running node tests. However, our ocular config (test.coverage) has testing configured for browser.
Shouldn't this instead run node tests if coverage.test is node? Elsewhere in the dev tools (such as test.js), the default case is to run browser tests and the exception is to check if the value is node. Did we mean to do the same thing in test.sh?
The text was updated successfully, but these errors were encountered:
Hubble.gl tests are moving to browser-only tests and are failing since the ci test is running node tests. However, our ocular config (
test.coverage
) has testing configured forbrowser
.There may be a typo in
test.sh
:dev-tools/modules/dev-tools/scripts/test.sh
Line 68 in ef50bfb
Shouldn't this instead run node tests if coverage.test is
node
? Elsewhere in the dev tools (such as test.js), the default case is to run browser tests and the exception is to check if the value isnode
. Did we mean to do the same thing intest.sh
?The text was updated successfully, but these errors were encountered: