Skip to content

yarn test ci runs node tests when configured for browser tests #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisgervang opened this issue Mar 20, 2025 · 0 comments · May be fixed by #11
Open

yarn test ci runs node tests when configured for browser tests #10

chrisgervang opened this issue Mar 20, 2025 · 0 comments · May be fixed by #11
Assignees

Comments

@chrisgervang
Copy link
Contributor

Hubble.gl tests are moving to browser-only tests and are failing since the ci test is running node tests. However, our ocular config (test.coverage) has testing configured for browser.

There may be a typo in test.sh:

if [ "$COVERAGE_TEST" == "browser" ]; then

Shouldn't this instead run node tests if coverage.test is node? Elsewhere in the dev tools (such as test.js), the default case is to run browser tests and the exception is to check if the value is node. Did we mean to do the same thing in test.sh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants