Skip to content

Move style guide out of handbook #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bobertlo opened this issue Aug 2, 2020 · 5 comments
Closed

Move style guide out of handbook #444

bobertlo opened this issue Aug 2, 2020 · 5 comments

Comments

@bobertlo
Copy link
Contributor

bobertlo commented Aug 2, 2020

There was a PR for this I think but it had unrelated changes that were disagreed on and it has drifted heavily. I think it would be more appropriate to have this guide in the root of the repository as a markdown file and link to that from the contributing section.

This could maybe just be called contributing.md and include git best practice also? Or that could go in the README?

I'm open to discussion but I don't feel like this is part of using void Linux exactly and could be moved out. Especially in light of the pdf and upcoming tagged releases.

@bobertlo
Copy link
Contributor Author

bobertlo commented Aug 2, 2020

Related to #407

@flexibeast
Copy link
Contributor

Yeah, i like the idea of moving "Style Guide" and "Submitting Changes" to CONTRIBUTING.md - the current CONTRIBUTING.md simply refers people to those sections, so moving those sections there would also remove a layer of indirection. :-)

@flexibeast
Copy link
Contributor

@ericonr: Any objections? If not, i'll create a PR for this.

@ericonr
Copy link
Member

ericonr commented Aug 4, 2020

I think it makes sense. Go for it!

@flexibeast
Copy link
Contributor

Closed by #446.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants