refactor: minor code adjustments

Author: johnsoncodehk

packages/reactivity/src/effect.ts

@@ -96,12 +96,12 @@ export class ReactiveEffect<T = any> implements ReactiveEffectOptions {
   }
 
   resume(): void {
-    const flags = this.flags
+    let flags = this.flags
     if (flags & EffectFlags.PAUSED) {
-      this.flags &= ~EffectFlags.PAUSED
+      this.flags = flags &= ~EffectFlags.PAUSED
     }
     if (flags & EffectFlags.NOTIFIED) {
-      this.flags &= ~EffectFlags.NOTIFIED
+      this.flags = flags &= ~EffectFlags.NOTIFIED
       this.notify()
     }
   }
@@ -297,9 +297,9 @@ export function onEffectCleanup(fn: () => void, failSilently = false): void {
 }
 
 function cleanupEffect(e: ReactiveEffect) {
-  const { cleanup } = e
-  e.cleanup = undefined
+  const cleanup = e.cleanup
   if (cleanup !== undefined) {
+    e.cleanup = undefined
     // run cleanup without active effect
     const prevSub = activeSub
     activeSub = undefined

packages/reactivity/src/ref.ts

@@ -144,19 +144,22 @@ class RefImpl<T = any> implements Dependency {
     if (hasChanged(newValue, oldValue)) {
       this._rawValue = newValue
       this._value =
-        this._wrap && !useDirectValue ? this._wrap(newValue) : newValue
-      if (__DEV__) {
-        triggerEventInfos.push({
-          target: this,
-          type: TriggerOpTypes.SET,
-          key: 'value',
-          newValue,
-          oldValue,
-        })
-      }
-      triggerRef(this as unknown as Ref)
-      if (__DEV__) {
-        triggerEventInfos.pop()
+        !useDirectValue && this._wrap ? this._wrap(newValue) : newValue
+      const subs = this.subs
+      if (subs !== undefined) {
+        if (__DEV__) {
+          triggerEventInfos.push({
+            target: this,
+            type: TriggerOpTypes.SET,
+            key: 'value',
+            newValue,
+            oldValue,
+          })
+        }
+        propagate(subs)
+        if (__DEV__) {
+          triggerEventInfos.pop()
+        }
       }
     }
   }

packages/runtime-core/src/renderer.ts

@@ -1599,8 +1599,7 @@ function baseCreateRenderer(
     instance.scope.off()
 
     const update = (instance.update = effect.run.bind(effect))
-    const job: SchedulerJob = (instance.job = () =>
-      effect.dirty && effect.run())
+    const job: SchedulerJob = (instance.job = effect.scheduler.bind(effect))
     job.i = instance
     job.id = instance.uid
     effect.scheduler = () => queueJob(job)

packages/runtime-core/src/scheduler.ts

@@ -97,7 +97,8 @@ function findInsertionIndex(id: number, isPre: boolean) {
  * @internal for runtime-vapor only
  */
 export function queueJob(job: SchedulerJob, isPre = false): void {
-  if (!(job.flags! & SchedulerJobFlags.QUEUED)) {
+  const flags = job.flags!
+  if (!(flags & SchedulerJobFlags.QUEUED)) {
     if (job.id === undefined) {
       job.id = isPre ? -1 : Infinity
     }
@@ -113,9 +114,7 @@ export function queueJob(job: SchedulerJob, isPre = false): void {
       queue.splice(findInsertionIndex(job.id, isPre), 0, job)
     }
     isPre ? preJobsLength++ : mainJobsLength++
-
-    job.flags! |= SchedulerJobFlags.QUEUED
-
+    job.flags! = flags | SchedulerJobFlags.QUEUED
     queueFlush()
   }
 }

packages/runtime-vapor/src/renderEffect.ts

@@ -1,8 +1,4 @@
-import {
-  type EffectScope,
-  ReactiveEffect,
-  getCurrentScope,
-} from '@vue/reactivity'
+import { EffectFlags, type EffectScope, ReactiveEffect } from '@vue/reactivity'
 import {
   type SchedulerJob,
   currentInstance,
@@ -17,24 +13,18 @@ import { invokeArrayFns } from '@vue/shared'
 
 class RenderEffect extends ReactiveEffect {
   i: VaporComponentInstance | null
-  scope: EffectScope | undefined
-  baseJob: SchedulerJob
-  postJob: SchedulerJob
+  job: SchedulerJob
+  updateJob: SchedulerJob
 
   constructor(public render: () => void) {
     super()
     const instance = currentInstance as VaporComponentInstance | null
-    const scope = getCurrentScope()
-    if (__DEV__ && !__TEST__ && !scope && !isVaporComponent(instance)) {
+    if (__DEV__ && !__TEST__ && !this.subs && !isVaporComponent(instance)) {
       warn('renderEffect called without active EffectScope or Vapor instance.')
     }
 
-    this.baseJob = () => {
-      if (this.dirty) {
-        this.run()
-      }
-    }
-    this.postJob = () => {
+    const job: SchedulerJob = super.scheduler.bind(this)
+    this.updateJob = () => {
       instance!.isUpdating = false
       instance!.u && invokeArrayFns(instance!.u)
     }
@@ -48,19 +38,19 @@ class RenderEffect extends ReactiveEffect {
           ? e => invokeArrayFns(instance.rtg!, e)
           : void 0
       }
-      this.baseJob.i = instance
-      this.baseJob.id = instance.uid
+      job.i = instance
+      job.id = instance.uid
     }
 
+    this.job = job
     this.i = instance
-    this.scope = scope
 
     // TODO recurse handling
   }
 
   callback(): void {
     const instance = this.i!
-    const scope = this.scope
+    const scope = this.subs ? (this.subs.sub as EffectScope) : undefined
     // renderEffect is always called after user has registered all hooks
     const hasUpdateHooks = instance && (instance.bu || instance.u)
     if (__DEV__ && instance) {
@@ -73,7 +63,7 @@ class RenderEffect extends ReactiveEffect {
       instance.isUpdating = true
       instance.bu && invokeArrayFns(instance.bu)
       this.render()
-      queuePostFlushCb(this.postJob)
+      queuePostFlushCb(this.updateJob)
     } else {
       this.render()
     }
@@ -84,8 +74,13 @@ class RenderEffect extends ReactiveEffect {
     }
   }
 
-  scheduler(): void {
-    queueJob(this.baseJob)
+  notify(): void {
+    const flags = this.flags
+    if (!(flags & EffectFlags.PAUSED)) {
+      queueJob(this.job)
+    } else {
+      this.flags = flags | EffectFlags.NOTIFIED
+    }
   }
 }