Skip to content

setResourceTimingBufferSize should not clear "resource timing buffer full flag" when the buffer has shrunk #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rniwa opened this issue Jan 31, 2018 · 3 comments
Milestone

Comments

@rniwa
Copy link

rniwa commented Jan 31, 2018

When setResourceTimingBufferSize is called to shrink the resource timing buffer size, it's inappropriate to clear "resource timing buffer full flag" since that would result in every new queuing of a resource timing performance entry to fire resourcetimingbufferfull event even though there was no space made available in the buffer in the last firing of the event.

@npm1
Copy link
Contributor

npm1 commented Jan 31, 2018

Should setResourceTimingBufferSize fire a resourcetimingbufferfull event if the maxSize parameter is less than or equal to resource timing buffer current size? I see that Chrome currently fires resourcetimingbufferfull in this case (regardless of the flag) but that is not stated anywhere in the spec.

@npm1
Copy link
Contributor

npm1 commented Jan 31, 2018

I checked that Firefox 58 does not fire the event in this case, and the spec does not prompt this, so I think I should just fix the Chrome behavior.

@nicjansma nicjansma added this to the Level 2 milestone Feb 9, 2018
@igrigorik
Copy link
Member

Resolved via #146.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants