Skip to content

[Service Workers] CR Request for Service Workers 1 #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ylafon opened this issue Oct 7, 2019 · 9 comments
Closed

[Service Workers] CR Request for Service Workers 1 #171

ylafon opened this issue Oct 7, 2019 · 9 comments
Assignees
Labels
Awaiting Publication Approved by the Director, waiting on publication Entering CR First Candidate Recommendation wg:service-workers

Comments

@ylafon
Copy link
Member

ylafon commented Oct 7, 2019

Document title, URLs, estimated publication date

Current WD: https://www.w3.org/TR/2019/WD-service-workers-1-20190813/
Current ED: https://w3c.github.io/ServiceWorker/v1/
Proposed CR: https://raw.githack.com/w3c/ServiceWorker/master/publish/service_worker_1/CR-service-workers-20191003/index.html

Abstract

https://raw.githack.com/w3c/ServiceWorker/master/publish/service_worker_1/CR-service-workers-20191003/index.html#abstract

Status

https://raw.githack.com/w3c/ServiceWorker/master/publish/service_worker_1/CR-service-workers-20191003/index.html#status

Link to group's decision to request transition

w3c/ServiceWorker#1458

Changes

No changes since last WD apart from clarifications - editorial notes in the document - about the status of some issues.

Requirements satisfied

There are no requirement document per se, but the initial goals outlined in the explainer are met, see https://github.com/w3c/ServiceWorker/blob/master/explainer.md

Dependencies met (or not)

No known dependencies that could impact or being impacted by this specification.

Wide Review

https://lists.w3.org/Archives/Public/www-tag/2015Sep/0071.html
This led mostly to further explanations (like during i18n review), no blocking issues were raised during that review.

Issues addressed

https://github.com/w3c/ServiceWorker/milestone/2?closed=1&open=1

Formal Objections

None.

Implementation

See test results on wpt.fyi
https://wpt.fyi/results/service-workers
Note that those tests are for the latest editors' draft, this CR contains only a subset of them, thus the results need to be filtered to accurately represent the state of implementations.

Patent disclosures

https://www.w3.org/2004/01/pp-impl/101220/status

@ylafon ylafon added Entering CR First Candidate Recommendation [DO NOT USE] Awaiting Director Deprecated. Use Awaiting Team Verification. labels Oct 7, 2019
@ylafon ylafon changed the title CR Request for Service Workers 1 [Service Workers] CR Request for Service Workers 1 Oct 7, 2019
@plehegar plehegar added [DO NOT USE] Awaiting Director Deprecated. Use Awaiting Team Verification. and removed [DO NOT USE] Awaiting Director Deprecated. Use Awaiting Team Verification. labels Oct 7, 2019
@swickr
Copy link
Contributor

swickr commented Oct 11, 2019

Is w3c/i18n-activity#28 resolved?
What are the CR Exit Criteria

@ylafon
Copy link
Member Author

ylafon commented Oct 12, 2019

The CR exit criteria are defined in the group's charter

In order to advance to Proposed Recommendation, each specification is expected to have at least two independent implementations of each feature defined in the specification.

I can amend the SoTD in order to reflect that if it is clearer.

@swickr
Copy link
Contributor

swickr commented Oct 15, 2019

The CR specification should state more precisely how the WG intends to demonstrate that those implementations exist. For example, by showing the results of test suite runs and producing an implementation report.

@r12a
Copy link

r12a commented Oct 23, 2019

Is w3c/i18n-activity#28 resolved?

The correct URL for that comment is now w3c/ServiceWorker#1483

@plehegar plehegar removed the [DO NOT USE] Awaiting Director Deprecated. Use Awaiting Team Verification. label Oct 31, 2019
@ylafon
Copy link
Member Author

ylafon commented Nov 15, 2019

After discussing with Philippe, we would like to proceed even if w3c/ServiceWorker#1483 is not yet fully resolved. The impact of a potential issue would be limited by the fact that the worst case would mean that, for example, no match happened and data will be fetched from the network instead of from the service worker. This will be clarified during CR but it is a minor modification (based also on Jake Archibald's comment, and the already existing references to URL equivalence https://url.spec.whatwg.org/#concept-url-equals for cache operations).

@ylafon ylafon added the [DO NOT USE] Awaiting Director Deprecated. Use Awaiting Team Verification. label Nov 15, 2019
@swickr
Copy link
Contributor

swickr commented Nov 15, 2019

I note @aphillips ' comment in 1843 as well.

@swickr
Copy link
Contributor

swickr commented Nov 15, 2019

It appears that the environment citation from FileAPI could be to the HTML spec. You might look at that during CR.

@swickr
Copy link
Contributor

swickr commented Nov 15, 2019

Transition approved.

@swickr swickr removed the [DO NOT USE] Awaiting Director Deprecated. Use Awaiting Team Verification. label Nov 15, 2019
@plehegar plehegar assigned ylafon and unassigned swickr Nov 15, 2019
@plehegar plehegar added the Awaiting Publication Approved by the Director, waiting on publication label Nov 15, 2019
@plehegar
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Publication Approved by the Director, waiting on publication Entering CR First Candidate Recommendation wg:service-workers
Projects
None yet
Development

No branches or pull requests

5 participants