-
Notifications
You must be signed in to change notification settings - Fork 47
Is there a way to use bashful in a Docker container? #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I like where your head's at... I haven't tried this, and I can see where there would be problems. I tried running the 00-demo.yml from within your jboss container like so:
where
there were issues, but it did run:
Though this wasn't a I think I know in what ways bashful needs to change to support this use-case... but can you give me an example to reproduce the issue you are seeing? A Dockerfile and the command you invoked to get this issue would be ideal. |
Wow thanks for the prompt response!!! 🙌 @wagoodman To be more specific I am working on the Basically, we want to start-up Keycloak, then run a couple config scripts against it using bashful. Here is the base docker image jboss/keycloak:4.1.0.Final https://hub.docker.com/r/jboss/keycloak/~/dockerfile/
Here is our docker file, edited for simplicity:
Perhaps it's not the right approach to use bashful as the entrypoint? So the jist of what we were trying to do was: Use bashful to startup keycloak using the existing entrypoint: Then run a series of bash scripts such as Then we were hoping to run the container using a fairly generic run command similar to this for local dev.
**UPDATED: ** fixed errors and added more info |
Very cool tool btw, I'm going to try to drive adoption at my org :) 🙌 |
Is there a way to pass in a static value for I'm willing to do a PR if you can point me in the right direction. |
Thanks for the info! I hadn't realized that it was being used as the entrypoint for a container, which is a different use-case altogether than from what I was imagining (so... here be dragons). For instance, pid 1 within the container (bashful in this case) should handle any signals gracefully and shutdown child processes in a controlled fashion, flush and close fds before forking, and other daemon-like functionalities. However, since all subprocesses are simply bash processes, this simplifies a lot of those requirements nicely (still a few missing though). Though bashful wasn't meant to do exactly this, I think it can be modified to fit your needs. It seems like the behavior needs to degrade gracefully when tty functions are not available. Currently @anataliocs if you wanted to take a shot at it, I'd start with providing defaults for screen width when this line fails Line 14 in f69ad05
|
@wagoodman great work with bashful ! 😁 By the way, is there any idea about creating a Docker image which contains bashful ? 😄 Like if people want to run it in a CI, example Gitlab CI (in my use case), it supports running jobs in a container given a docker image. I was looking for the bashful docker image but couldn't but found this thread which relates to it to some extent. We could have the discussion here or I could create a new issue to discuss about creating a Docker image for bashful. |
@karuppiah7890 I think that's a great idea. I added a few issues to the github project to capture this (#58 & #59)... feel free to add information as you see fit. |
Docker image: jboss/base-jdk:8
OS: RHEL
The text was updated successfully, but these errors were encountered: