Skip to content

Commit cdbe38a

Browse files
authored
Merge pull request #4101 from fbbdev/v3-alpha-bugfix/publish-ci-versioning
[v3] Fix npm ci
2 parents c96b7c6 + 30f0ec4 commit cdbe38a

File tree

4 files changed

+6
-64
lines changed

4 files changed

+6
-64
lines changed

.github/workflows/publish-npm.yml

+5-6
Original file line numberDiff line numberDiff line change
@@ -41,18 +41,17 @@ jobs:
4141
v3/internal/runtime/desktop/@wailsio/runtime/types/*.d.ts
4242
v3/internal/runtime/desktop/@wailsio/runtime/docs/**/*.*
4343
44-
- name: test action
44+
- name: Bump version
4545
if: steps.verify-changed-files.outputs.files_changed == 'true'
46-
id: get-version
47-
uses: beaconbrigade/[email protected]
48-
with:
49-
path: v3/internal/runtime/desktop/@wailsio/runtime
46+
id: bump-version
47+
working-directory: v3/internal/runtime/desktop/@wailsio/runtime
48+
run: echo "version=$(npm --no-git-tag-version --force version prerelease)" >> "$GITHUB_OUTPUT"
5049

5150
- name: Commit changes
5251
if: steps.verify-changed-files.outputs.files_changed == 'true'
5352
run: |
5453
git add .
55-
git commit -m "[skip ci] Publish @wailsio/runtime ${{ steps.get-version.outputs.version }}"
54+
git commit -m "[skip ci] Publish @wailsio/runtime ${{ steps.bump-version.outputs.version }}"
5655
git push
5756
5857
- uses: JS-DevTools/npm-publish@v3

v3/tasks/events/generate.go

-35
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ package main
22

33
import (
44
"bytes"
5-
"github.com/Masterminds/semver/v3"
6-
"github.com/tidwall/gjson"
7-
"github.com/tidwall/sjson"
85
"os"
96
"strconv"
107
"strings"
@@ -402,36 +399,4 @@ func main() {
402399
if err != nil {
403400
panic(err)
404401
}
405-
406-
// Load the runtime package.json
407-
packageJsonFilename := "../../internal/runtime/desktop/@wailsio/runtime/package.json"
408-
packageJSON, err := os.ReadFile(packageJsonFilename)
409-
if err != nil {
410-
panic(err)
411-
}
412-
version := gjson.Get(string(packageJSON), "version").String()
413-
// Parse and increment version
414-
v := semver.MustParse(version)
415-
prerelease := v.Prerelease()
416-
// Split the prerelease by the "." and increment the last part by 1
417-
parts := strings.Split(prerelease, ".")
418-
prereleaseDigits, err := strconv.Atoi(parts[len(parts)-1])
419-
if err != nil {
420-
panic(err)
421-
}
422-
prereleaseNumber := strconv.Itoa(prereleaseDigits + 1)
423-
parts[len(parts)-1] = prereleaseNumber
424-
prerelease = strings.Join(parts, ".")
425-
newVersion, err := v.SetPrerelease(prerelease)
426-
if err != nil {
427-
panic(err)
428-
}
429-
430-
// Set new version using sjson
431-
newJSON, err := sjson.Set(string(packageJSON), "version", newVersion.String())
432-
if err != nil {
433-
panic(err)
434-
}
435-
436-
err = os.WriteFile(packageJsonFilename, []byte(newJSON), 0644)
437402
}

v3/tasks/events/go.mod

+1-12
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,3 @@
11
module events
22

3-
go 1.22
4-
5-
require (
6-
github.com/Masterminds/semver/v3 v3.3.0
7-
github.com/tidwall/gjson v1.18.0
8-
github.com/tidwall/sjson v1.2.5
9-
)
10-
11-
require (
12-
github.com/tidwall/match v1.1.1 // indirect
13-
github.com/tidwall/pretty v1.2.0 // indirect
14-
)
3+
go 1.24

v3/tasks/events/go.sum

-11
This file was deleted.

0 commit comments

Comments
 (0)