Skip to content

chore: use yamux instead of mplex #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weboko opened this issue Jan 3, 2024 · 11 comments · May be fixed by #2325
Open

chore: use yamux instead of mplex #1771

weboko opened this issue Jan 3, 2024 · 11 comments · May be fixed by #2325
Assignees
Labels
enhancement New feature or request

Comments

@weboko
Copy link
Collaborator

weboko commented Jan 3, 2024

This is a change request

Proposed Solutions

Use yamux here:

streamMuxers: [mplex()],

Notes

From the thread - waku-org/go-waku#851 (comment)

@weboko weboko added the enhancement New feature or request label Jan 3, 2024
@weboko weboko added this to Waku Jan 3, 2024
@chair28980 chair28980 moved this to Priority in Waku Jan 10, 2024
@danisharora099 danisharora099 moved this from Priority to In Progress in Waku Mar 7, 2024
@danisharora099 danisharora099 self-assigned this Mar 7, 2024
@danisharora099 danisharora099 moved this from In Progress to Blocked in Waku Mar 7, 2024
@danisharora099
Copy link
Collaborator

danisharora099 commented Mar 7, 2024

Addressed in js-waku here: #1894

Blocked until nwaku releases support for yamux: waku-org/nwaku#2518

@weboko
Copy link
Collaborator Author

weboko commented Apr 24, 2024

@weboko weboko moved this from Blocked to To Do in Waku Apr 24, 2024
@danisharora099
Copy link
Collaborator

Yes, the PR upgraded nwaku to 0.27 but dials seem to be failing. Will come back to this and investigate

@danisharora099 danisharora099 moved this from To Do to In Progress in Waku Sep 18, 2024
@danisharora099
Copy link
Collaborator

Side update: #2139 (comment)

@danisharora099 danisharora099 moved this from In Progress to Blocked in Waku Oct 8, 2024
@danisharora099
Copy link
Collaborator

@weboko weboko self-assigned this Feb 25, 2025
@weboko weboko moved this from Blocked to In Progress in Waku Feb 25, 2025
@weboko
Copy link
Collaborator Author

weboko commented Feb 25, 2025

Moving to in progress to check it out once more.

@weboko weboko moved this from In Progress to Code Review / QA in Waku Mar 11, 2025
@weboko weboko linked a pull request Mar 26, 2025 that will close this issue
5 tasks
@weboko
Copy link
Collaborator Author

weboko commented Mar 31, 2025

Ok, short update.

At my initial investigation it seemed yamux was working fine but then upon revisiting last week during dogfooding session if failed miserably exactly with the similar issue @danisharora099 linked.

I did not investigate it deeper yet.

Moving to blocked as it's low priority comparing to other issues.

Will debug a bit more to see if it addressable by any means.

@weboko
Copy link
Collaborator Author

weboko commented Apr 18, 2025

Image

@weboko
Copy link
Collaborator Author

weboko commented Apr 18, 2025

It seems like protocol error is the reason why js-waku received GoAway package:

Image

@weboko
Copy link
Collaborator Author

weboko commented Apr 18, 2025

Image

@weboko
Copy link
Collaborator Author

weboko commented Apr 18, 2025

@weboko weboko moved this from Code Review / QA to Blocked in Waku Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Blocked
2 participants