Skip to content

Commit ea21156

Browse files
lotyplotyp
committed
ci: apply rector/rector upgrades
1 parent db21346 commit ea21156

10 files changed

+80
-88
lines changed

‎psalm-baseline.xml

+41-1
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@
103103
<code><![CDATA[string]]></code>
104104
</ImplicitToStringCast>
105105
<InvalidDocblock>
106-
<code><![CDATA[private SerializerInterface $serializer;]]></code>
106+
<code><![CDATA[private readonly SerializerInterface $serializer;]]></code>
107107
</InvalidDocblock>
108108
<MixedAssignment>
109109
<code><![CDATA[$normalizedResponse]]></code>
@@ -149,6 +149,21 @@
149149
<code><![CDATA[bound]]></code>
150150
<code><![CDATA[bound]]></code>
151151
</PossiblyNullReference>
152+
<PossiblyUnusedMethod>
153+
<code><![CDATA[it_registers_config]]></code>
154+
<code><![CDATA[it_registers_encoders_registry]]></code>
155+
<code><![CDATA[it_registers_normalizers_registry]]></code>
156+
<code><![CDATA[it_registers_serializer]]></code>
157+
</PossiblyUnusedMethod>
158+
</file>
159+
<file src="tests/src/Functional/EncodersRegistryTest.php">
160+
<PossiblyUnusedMethod>
161+
<code><![CDATA[all]]></code>
162+
<code><![CDATA[construct_with_default_encoders]]></code>
163+
<code><![CDATA[construct_with_encoders]]></code>
164+
<code><![CDATA[has]]></code>
165+
<code><![CDATA[register]]></code>
166+
</PossiblyUnusedMethod>
152167
</file>
153168
<file src="tests/src/Functional/Normalizers/RamseyUuidNormalizerTest.php">
154169
<MixedArgument>
@@ -167,13 +182,21 @@
167182
<code><![CDATA[get]]></code>
168183
</PossiblyNullReference>
169184
<PossiblyUnusedMethod>
185+
<code><![CDATA[serialize]]></code>
170186
<code><![CDATA[serializeDataProvider]]></code>
187+
<code><![CDATA[unserialize]]></code>
171188
</PossiblyUnusedMethod>
172189
</file>
173190
<file src="tests/src/Functional/NormalizersRegistryTest.php">
174191
<MixedAssignment>
175192
<code><![CDATA[$element]]></code>
176193
</MixedAssignment>
194+
<PossiblyUnusedMethod>
195+
<code><![CDATA[all]]></code>
196+
<code><![CDATA[construct_with_default_normalizers]]></code>
197+
<code><![CDATA[has]]></code>
198+
<code><![CDATA[register]]></code>
199+
</PossiblyUnusedMethod>
177200
</file>
178201
<file src="tests/src/Functional/ResponseFactoryTest.php">
179202
<MixedArgument>
@@ -183,6 +206,13 @@
183206
<code><![CDATA[app(SerializerManager::class)]]></code>
184207
<code><![CDATA[app(SerializerManager::class)]]></code>
185208
</MixedArgument>
209+
<PossiblyUnusedMethod>
210+
<code><![CDATA[it_creates_from_array_iterator]]></code>
211+
<code><![CDATA[it_creates_response]]></code>
212+
<code><![CDATA[it_creates_response_from_array]]></code>
213+
<code><![CDATA[it_sets_non_default_status_code]]></code>
214+
<code><![CDATA[it_uses_given_context]]></code>
215+
</PossiblyUnusedMethod>
186216
</file>
187217
<file src="tests/src/Functional/SerializerManagerTest.php">
188218
<MixedAssignment>
@@ -192,7 +222,11 @@
192222
<code><![CDATA[make]]></code>
193223
</PossiblyNullReference>
194224
<PossiblyUnusedMethod>
225+
<code><![CDATA[bad_serializer]]></code>
226+
<code><![CDATA[get_serializer]]></code>
227+
<code><![CDATA[serialize]]></code>
195228
<code><![CDATA[serializeDataProvider]]></code>
229+
<code><![CDATA[unserialize]]></code>
196230
<code><![CDATA[unserializeDataProvider]]></code>
197231
</PossiblyUnusedMethod>
198232
</file>
@@ -227,7 +261,13 @@
227261
<code><![CDATA[get]]></code>
228262
</PossiblyNullReference>
229263
<PossiblyUnusedMethod>
264+
<code><![CDATA[group_normalize]]></code>
265+
<code><![CDATA[serialize]]></code>
230266
<code><![CDATA[serializeDataProvider]]></code>
267+
<code><![CDATA[unserialize]]></code>
268+
<code><![CDATA[unserialize_date_time_interface]]></code>
269+
<code><![CDATA[unserialize_nested_objects]]></code>
270+
<code><![CDATA[unserialize_with_attributes]]></code>
231271
</PossiblyUnusedMethod>
232272
</file>
233273
</files>

‎src/ResponseFactory.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ final class ResponseFactory
1212
/**
1313
* @property SerializerInterface $serializer
1414
*/
15-
private SerializerInterface $serializer;
15+
private readonly SerializerInterface $serializer;
1616

1717
private array $context = [];
1818

‎tests/app/Item.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
final class Item
1212
{
1313
#[Groups(['default', 'private'])]
14-
private UuidInterface $id;
14+
private readonly UuidInterface $id;
1515

1616
#[Groups(['default'])]
1717
private string $key = 'magic_number';

‎tests/src/Functional/Bridge/Laravel/Providers/SerializerServiceProviderTest.php

+5-12
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
namespace WayOfDev\Tests\Functional\Bridge\Laravel\Providers;
66

7+
use PHPUnit\Framework\Attributes\Test;
78
use Symfony\Component\Serializer\Serializer;
89
use Symfony\Component\Serializer\SerializerInterface;
910
use WayOfDev\Serializer\Config;
@@ -16,36 +17,28 @@
1617

1718
final class SerializerServiceProviderTest extends TestCase
1819
{
19-
/**
20-
* @test
21-
*/
20+
#[Test]
2221
public function it_registers_config(): void
2322
{
2423
self::assertTrue($this->app->bound(ConfigRepository::class));
2524
self::assertInstanceOf(Config::class, $this->app->make(ConfigRepository::class));
2625
}
2726

28-
/**
29-
* @test
30-
*/
27+
#[Test]
3128
public function it_registers_normalizers_registry(): void
3229
{
3330
self::assertTrue($this->app->bound(NormalizersRegistryInterface::class));
3431
self::assertInstanceOf(NormalizersRegistry::class, $this->app->make(NormalizersRegistryInterface::class));
3532
}
3633

37-
/**
38-
* @test
39-
*/
34+
#[Test]
4035
public function it_registers_encoders_registry(): void
4136
{
4237
self::assertTrue($this->app->bound(EncodersRegistryInterface::class));
4338
self::assertInstanceOf(EncodersRegistry::class, $this->app->make(EncodersRegistryInterface::class));
4439
}
4540

46-
/**
47-
* @test
48-
*/
41+
#[Test]
4942
public function it_registers_serializer(): void
5043
{
5144
self::assertTrue($this->app->bound(SerializerInterface::class));

‎tests/src/Functional/EncodersRegistryTest.php

+6-14
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
namespace WayOfDev\Tests\Functional;
66

7+
use PHPUnit\Framework\Attributes\Test;
78
use PHPUnit\Framework\MockObject\Exception;
89
use Symfony\Component\Serializer\Encoder\CsvEncoder;
910
use Symfony\Component\Serializer\Encoder\EncoderInterface;
@@ -14,9 +15,7 @@
1415

1516
final class EncodersRegistryTest extends TestCase
1617
{
17-
/**
18-
* @test
19-
*/
18+
#[Test]
2019
public function construct_with_default_encoders(): void
2120
{
2221
$registry = new EncodersRegistry();
@@ -29,9 +28,7 @@ public function construct_with_default_encoders(): void
2928
self::assertTrue($registry->has(YamlEncoder::class));
3029
}
3130

32-
/**
33-
* @test
34-
*/
31+
#[Test]
3532
public function construct_with_encoders(): void
3633
{
3734
$registry = new EncodersRegistry([new JsonEncoder(), new CsvEncoder()]);
@@ -44,9 +41,7 @@ public function construct_with_encoders(): void
4441
self::assertFalse($registry->has(YamlEncoder::class));
4542
}
4643

47-
/**
48-
* @test
49-
*/
44+
#[Test]
5045
public function register(): void
5146
{
5247
$registry = new EncodersRegistry();
@@ -63,9 +58,7 @@ public function register(): void
6358
self::assertTrue($registry->has($encoder::class));
6459
}
6560

66-
/**
67-
* @test
68-
*/
61+
#[Test]
6962
public function all(): void
7063
{
7164
$json = new JsonEncoder();
@@ -76,10 +69,9 @@ public function all(): void
7669
}
7770

7871
/**
79-
* @test
80-
*
8172
* @throws Exception
8273
*/
74+
#[Test]
8375
public function has(): void
8476
{
8577
$encoder = $this->createMock(EncoderInterface::class);

‎tests/src/Functional/Normalizers/RamseyUuidNormalizerTest.php

+3-6
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
namespace WayOfDev\Tests\Functional\Normalizers;
66

77
use PHPUnit\Framework\Attributes\DataProvider;
8+
use PHPUnit\Framework\Attributes\Test;
89
use Ramsey\Uuid\Uuid;
910
use Traversable;
1011
use WayOfDev\App\Object\Author;
@@ -34,20 +35,16 @@ public static function serializeDataProvider(): Traversable
3435
];
3536
}
3637

37-
/**
38-
* @test
39-
*/
4038
#[DataProvider('serializeDataProvider')]
39+
#[Test]
4140
public function serialize(string $expected, mixed $payload, string $format): void
4241
{
4342
$manager = $this->app->get(SerializerManager::class);
4443

4544
self::assertSame($expected, preg_replace('/\s+/', '', $manager->serialize($payload, $format)));
4645
}
4746

48-
/**
49-
* @test
50-
*/
47+
#[Test]
5148
public function unserialize(): void
5249
{
5350
$manager = $this->app->get(SerializerManager::class);

‎tests/src/Functional/NormalizersRegistryTest.php

+5-8
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
namespace WayOfDev\Tests\Functional;
66

7+
use PHPUnit\Framework\Attributes\Test;
78
use PHPUnit\Framework\MockObject\Exception;
89
use Symfony\Component\Serializer\Mapping\Loader\LoaderInterface;
910
use Symfony\Component\Serializer\Normalizer;
@@ -34,10 +35,9 @@ public static function assertContainsInstanceOf(string $className, array $array)
3435
}
3536

3637
/**
37-
* @test
38-
*
3938
* @throws Exception
4039
*/
40+
#[Test]
4141
public function construct_with_default_normalizers(): void
4242
{
4343
$registry = new NormalizersRegistry(
@@ -65,10 +65,9 @@ public function construct_with_default_normalizers(): void
6565
}
6666

6767
/**
68-
* @test
69-
*
7068
* @throws Exception
7169
*/
70+
#[Test]
7271
public function register(): void
7372
{
7473
$registry = new NormalizersRegistry(
@@ -92,10 +91,9 @@ public function register(): void
9291
}
9392

9493
/**
95-
* @test
96-
*
9794
* @throws Exception
9895
*/
96+
#[Test]
9997
public function all(): void
10098
{
10199
$registry = new NormalizersRegistry(
@@ -111,10 +109,9 @@ public function all(): void
111109
}
112110

113111
/**
114-
* @test
115-
*
116112
* @throws Exception
117113
*/
114+
#[Test]
118115
public function has(): void
119116
{
120117
$normalizer = $this->createMock(Normalizer\NormalizerInterface::class);

‎tests/src/Functional/ResponseFactoryTest.php

+6-15
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
namespace WayOfDev\Tests\Functional;
66

7+
use PHPUnit\Framework\Attributes\Test;
78
use WayOfDev\App\Item;
89
use WayOfDev\App\Object\Post;
910
use WayOfDev\App\Response;
@@ -12,9 +13,7 @@
1213

1314
final class ResponseFactoryTest extends TestCase
1415
{
15-
/**
16-
* @test
17-
*/
16+
#[Test]
1817
public function it_creates_response(): void
1918
{
2019
$responseFactory = new ResponseFactory(app(SerializerManager::class));
@@ -29,9 +28,7 @@ public function it_creates_response(): void
2928
self::assertEquals('{"id":1,"text":"Some text","active":true,"views":777}', $response->getContent());
3029
}
3130

32-
/**
33-
* @test
34-
*/
31+
#[Test]
3532
public function it_creates_from_array_iterator(): void
3633
{
3734
$responseFactory = new ResponseFactory(app(SerializerManager::class));
@@ -42,9 +39,7 @@ public function it_creates_from_array_iterator(): void
4239
self::assertEquals('[{"id":"0cd74c72-8920-4e4e-86c3-19fdd5103514","key":"magic_number","value":12}]', $response->getContent());
4340
}
4441

45-
/**
46-
* @test
47-
*/
42+
#[Test]
4843
public function it_creates_response_from_array(): void
4944
{
5045
$responseFactory = new ResponseFactory(app(SerializerManager::class));
@@ -57,9 +52,7 @@ public function it_creates_response_from_array(): void
5752
);
5853
}
5954

60-
/**
61-
* @test
62-
*/
55+
#[Test]
6356
public function it_sets_non_default_status_code(): void
6457
{
6558
$responseFactory = new ResponseFactory(app(SerializerManager::class));
@@ -71,9 +64,7 @@ public function it_sets_non_default_status_code(): void
7164
self::assertEquals('{"id":"0cd74c72-8920-4e4e-86c3-19fdd5103514","key":"magic_number","value":12}', $response->getContent());
7265
}
7366

74-
/**
75-
* @test
76-
*/
67+
#[Test]
7768
public function it_uses_given_context(): void
7869
{
7970
$responseFactory = new ResponseFactory(app(SerializerManager::class));

0 commit comments

Comments
 (0)