App history: rename respondWith() to transitionWhile()

... and canRespond to canTransition.

Follows WICG/navigation-api#151.

Bug: 1183545
Change-Id: Ide039a88cb9a40688a0fff99ff8b3a954a12faaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3100807
Reviewed-by: Nasko Oskov <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Domenic Denicola <[email protected]>
Cr-Commit-Position: refs/heads/master@{#912818}

Author: domenic

app-history/navigate-event/event-constructor.html

@@ -6,7 +6,7 @@
   assert_throws_js(TypeError, () => {
     new AppHistoryNavigateEvent("navigate", {
       navigationType: "push",
-      canRespond: false,
+      canTransition: false,
       userInitiated: false,
       hashChange: false,
       signal: (new AbortController()).signal,
@@ -23,7 +23,7 @@
       new AppHistoryNavigateEvent("navigate", {
         navigationType: "push",
         destination: e.destination,
-        canRespond: false,
+        canTransition: false,
         userInitiated: false,
         hashChange: false,
         formData: null,
@@ -44,7 +44,7 @@
     const event = new AppHistoryNavigateEvent("navigate", {
       navigationType: "replace",
       destination: e.destination,
-      canRespond: true,
+      canTransition: true,
       userInitiated: true,
       hashChange: true,
       signal,
@@ -54,7 +54,7 @@
 
     assert_equals(event.navigationType, "replace");
     assert_equals(event.destination, e.destination);
-    assert_equals(event.canRespond, true);
+    assert_equals(event.canTransition, true);
     assert_equals(event.userInitiated, true);
     assert_equals(event.hashChange, true);
     assert_equals(event.signal, signal);
@@ -73,7 +73,7 @@
     });
 
     assert_equals(event.navigationType, "push");
-    assert_equals(event.canRespond, false);
+    assert_equals(event.canTransition, false);
     assert_equals(event.userInitiated, false);
     assert_equals(event.hashChange, false);
     assert_equals(event.formData, null);

app-history/navigate-event/navigate-anchor-cross-origin.html

@@ -7,7 +7,7 @@
   appHistory.onnavigate = t.step_func_done(e => {
     assert_equals(e.navigationType, "push");
     assert_true(e.cancelable);
-    assert_false(e.canRespond);
+    assert_false(e.canTransition);
     assert_false(e.userInitiated);
     assert_false(e.hashChange);
     assert_equals(e.formData, null);

app-history/navigate-event/navigate-anchor-fragment.html

@@ -7,7 +7,7 @@
   appHistory.onnavigate = t.step_func(e => {
     assert_equals(e.navigationType, "push");
     assert_true(e.cancelable);
-    assert_true(e.canRespond);
+    assert_true(e.canTransition);
     assert_false(e.userInitiated);
     assert_true(e.hashChange);
     assert_equals(e.formData, null);

app-history/navigate-event/navigate-anchor-same-origin-cross-document.html

@@ -7,7 +7,7 @@
   appHistory.onnavigate = t.step_func_done(e => {
     assert_equals(e.navigationType, "push");
     assert_true(e.cancelable);
-    assert_true(e.canRespond);
+    assert_true(e.canTransition);
     assert_false(e.userInitiated);
     assert_false(e.hashChange);
     assert_equals(e.formData, null);

app-history/navigate-event/navigate-anchor-userInitiated.html

@@ -10,7 +10,7 @@
   appHistory.onnavigate = t.step_func(e => {
     assert_equals(e.navigationType, "push");
     assert_true(e.cancelable);
-    assert_true(e.canRespond);
+    assert_true(e.canTransition);
     assert_true(e.userInitiated);
     assert_true(e.hashChange);
     assert_equals(e.formData, null);

app-history/navigate-event/navigate-anchor-with-target.html

@@ -12,7 +12,7 @@
     iframe.contentWindow.appHistory.onnavigate = t.step_func_done(e => {
       assert_equals(e.navigationType, "push");
       assert_true(e.cancelable);
-      assert_true(e.canRespond);
+      assert_true(e.canTransition);
       assert_false(e.userInitiated);
       assert_false(e.hashChange);
       assert_equals(e.formData, null);

app-history/navigate-event/navigate-appHistory-back-cross-document.html

@@ -12,7 +12,7 @@
       i.contentWindow.appHistory.onnavigate = t.step_func_done(e => {
         assert_equals(e.navigationType, "traverse");
         assert_true(e.cancelable);
-        assert_false(e.canRespond);
+        assert_false(e.canTransition);
         assert_false(e.userInitiated);
         assert_false(e.hashChange);
         assert_equals(new URL(e.destination.url).pathname, "/common/blank.html");

app-history/navigate-event/navigate-appHistory-back-same-document.html

@@ -12,7 +12,7 @@
       appHistory.onnavigate = t.step_func_done(e => {
         assert_equals(e.navigationType, "traverse");
         assert_true(e.cancelable);
-        assert_true(e.canRespond);
+        assert_true(e.canTransition);
         assert_false(e.userInitiated);
         assert_true(e.hashChange);
         assert_equals(new URL(e.destination.url).hash, "");

app-history/navigate-event/navigate-appHistory-navigate.html

@@ -6,7 +6,7 @@
   appHistory.onnavigate = t.step_func_done(e => {
     assert_equals(e.navigationType, "replace");
     assert_true(e.cancelable);
-    assert_true(e.canRespond);
+    assert_true(e.canTransition);
     assert_false(e.userInitiated);
     assert_true(e.hashChange);
     assert_equals(new URL(e.destination.url).hash, "#foo");

app-history/navigate-event/navigate-cross-origin-iframe-location.html

@@ -12,7 +12,7 @@
   document.body.appendChild(iframe);
 
   window.onmessage = t.step_func_done(e => {
-    assert_equals(e.data, "cancelable,canRespond,hashChange,");
+    assert_equals(e.data, "cancelable,canTransition,hashChange,");
   });
 
   appHistory.onnavigate = t.step_func_done(() => {

app-history/navigate-event/navigate-form-get.html

@@ -9,7 +9,7 @@
 
     assert_equals(e.navigationType, "replace");
     assert_true(e.cancelable);
-    assert_true(e.canRespond);
+    assert_true(e.canTransition);
     assert_false(e.userInitiated);
     assert_false(e.hashChange);
     assert_equals(e.destination.url, location.href + "?");

app-history/navigate-event/navigate-form-userInitiated.html

@@ -14,7 +14,7 @@
 
     assert_equals(e.navigationType, "push");
     assert_true(e.cancelable);
-    assert_true(e.canRespond);
+    assert_true(e.canTransition);
     assert_true(e.userInitiated);
     assert_false(e.hashChange);
     assert_equals(e.destination.url, location.href);

app-history/navigate-event/navigate-form-with-target.html

@@ -11,7 +11,7 @@
     iframe.contentWindow.appHistory.onnavigate = t.step_func_done(e => {
       assert_equals(e.navigationType, "push");
       assert_true(e.cancelable);
-      assert_true(e.canRespond);
+      assert_true(e.canTransition);
       assert_false(e.userInitiated);
       assert_false(e.hashChange);
       assert_equals(new URL(e.destination.url).pathname,

app-history/navigate-event/navigate-form.html

@@ -9,7 +9,7 @@
 
     assert_equals(e.navigationType, "replace");
     assert_true(e.cancelable);
-    assert_true(e.canRespond);
+    assert_true(e.canTransition);
     assert_false(e.userInitiated);
     assert_false(e.hashChange);
     assert_equals(e.destination.url, location.href);

app-history/navigate-event/navigate-history-back-after-fragment.html

@@ -13,7 +13,7 @@
     appHistory.onnavigate = t.step_func_done(e => {
       assert_equals(e.navigationType, "traverse");
       assert_true(e.cancelable);
-      assert_true(e.canRespond);
+      assert_true(e.canTransition);
       assert_false(e.userInitiated);
       assert_true(e.hashChange);
       assert_equals(new URL(e.destination.url).hash, "");

app-history/navigate-event/navigate-history-back-after-pushState.html

@@ -13,7 +13,7 @@
     appHistory.onnavigate = t.step_func_done(e => {
       assert_equals(e.navigationType, "traverse");
       assert_true(e.cancelable);
-      assert_true(e.canRespond);
+      assert_true(e.canTransition);
       assert_false(e.userInitiated);
       assert_false(e.hashChange);
       assert_equals(new URL(e.destination.url).hash, "");

app-history/navigate-event/navigate-history-go-0.html

@@ -8,7 +8,7 @@
     i.contentWindow.appHistory.onnavigate = t.step_func_done(e => {
       assert_equals(e.navigationType, "reload");
       assert_true(e.cancelable);
-      assert_true(e.canRespond);
+      assert_true(e.canTransition);
       assert_false(e.userInitiated);
       assert_false(e.hashChange);
       assert_equals(new URL(e.destination.url).pathname, "/common/blank.html");

app-history/navigate-event/navigate-history-pushState.html

@@ -7,7 +7,7 @@
   appHistory.onnavigate = t.step_func(e => {
     assert_equals(e.navigationType, "push");
     assert_true(e.cancelable);
-    assert_true(e.canRespond);
+    assert_true(e.canTransition);
     assert_false(e.userInitiated);
     assert_false(e.hashChange);
     assert_equals(new URL(e.destination.url).hash, "#1");

app-history/navigate-event/navigate-history-replaceState.html

@@ -7,7 +7,7 @@
   appHistory.onnavigate = t.step_func(e => {
     assert_equals(e.navigationType, "replace");
     assert_true(e.cancelable);
-    assert_true(e.canRespond);
+    assert_true(e.canTransition);
     assert_false(e.userInitiated);
     assert_false(e.hashChange);
     assert_equals(new URL(e.destination.url).hash, "#1");

app-history/navigate-event/navigate-iframe-location.html

@@ -11,7 +11,7 @@
     iframe.contentWindow.appHistory.onnavigate = t.step_func_done(e => {
       assert_equals(e.navigationType, "push");
       assert_true(e.cancelable);
-      assert_true(e.canRespond);
+      assert_true(e.canTransition);
       assert_false(e.userInitiated);
       assert_true(e.hashChange);
       assert_equals(new URL(e.destination.url).hash, "#1");

app-history/navigate-event/navigate-location.html

@@ -7,7 +7,7 @@
   appHistory.onnavigate = t.step_func_done(e => {
     assert_equals(e.navigationType, "replace");
     assert_true(e.cancelable);
-    assert_true(e.canRespond);
+    assert_true(e.canTransition);
     assert_false(e.userInitiated);
     assert_true(e.hashChange);
     assert_equals(new URL(e.destination.url).hash, "#1");

app-history/navigate-event/navigate-meta-refresh.html

@@ -10,7 +10,7 @@
     i.contentWindow.appHistory.onnavigate = t.step_func_done(e => {
       assert_equals(e.navigationType, "reload");
       assert_true(e.cancelable);
-      assert_true(e.canRespond);
+      assert_true(e.canTransition);
       assert_false(e.userInitiated);
       assert_false(e.hashChange);
       assert_equals(e.destination.url, i.contentWindow.location.href);

app-history/navigate-event/navigate-window-open-self.html

@@ -6,7 +6,7 @@
   appHistory.onnavigate = t.step_func_done(e => {
     assert_equals(e.navigationType, "push");
     assert_true(e.cancelable);
-    assert_true(e.canRespond);
+    assert_true(e.canTransition);
     assert_false(e.userInitiated);
     assert_true(e.hashChange);
     assert_equals(new URL(e.destination.url).hash, "#1");

app-history/navigate-event/navigate-window-open.html

@@ -11,7 +11,7 @@
     iframe.contentWindow.appHistory.onnavigate = t.step_func_done(e => {
       assert_equals(e.navigationType, "push");
       assert_true(e.cancelable);
-      assert_true(e.canRespond);
+      assert_true(e.canTransition);
       assert_false(e.userInitiated);
       assert_true(e.hashChange);
       assert_equals(new URL(e.destination.url).hash, "#1");

app-history/navigate-event/navigateerror-ordering-location-api-reentrant.html

@@ -15,7 +15,7 @@
   appHistory.onnavigate = t.step_func(e => {
     events.push("navigate");
     e.signal.onabort = () => events.push("abort");
-    e.respondWith(Promise.resolve());
+    e.transitionWhile(Promise.resolve());
     if (first_onnavigate) {
       first_onnavigate = false;
       location.hash = "#2";

app-history/navigate-event/navigateerror-ordering-location-api.html

@@ -14,7 +14,7 @@
   appHistory.onnavigate = t.step_func(e => {
     events.push("navigate");
     e.signal.onabort = () => events.push("abort");
-    e.respondWith(Promise.resolve());
+    e.transitionWhile(Promise.resolve());
   });
   location.hash = "#1";
   location.hash = "#2";

app-history/navigate-event/navigateerror-ordering-respondWith-reentrant.html renamed to app-history/navigate-event/navigateerror-ordering-transitionWhile-reentrant.html

@@ -17,7 +17,7 @@
     assert_equals(location.href, start_href);
     events.push("navigate");
     e.signal.onabort = () => events.push("abort");
-    e.respondWith(new Promise(resolve => t.step_timeout(resolve, 2)));
+    e.transitionWhile(new Promise(resolve => t.step_timeout(resolve, 2)));
     if (first_onnavigate) {
       first_onnavigate = false;
       p2 = appHistory.navigate("#2").then(() => events.push("p2_fulfill"));
@@ -30,5 +30,5 @@
   await p1;
   await p2;
   assert_array_equals(events, ["navigate", "abort", "navigateerror", "navigate", "p1_reject", "navigatesuccess", "p2_fulfill"]);
-}, "navigateerror ordering when navigate() is called reentrantly and handled by respondWith()");
+}, "navigateerror ordering when navigate() is called reentrantly and handled by transitionWhile()");
 </script>

app-history/navigate-event/navigateerror-ordering-respondWith.html renamed to app-history/navigate-event/navigateerror-ordering-transitionWhile.html

@@ -14,12 +14,12 @@
   appHistory.onnavigate = t.step_func(e => {
     events.push("navigate");
     e.signal.onabort = () => events.push("onabort");
-    e.respondWith(new Promise(resolve => t.step_timeout(resolve, 2)));
+    e.transitionWhile(new Promise(resolve => t.step_timeout(resolve, 2)));
   });
   const p1 = promise_rejects_dom(t, 'AbortError', appHistory.navigate("#1")).then(() => events.push("p1_reject"));
   await appHistory.navigate("#2").then(() => events.push("p2_fulfill"));
   await p1;
   assert_equals(location.hash, "#2");
   assert_array_equals(events, ["navigate", "onabort", "onnavigateerror", "navigate", "p1_reject", "onnavigatesuccess", "p2_fulfill"]);
-}, "navigateerror ordering when navigate() is called repeatedly and handled by respondWith()");
+}, "navigateerror ordering when navigate() is called repeatedly and handled by transitionWhile()");
 </script>

app-history/navigate-event/resources/cross-origin-iframe-helper.html

@@ -3,8 +3,8 @@
   let message = "";
   if (e.cancelable)
     message += "cancelable,";
-  if (e.canRespond)
-    message += "canRespond,";
+  if (e.canTransition)
+    message += "canTransition,";
   if (e.userInitiated)
     message += "userInitiated,";
   if (e.hashChange)

app-history/navigate-event/signal-abort-respondWith.html renamed to app-history/navigate-event/signal-abort-transitionWhile.html

@@ -8,11 +8,11 @@
   appHistory.onnavigate = t.step_func(e => {
     abort_signal = e.signal;
     abort_signal.onabort = () => onabort_called = true;
-    e.respondWith(Promise.resolve());
+    e.transitionWhile(Promise.resolve());
   });
 
   await appHistory.navigate("?1");
   assert_false(abort_signal.aborted);
   assert_false(onabort_called);
-}, "AppHistoryNavigateEvent.respondWith does not signal AppHistoryNavigateEvent.signal");
+}, "AppHistoryNavigateEvent's transitionWhile() does not signal AppHistoryNavigateEvent's signal");
 </script>

app-history/navigate-event/signal-abort-window-stop-after-respondWith.html renamed to app-history/navigate-event/signal-abort-window-stop-after-transitionWhile.html

@@ -19,7 +19,7 @@
     appHistory.onnavigate = t.step_func(e => {
       abort_signal = e.signal;
       abort_signal.onabort = () => onabort_called = true;
-      e.respondWith(new Promise(resolve => t.step_timeout(resolve, 0)));
+      e.transitionWhile(new Promise(resolve => t.step_timeout(resolve, 0)));
     });
     let navigate_promise = appHistory.navigate("?1");
     window.stop();
@@ -33,5 +33,5 @@
       t.step_timeout(t.step_func_done(() => {}), 5);
     });
   });
-}, "window.stop() cancels AppHistoryNavigateEvent.respondWith and signals AppHistoryNavigateEvent.signal");
+}, "window.stop() cancels AppHistoryNavigateEvent's transitionWhile() and signals AppHistoryNavigateEvent's signal");
 </script>

app-history/navigate-event/respondWith-appHistory-back.html renamed to app-history/navigate-event/transitionWhile-appHistory-back.html

@@ -8,12 +8,12 @@
   window.onload = () => t.step_timeout(() => {
     appHistory.navigate("#foo").then(() => {
       assert_true(appHistory.canGoBack);
-      appHistory.onnavigate = t.step_func(e => e.respondWith(Promise.resolve()));
+      appHistory.onnavigate = t.step_func(e => e.transitionWhile(Promise.resolve()));
       appHistory.back().then(t.step_func_done(() => {
         assert_equals(appHistory.entries().length, 2);
         assert_equals(appHistory.current, appHistory.entries()[0]);
       }));
     });
   }, 0);
-}, "AppHistoryNavigateEvent.respondWith can intercept appHistory.back()");
+}, "AppHistoryNavigateEvent's transitionWhile() can intercept appHistory.back()");
 </script>

app-history/navigate-event/respondWith-cross-document-same-origin.html renamed to app-history/navigate-event/transitionWhile-cross-document-same-origin.html

@@ -7,13 +7,13 @@
   let target_url = location.href + "?1";
   appHistory.onnavigate = t.step_func_done(e => {
     assert_true(e.cancelable);
-    assert_true(e.canRespond);
+    assert_true(e.canTransition);
     assert_false(e.userInitiated);
     assert_false(e.hashChange);
-    e.respondWith(Promise.resolve().then(
+    e.transitionWhile(Promise.resolve().then(
       t.step_func_done(() => assert_equals(location.href, target_url))));
   });
 
   window.onload = t.step_func(() => location.href = target_url);
-}, "AppHistoryNavigateEvent.respondWith intercepts a same-origin cross-document navigation");
+}, "AppHistoryNavigateEvent's transitionWhile() intercepts a same-origin cross-document navigation");
 </script>

app-history/navigate-event/respondWith-cross-origin.html renamed to app-history/navigate-event/transitionWhile-cross-origin.html

@@ -6,13 +6,13 @@
 async_test(t => {
   appHistory.onnavigate = t.step_func_done(e => {
     assert_true(e.cancelable);
-    assert_false(e.canRespond);
+    assert_false(e.canTransition);
     assert_false(e.userInitiated);
     assert_false(e.hashChange);
-    assert_throws_dom("SecurityError", () => e.respondWith(Promise.resolve()));
+    assert_throws_dom("SecurityError", () => e.transitionWhile(Promise.resolve()));
     e.preventDefault();
   });
 
   window.onload = t.step_func(() => location.href = get_host_info().HTTPS_REMOTE_ORIGIN);
-}, "AppHistoryNavigateEvent.respondWith should throw if called for a cross origin navigation");
+}, "AppHistoryNavigateEvent's transitionWhile() should throw if called for a cross origin navigation");
 </script>

app-history/navigate-event/respondWith-detach.html renamed to app-history/navigate-event/transitionWhile-detach.html

@@ -8,7 +8,7 @@
     i.contentWindow.appHistory.onnavigate = t.step_func_done(e => {
       let iframe_constructor = i.contentWindow.DOMException;
       i.remove();
-      assert_throws_dom("InvalidStateError", iframe_constructor, () => e.respondWith(Promise.resolve()));
+      assert_throws_dom("InvalidStateError", iframe_constructor, () => e.transitionWhile(Promise.resolve()));
     });
 
     i.contentWindow.location.href = "#1";