Skip to content

Consistent aspect ratio and hide scrollbar in thumbnail #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SuaYoo opened this issue Dec 12, 2024 · 2 comments
Open

Consistent aspect ratio and hide scrollbar in thumbnail #733

SuaYoo opened this issue Dec 12, 2024 · 2 comments
Assignees
@ikreymer

Comments

@SuaYoo
Copy link
Member

SuaYoo commented Dec 12, 2024 •
edited
Loading

The crawler window, screenshot, and thumbnail aspect ratio should all be the same for consistency. Additionally, we should hide the scrollbar from the thumbnail.
This was referenced Dec 12, 2024
Closed
Merged
@SuaYoo SuaYoo mentioned this issue Jan 20, 2025
Closed
@ikreymer
Copy link
Member

The thumbnail / screenshot are generally the consistent aspect ratio already (16:9), so its just a matter of setting GEOMETRY=1920x1080x16 in helm chart - this would just prevent the resizing upon screenshot creation.

We could also make it the default in the image, that would probably have subtle changes, but not strictly necessary.

@SuaYoo SuaYoo moved this from Triage to Todo in Webrecorder Projects Feb 5, 2025
@SuaYoo SuaYoo changed the title Consistent aspect ratio Consistent aspect ratio and hide scrollbar in thumbnail Feb 5, 2025
@emma-sg emma-sg mentioned this issue Mar 3, 2025
Closed
This was referenced Mar 19, 2025
Merged
Closed
ikreymer pushed a commit that referenced this issue Apr 2, 2025
@emma-sg
Dynamically adjust reported aspect ratio based on GEOMETRY (#794)
41b968b 
Closes #793 
Related to #733

Adjusts the reported aspect ratio based on GEOMETRY env var.
Also adjusts stylesheet in screencast HTML to match.
---------
Co-authored-by: Ilya Kreymer <[email protected]>
@ikreymer
Copy link
Member

ikreymer commented Apr 2, 2025

For hiding the scrollbars (only works when using headless mode, which we do by default in Browsertrix), we can not readd the --hide-scrollbars flag to the browser. However, we need backwards compatibility for QA that was created with scrollbars. Perhaps we add a --keep-scrollbars in the crawler, which would only be used in QA when QAing crawls that were created with scrollbars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikreymer ikreymer

Labels
None yet
Projects
Webrecorder Projects
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ikreymer @SuaYoo