Merge pull request #5 from webrtc/addLinting

Add linting

Author: KaptenJansson

.csslintrc

@@ -0,0 +1,7 @@
+{
+  "box-model": false,
+  "ids": false,
+  "known-properties": false,
+  "overqualified-elements": false,
+  "unique-headings": false
+}

.eslintrc

@@ -0,0 +1,58 @@
+{
+  "rules": {
+    "array-bracket-spacing": 2,
+    "block-spacing": [2, "never"],
+    "brace-style": [2, "1tbs", { "allowSingleLine": false }],
+    "camelcase": [2, {"properties": "always"}],
+    "curly": 2,
+    "default-case": 2,
+    "dot-notation": 2,
+    "eqeqeq": 2,
+    "indent": [
+        2,
+        2
+    ],
+    "key-spacing": [2, {"beforeColon": false, "afterColon": true}],
+    "max-len": [2, 80, 2, {"ignoreUrls": true}],
+    "new-cap": 2,
+    "no-console": 0,
+    "no-else-return": 2,
+    "no-eval": 2,
+    "no-multi-spaces": 2,
+    "no-multiple-empty-lines": [2, {"max": 2}],
+    "no-shadow": 2,
+    "no-trailing-spaces": 2,
+    "no-unused-expressions": 2,
+    "no-unused-vars": [2, {"args": "none"}],
+    "object-curly-spacing": [2, "never"],
+    "padded-blocks": [2, "never"],
+    "quotes": [
+        2,
+        "single"
+    ],
+    "semi": [
+        2,
+        "always"
+    ],
+    "space-before-blocks": 2,
+    "space-before-function-paren": [2, "never"],
+    "spaced-comment": 2,
+    "valid-typeof": 2
+    },
+    "env": {
+        "es6": true,
+        "browser": true,
+        "node": false
+  },
+  "extends": ["eslint:recommended", "webrtc"],
+  "globals": {
+    "adapter": true,
+    "audioContext": true,
+    "browserSupportsIPHandlingPolicy": true,
+    "browserSupportsNonProxiedUdpBoolean": true,
+    "chrome": true,
+    "ga": true,
+    "getPolicyFromBooleans": true,
+    "trace": true,
+  }
+}

.gitignore

@@ -0,0 +1,3 @@
+node_modules
+.DS_Store
+.eslintcache

.travis.yml

@@ -0,0 +1,13 @@
+dist: trusty
+language: node_js
+cache:
+ - node_modules
+node_js:
+  - 6
+
+branches:
+  only:
+    - gh-pages
+
+script:
+  - grunt

Gruntfile.js

@@ -0,0 +1,50 @@
+'use strict';
+
+/* globals module */
+
+module.exports = function(grunt) {
+  // configure project
+  grunt.initConfig({
+    // make node configurations available
+    pkg: grunt.file.readJSON('package.json'),
+    csslint: {
+      options: {
+        csslintrc: '.csslintrc'
+      },
+      src: ['css/*.css', 'src/css/*.css']
+    },
+    eslint: {
+      options: {
+        configFile: '.eslintrc',
+        cache: true
+      },
+      target: ['src/**/*.js']
+    },
+    // Runs the npm test command which has access to the grunt path.
+    githooks: {
+      all: {
+        options: {
+          command: 'npm',
+        },
+        'pre-commit': 'test'
+      }
+    },
+    htmlhint: {
+      html1: {
+        src: ['src/**/*.html']
+      },
+      html2: {
+        src: ['index.html']
+      }
+    },
+  });
+
+  // enable plugins
+  grunt.loadNpmTasks('grunt-contrib-csslint');
+  grunt.loadNpmTasks('grunt-eslint');
+  grunt.loadNpmTasks('grunt-githooks');
+  grunt.loadNpmTasks('grunt-htmlhint');
+
+  // set default tasks to run when grunt is called without parameters
+  grunt.registerTask('default', ['csslint', 'htmlhint', 'eslint']);
+};

css/landing_page.css

@@ -17,18 +17,18 @@ a:hover {
 }
 
 a#viewSource {
-  display: block;
-  margin: 1.3em 0 0 0;
   border-top: 1px solid #999;
+  display: block;
+  margin: 1.3em 0 .0 0;
   padding: 1em 0 0 0;
 }
 
 body {
   font-family: 'Roboto', sans-serif;
+  font-weight: 300;
   margin: 0;
   padding: 1em;
   word-break: break-word;
-  font-weight: 300;
 }
 
 div#container {

package.json

@@ -0,0 +1,36 @@
+{
+  "name": "test-pages",
+  "description": "Test pages",
+  "keywords": [
+    "webrtc",
+    "demos",
+    "samples",
+    "javascript"
+  ],
+  "homepage": "https://github.com/webrtc/test-pages",
+  "bugs": {
+    "url": "https://github.com/webrtc/test-pages/issues"
+  },
+  "license": "BSD-3-Clause",
+  "author": "The WebRTC project authors",
+  "main": "index.html",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/webrtc/test-pages.git"
+  },
+  "scripts": {
+    "test": "grunt",
+    "postinstall": "grunt githooks"
+  },
+  "devDependencies": {
+    "eslint-config-webrtc": ">=1.0.0",
+    "express": "^4.14.1",
+    "grunt": ">=0.4.5",
+    "grunt-cli": ">=0.1.9",
+    "grunt-contrib-csslint": ">=0.3.1",
+    "grunt-eslint": ">=17.2.0",
+    "grunt-githooks": ">=0.3.1",
+    "grunt-htmlhint": ">=0.9.12",
+    "pem": ">=1.9.4"
+  }
+}

src/canvas-capture/index.html

@@ -14,8 +14,8 @@
   <div id="container">
     <h1>Canvas capture stream to peerConnection</h1>
 
-    <canvas id="canvas" width=32 height=24></canvas>
-    <video id="remoteVideo" width=32 height=24 autoplay=""></video>
+    <canvas id="canvas" width="32" height="24"></canvas>
+    <video id="remoteVideo" width="32" height="24" autoplay=""></video>
 
     <div>
       <button id="startButton" class="green">Start test</button>

src/canvas-capture/js/main.js

@@ -32,12 +32,13 @@ function draw() {
   context.rect(0, 0, canvas.clientWidth, canvas.clientHeight);
   var randomNumber = Math.random();
   var hue;
-  if (randomNumber < 0.33)
+  if (randomNumber < 0.33) {
     hue = 'red';
-  else if (randomNumber < 0.66)
+  } else if (randomNumber < 0.66) {
     hue = 'green';
-  else
+  } else {
     hue = 'blue';
+  }
   context.fillStyle = hue;
   context.fill();
 }

src/css/main.css

@@ -6,17 +6,17 @@
  *  tree.
  */
 .drop-down {
-  width: 65%;
   font-size: 10px;
-  white-space: nowrap
+  white-space: nowrap;
+  width: 65%;
 }
 
 .constraints {
-  width: 75%;
+  display: none;
   height: auto;
-  position: absolute;
   overflow: scroll;
-  display: none;
+  position: absolute;
+  width: 75%;
 }
 
 .float-left {
@@ -25,8 +25,8 @@
 }
 
 .float-clear-left {
-  float: left;
   clear: left;
+  float: left;
   width: 100%;
 }
 
@@ -39,9 +39,9 @@
 }
 
 #messages {
-  word-wrap: break-word;
-  white-space: pre-wrap;
   font-size: 0.7em;
+  white-space: pre-wrap;
+  word-wrap: break-word;
 }
 
 #audio-source {
@@ -64,14 +64,14 @@
 }
 
 #pc-server {
-  width: 98%;
   margin-left: 0.1em;
   margin-top: 0.1em;
+  width: 98%;
 }
 
 #peer-id-container {
-  margin-left: 60%;
   height: 1.5em;
+  margin-left: 60%;
 }
 
 #peer-id {
@@ -84,11 +84,11 @@
 }
 
 #pc-server-container {
-  position: absolute;
+  height: 1.5em;
   margin: 0 0 0 12%;
-  width: 40%;
   overflow: hidden;
-  height: 1.5em;
+  position: absolute;
+  width: 40%;
 }
 
 #pc-constraints-left {
@@ -107,8 +107,8 @@
 }
 
 .float-clear-left {
-  float: left;
   clear: left;
+  float: left;
   width: 100%;
 }
 
@@ -185,8 +185,8 @@ div#container {
   margin: 0 auto 0 auto;
   max-width: 40em;
   padding: 0 1.5em 1.3em 1.5em;
-  z-index: 2;
   position: relative;
+  z-index: 2;
 }
 
 h2 {
@@ -220,22 +220,22 @@ video {
 
 #log {
   float: left;
-  position: fixed;
+  left: 0;
   overflow: auto;
+  padding: 16px;
+  position: fixed;
   top: 0;
-  left: 0;
   width: 20%;
-  padding: 16px;
   word-wrap: break-word;
   z-index: 1;
 }
 
 @media screen and (max-width: 1200px) {
   div#log {
     float: none;
-    width: 100%;
-    position: inherit;
     padding: 0;
+    position: inherit;
+    width: 100%;
   }
   button {
     padding: 0.7em;

src/multiple-peerconnections/js/main.js

@@ -6,7 +6,7 @@
  *  tree.
  */
 
-/*jshint esversion: 6 */
+/* jshint esversion: 6 */
 
 'use strict';
 
@@ -47,8 +47,8 @@ function PeerConnection(id, cpuOveruseDetection) {
       audio: true,
       video: true
     })
-    .then(onGetUserMediaSuccess)
-    .catch(logError);
+      .then(onGetUserMediaSuccess)
+      .catch(logError);
   };
 
   this.onGetUserMediaSuccess = function(stream) {
@@ -82,7 +82,7 @@ function PeerConnection(id, cpuOveruseDetection) {
       offerToReceiveAudio: 1,
       offerToReceiveVideo: 1
     })
-    .then(onCreateOfferSuccess, logError);
+      .then(onCreateOfferSuccess, logError);
   };
 
   this.onCreateOfferSuccess = function(desc) {
@@ -91,7 +91,7 @@ function PeerConnection(id, cpuOveruseDetection) {
 
     var onCreateAnswerSuccess = this.onCreateAnswerSuccess.bind(this);
     this.remoteConnection.createAnswer()
-    .then(onCreateAnswerSuccess, logError);
+      .then(onCreateAnswerSuccess, logError);
   };
 
   this.onCreateAnswerSuccess = function(desc) {