Skip to content

Commit 8445883

Browse files
committed
Fix regression in setting up SharedWorkerGlobalScope
cf0355d regressed setting up a SharedWorkerGlobalScope by removing the steps that set its constructor url and name. This was noticed in #1782 (comment).
1 parent d23995b commit 8445883

File tree

1 file changed

+17
-3
lines changed

1 file changed

+17
-3
lines changed

source

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96700,8 +96700,9 @@ interface <dfn>SharedWorkerGlobalScope</dfn> : <span>WorkerGlobalScope</span> {
9670096700
<p>When a user agent is to <dfn data-export="">run a worker</dfn> for a script with
9670196701
<code>Worker</code> or <code>SharedWorker</code> object <var>worker</var>, <span>URL</span>
9670296702
<var>url</var>, <span>environment settings object</span> <var>outside settings</var>,
96703-
<code>MessagePort</code> <var>outside port</var>, and a <code>WorkerOptions</code> dictionary
96704-
<var>options</var>, it must run the following steps:</p>
96703+
<code>MessagePort</code> <var>outside port</var>, a <code>WorkerOptions</code> dictionary
96704+
<var>options</var>, and an optional string <var>name</var>, it must run the following steps.
96705+
(<var>name</var> must always be provided if <var>worker</var> is a <code>SharedWorker</code>.)</p>
9670596706

9670696707
<ol>
9670796708

@@ -96748,6 +96749,19 @@ interface <dfn>SharedWorkerGlobalScope</dfn> : <span>WorkerGlobalScope</span> {
9674896749
context</var> and <var>outside settings</var>, and let <var>inside settings</var> be the
9674996750
result.</p></li>
9675096751

96752+
<li>
96753+
<p>If <var>is shared</var> is true, then:</p>
96754+
96755+
<ol>
96756+
<li><p>Set <var>worker global scope</var>'s <span
96757+
data-x="concept-SharedWorkerGlobalScope-constructor-url">constructor url</span> to
96758+
<var>url</var>.</p></li>
96759+
96760+
<li><p>Set <var>worker global scope</var>'s <span
96761+
data-x="concept-SharedWorkerGlobalScope-name">name</span> to <var>name</var>.</p></li>
96762+
</ol>
96763+
</li>
96764+
9675196765
<li><p>Let <var>destination</var> be "<code data-x="">sharedworker</code>" if <var>is
9675296766
shared</var> is true, and "<code data-x="">worker</code>" otherwise.</p></li>
9675396767

@@ -97448,7 +97462,7 @@ interface <dfn>SharedWorker</dfn> : <span>EventTarget</span> {
9744897462
parallel</span>.</p></li>
9744997463

9745097464
<li><p><span>Run a worker</span> given <var>worker</var>, <var>urlRecord</var>, <var>outside
97451-
settings</var>, <var>outside port</var>, and <var>options</var>.</p></li>
97465+
settings</var>, <var>outside port</var>, <var>options</var>, and <var>name</var>.</p></li>
9745297466

9745397467
</ol>
9745497468

0 commit comments

Comments
 (0)