Skip to content

Move owner set manipulation during document discarding #2533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
domenic opened this issue Apr 13, 2017 · 3 comments · Fixed by #3473
Closed

Move owner set manipulation during document discarding #2533

domenic opened this issue Apr 13, 2017 · 3 comments · Fixed by #3473
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project topic: workers

Comments

@domenic
Copy link
Member

domenic commented Apr 13, 2017

This is a small editorial change suggestion. Probably a good first bug, although I'd prefer @annevk sign off on the idea beforehand, so assigning it to him for a spot-check. It relies on #2520 landing first (and I will reference the text assuming that lands).

Currently the definition of "discard a Document" has a funny note at the bottom of its six-step algorithm:

Whenever a Document object is discarded, it is also removed from the owner set of each worker whose set contains that Document.

Indeed, in the section "The worker's lifetime," we have

Whenever a Document object is discarded, it must be removed from the owner set of each WorkerGlobalScope object whose set contains that Document object.

This seems very strange. We should just move that latter normative statement into the algorithm for discarding a document, and get rid of the non-normative note.

@domenic domenic added clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project topic: workers labels Apr 13, 2017
@annevk annevk removed their assignment Apr 14, 2017
@annevk
Copy link
Member

annevk commented Apr 14, 2017

This seems like a good idea. I suspect it was this way to enable publishing workers as a distinct document, but even if we ever decided to do that again, we would still want it to be tightly coupled as you suggest.

@donovanglover
Copy link
Contributor

I found the two sections mentioned above and the algorithm for discarding a document. Just to clarify, I have to make a list item for the latter statement and get rid of the old <p class="note">?

@domenic
Copy link
Member Author

domenic commented Feb 16, 2018

Yeah, that plus remove the paragraph in "The worker's lifetime" section, since now it's centralized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project topic: workers
Development

Successfully merging a pull request may close this issue.

3 participants