Skip to content

Commit edac65a

Browse files
author
ericcheww
committed
move transform to top
1 parent b45b21c commit edac65a

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

src/errorHandler.js

+13-13
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,25 @@
11
const defaultTransformer = ({ err, req, res, responseBody }) => responseBody;
22

33
export default ({ debug = false, transform = defaultTransformer } = {}) => (err, req, res, next) => {
4-
const statusCode = err.httpStatus || 500
54
let responseBody = {
65
message: err.message,
76
details: err.details
87
}
8+
// body-parser error
9+
if (err.body) {
10+
responseBody.message = 'Could not parse JSON body.'
11+
}
12+
responseBody = transform({ err, req, res, responseBody });
13+
14+
const statusCode = err.httpStatus || 500;
915

10-
let stack
11-
if (err.stack) {
12-
stack = err.stack.split('\n')
13-
stack.shift()
16+
if (err.stack && debug) {
17+
let stack = err.stack.split('\n');
18+
stack.shift();
1419
stack = stack
1520
.filter(line => line.indexOf('node_modules') === -1)
16-
.map(line => line.trim())
17-
}
18-
if (debug) {
21+
.map(line => line.trim());
22+
1923
responseBody.debug = {
2024
stack,
2125
request: {
@@ -26,10 +30,6 @@ export default ({ debug = false, transform = defaultTransformer } = {}) => (err,
2630
statusCode
2731
}
2832
}
29-
// body-parser error
30-
if (err.body) {
31-
responseBody.message = 'Could not parse JSON body.'
32-
}
33-
responseBody = transform({ err, req, res, responseBody });
33+
3434
res.status(statusCode).json(responseBody)
3535
}

0 commit comments

Comments
 (0)