Skip to content
This repository was archived by the owner on Dec 12, 2024. It is now read-only.

MakeUnrooted doesn't reparent its members #313

Open
stephen-hawley opened this issue Feb 14, 2020 · 0 comments
Open

MakeUnrooted doesn't reparent its members #313

stephen-hawley opened this issue Feb 14, 2020 · 0 comments
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@stephen-hawley
Copy link
Contributor

BaseDeclaration.MakeUnrooted copies members over but doesn't reparent the members in the new class.
This is probably bad.

It can be fixed easily enough, but I don't know how that will affect the rest of the code base, so make sure the tests pass.
Also, if this gets fixed in MakeUnrooted be sure to remove the code in OverrideBuilder which is a patch for that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant