Psalm level 8

derickr · derickr · commit 802f60f986f1 · 2024-05-01T10:05:00.000+01:00
diff --git a/composer.json b/composer.json
@@ -2,8 +2,9 @@
     "name": "xdebug/xdebug.org",
     "type": "project",
     "require-dev": {
-        "vimeo/psalm": "^3.5",
-        "zetacomponents/feed": "^1.4"
+        "vimeo/psalm": "^5.23",
+        "zetacomponents/feed": "^1.4",
+        "composer/xdebug-handler": "^3.0"
     },
     "autoload": {
         "files": [
diff --git a/psalm.xml b/psalm.xml
@@ -2,6 +2,7 @@
 <psalm
     totallyTyped="false"
     resolveFromConfigFile="true"
+    errorLevel="8"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xmlns="https://getpsalm.org/schema/config"
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
diff --git a/src/Model/Country.php b/src/Model/Country.php
@@ -291,6 +291,7 @@ public function isVatNumberRequired() : bool
 		};
 	}
 
+	/** @psalm-mutation-free */
 	public function isVatChargable() : bool
 	{
 		return match($this) {
@@ -300,6 +301,7 @@ public function isVatChargable() : bool
 		};
 	}
 
+	/** @psalm-mutation-free */
 	public function getVATPercentage()
 	{
 	    return $this->isVatChargable() ? 0.20 : 0;
diff --git a/views/funding/index.php b/views/funding/index.php
@@ -1,4 +1,7 @@
 <?php
+/**
+ * @psalm-scope-this XdebugDotOrg\Model\FundingProjectsList
+ */
 XdebugDotOrg\Controller\TemplateController::setTitle('Xdebug: Projects');
 ?>
 
diff --git a/views/funding/project.php b/views/funding/project.php
@@ -1,4 +1,7 @@
 <?php
+/**
+ * @psalm-scope-this XdebugDotOrg\Model\FundingProject
+ */
 XdebugDotOrg\Controller\TemplateController::setTitle('Xdebug: Project: ' . $this->title);
 ?>
 
diff --git a/views/stripe/cancelled.php b/views/stripe/cancelled.php
@@ -1,4 +1,7 @@
 <?php
+/**
+ * @psalm-scope-this XdebugDotOrg\Model\StripeSession
+ */
 XdebugDotOrg\Controller\TemplateController::setTitle('Xdebug: Support — Payment Cancelled');
 ?>
 
diff --git a/views/stripe/index.php b/views/stripe/index.php
@@ -1,4 +1,7 @@
 <?php
+/**
+ * @psalm-scope-this XdebugDotOrg\Model\SubscriptionData
+ */
 XdebugDotOrg\Controller\TemplateController::setTitle('Xdebug: Support Sign Up');
 
 use XdebugDotOrg\Model\Country;
diff --git a/views/stripe/thanks-funding.php b/views/stripe/thanks-funding.php
@@ -1,4 +1,7 @@
 <?php
+/**
+ * @psalm-scope-this XdebugDotOrg\Model\StripeSession
+ */
 XdebugDotOrg\Controller\TemplateController::setTitle('Xdebug: Support — Thanks');
 ?>
 
diff --git a/views/stripe/thanks.php b/views/stripe/thanks.php
@@ -1,4 +1,7 @@
 <?php
+/**
+ * @psalm-scope-this XdebugDotOrg\Model\StripeSession
+ */
 XdebugDotOrg\Controller\TemplateController::setTitle('Xdebug: Support — Thanks');
 ?>
 

Original file line number	Diff line number	Diff line change
`@@ -291,6 +291,7 @@ public function isVatNumberRequired() : bool`
`291`	`291`	`};`
`292`	`292`	`}`
`293`	`293`
	`294`	`+ /** @psalm-mutation-free */`
`294`	`295`	`public function isVatChargable() : bool`
`295`	`296`	`{`
`296`	`297`	`return match($this) {`
`@@ -300,6 +301,7 @@ public function isVatChargable() : bool`
`300`	`301`	`};`
`301`	`302`	`}`
`302`	`303`
	`304`	`+ /** @psalm-mutation-free */`
`303`	`305`	`public function getVATPercentage()`
`304`	`306`	`{`
`305`	`307`	`return $this->isVatChargable() ? 0.20 : 0;`
-Original file line number
+Diff line change
@@ @@ -1,4 +1,7 @@ @@
 <?php
 +/**
 + * @psalm-scope-this XdebugDotOrg\Model\FundingProjectsList
 + */
 XdebugDotOrg\Controller\TemplateController::setTitle('Xdebug: Projects');
 ?>