[vm] Generate different offsets for dart_precompiled_runtime

Some raw objects have fields that do not exist in
dart_precompiled_runtime, making the instance size of such objects
smaller. The offsets extractor should therefore generate different
offsets for the precompiled runtime in order to reflect those
differences.

Change-Id: I367e20744fe5b2f8ffaba03bd19b2c74a422c750
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133064
Reviewed-by: Martin Kustermann <[email protected]>
Commit-Queue: Victor Agnez Lima <[email protected]>

Author: victoragnez

runtime/vm/BUILD.gn

@@ -196,3 +196,16 @@ executable("offsets_extractor") {
   ]
   include_dirs = [ ".." ]
 }
+
+executable("offsets_extractor_precompiled_runtime") {
+  configs += [
+    "..:dart_arch_config",
+    "..:dart_config",
+    "..:dart_precompiled_runtime_config",
+    ":libdart_vm_config",
+  ]
+  sources = [
+    "compiler/offsets_extractor.cc",
+  ]
+  include_dirs = [ ".." ]
+}

runtime/vm/compiler/offsets_extractor.cc

@@ -37,6 +37,55 @@ void Assert::Fail(const char* format, ...) {
 class OffsetsExtractor : public AllStatic {
  public:
   static void DumpOffsets() {
+#if defined(DART_PRECOMPILED_RUNTIME)
+
+#define PRINT_FIELD_OFFSET(Class, Name)                                        \
+  std::cout << "static constexpr dart::compiler::target::word AOT_" #Class     \
+               "_" #Name " = "                                                 \
+            << Class::Name() << ";\n";
+
+#define PRINT_ARRAY_LAYOUT(Class, Name)                                        \
+  std::cout << "static constexpr dart::compiler::target::word AOT_" #Class     \
+               "_elements_start_offset = "                                     \
+            << Class::ArrayLayout::elements_start_offset() << ";\n";           \
+  std::cout << "static constexpr dart::compiler::target::word AOT_" #Class     \
+               "_element_size = "                                              \
+            << Class::ArrayLayout::kElementSize << ";\n";
+
+#define PRINT_ARRAY_STRUCTFIELD_OFFSET(Class, Name, ElementOffsetName,         \
+                                       FieldOffset)
+
+#define PRINT_SIZEOF(Class, Name, What)                                        \
+  std::cout << "static constexpr dart::compiler::target::word AOT_" #Class     \
+               "_" #Name " = "                                                 \
+            << sizeof(What) << ";\n";
+
+#define PRINT_RANGE(Class, Name, Type, First, Last, Filter)                    \
+  {                                                                            \
+    auto filter = Filter;                                                      \
+    bool comma = false;                                                        \
+    std::cout << "static constexpr dart::compiler::target::word AOT_" #Class   \
+                 "_" #Name "[] = {";                                           \
+    for (intptr_t i = static_cast<intptr_t>(First);                            \
+         i <= static_cast<intptr_t>(Last); i++) {                              \
+      auto v = static_cast<Type>(i);                                           \
+      std::cout << (comma ? ", " : "") << (filter(v) ? Class::Name(v) : -1);   \
+      comma = true;                                                            \
+    }                                                                          \
+    std::cout << "};\n";                                                       \
+  }
+
+#define PRINT_CONSTANT(Class, Name)                                            \
+  std::cout << "static constexpr dart::compiler::target::word AOT_" #Class     \
+               "_" #Name " = "                                                 \
+            << Class::Name << ";\n";
+
+#define PRECOMP_NO_CHECK(Code)
+
+#define PRECOMP_CALCULATE(Code) Code
+
+#else  // defined(DART_PRECOMPILED_RUNTIME)
+
 #define PRINT_FIELD_OFFSET(Class, Name)                                        \
   std::cout << "static constexpr dart::compiler::target::word " #Class         \
                "_" #Name " = "                                                 \
@@ -80,9 +129,14 @@ class OffsetsExtractor : public AllStatic {
 
 #define PRECOMP_NO_CHECK(Code) Code
 
-    OFFSETS_LIST(PRINT_FIELD_OFFSET, PRINT_ARRAY_LAYOUT,
-                 PRINT_ARRAY_STRUCTFIELD_OFFSET, PRINT_SIZEOF, PRINT_RANGE,
-                 PRINT_CONSTANT, PRECOMP_NO_CHECK)
+#define PRECOMP_CALCULATE(Code) Code
+
+#endif  // defined(DART_PRECOMPILED_RUNTIME)
+
+    OFFSETS_LIST_EXTENDED(PRINT_FIELD_OFFSET, PRINT_ARRAY_LAYOUT,
+                          PRINT_ARRAY_STRUCTFIELD_OFFSET, PRINT_SIZEOF,
+                          PRINT_RANGE, PRINT_CONSTANT, PRECOMP_NO_CHECK,
+                          PRECOMP_CALCULATE)
 
 #undef PRINT_FIELD_OFFSET
 #undef PRINT_ARRAY_LAYOUT
@@ -98,7 +152,9 @@ class OffsetsExtractor : public AllStatic {
 
 int main(int argc, char* argv[]) {
   std::cout << "#if " << ARCH_DEF << std::endl;
+#if !defined(TARGET_ARCH_IA32) || !defined(DART_PRECOMPILED_RUNTIME)
   dart::OffsetsExtractor::DumpOffsets();
+#endif
   std::cout << "#endif  // " << ARCH_DEF << std::endl;
   return 0;
 }

runtime/vm/compiler/runtime_api.cc

@@ -469,9 +469,20 @@ word Context::variable_offset(word n) {
     return element_offset(index) + field_offset;                               \
   }
 
+#if defined(TARGET_ARCH_IA32)
+
 #define DEFINE_SIZEOF(clazz, name, what)                                       \
   word clazz::name() { return clazz##_##name; }
 
+#else
+
+#define DEFINE_SIZEOF(clazz, name, what)                                       \
+  word clazz::name() {                                                         \
+    return FLAG_precompiled_mode ? AOT_##clazz##_##name : clazz##_##name;      \
+  }
+
+#endif  //  defined(TARGET_ARCH_IA32)
+
 #define DEFINE_RANGE(Class, Getter, Type, First, Last, Filter)                 \
   word Class::Getter(Type index) {                                             \
     return Class##_##Getter[static_cast<intptr_t>(index) -                     \