Skip to content
This repository was archived by the owner on Mar 26, 2025. It is now read-only.

Question: Split this into package and use amalgamate to merge this into one module for xonsh #2

Open
imomaliev opened this issue Feb 13, 2017 · 3 comments

Comments

@imomaliev
Copy link
Collaborator

@scopatz @gforsyth What do you guys think about having this as a package not as module, and using amalgamation on it before adding this to xonsh. We can even store amalgamated version in repo contrib/xonsh/bash_completion.py.

@imomaliev imomaliev changed the title Question: Split this to package and use amalgamate to merge this into one module for xonsh Question: Split this into package and use amalgamate to merge this into one module for xonsh Feb 13, 2017
@AstraLuma
Copy link
Member

How confident are we in the stability of this code and not having to debug it?

Are you planning on splitting this up into multiple modules in the package? Otherwise, amalgamation will do nothing.

@imomaliev
Copy link
Collaborator Author

imomaliev commented Feb 13, 2017

@astronouth7303

How confident are we in the stability of this code and not having to debug it?

This code is just copy and paste of previous version of https://github.com/xonsh/xonsh/blob/master/xonsh/completers/bash.py, with help of @scopatz I decoupled bash.py module so that bash completion interface could be used by other python applications.

Are you planning on splitting this up into multiple modules in the package?

Yes, split platform, path and completion

@scopatz
Copy link
Member

scopatz commented Feb 13, 2017

I think it would be OK to split this up, if we could still have a way that we could collapse it down to a single file so that other projects could take and use that. Copying around a single file is much easier than a whole project directory. Amalgamate doesn't do that yet, but it probably should have the option of doing so. There is an issue for this in xonsh/amalgamate#6. It shouldn't be too hard to implement if anyone is interested.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants