Skip to content

Deprecated request and request-promise packages leading to vulnerability in tough-cookie module #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RecklessWave opened this issue Oct 22, 2024 · 4 comments

Comments

@RecklessWave
Copy link

On the latest version, 0.66, node-telegram-bot-api relies on deprecated request and request-promise packages, which depend on a vulnerable tough-cookie version (GHSA-p8p7-x288-28g6).

npm audit suggests only temporary fixes, without resolving the underlying issues. I'm seeking updates or workarounds to address these security risks effectively. Is it possible that updating to the latest version of https://www.npmjs.com/package/@cypress/request could resolve?

@RecklessWave
Copy link
Author

Following the suggestion in this thread:

cypress-io/cypress#27261

"NOTE: This is a temporarily work around with npm until tough-cookie dependency version bump is merged. Add the following to package.json:

"overrides": {
"tough-cookie": "^4.1.3"
}"

I was able to resolve it. However, the other vulnerability remains, seemingly because request-promise-core relies on deprecated request version 2.34.0:

GHSA-p8p7-x288-28g6

@RecklessWave
Copy link
Author

Perhaps Request could be replaced with Axios?

@theimo1221
Copy link

request/request#3142

I'll give it a look how hard a migration would be

@RecklessWave
Copy link
Author

Thank you! Let me know if I can assist or test in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants