Skip to content

Multiplayer: Displayer Status Code, Status Text and Body if something goes wrong while setting or validating password #13061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
touhidurrr opened this issue Mar 12, 2025 · 7 comments
Labels

Comments

@touhidurrr
Copy link
Contributor

touhidurrr commented Mar 12, 2025

Before creating

  • This is NOT a gameplay feature from Civ VI, BNW, or outside - see Roadmap
  • This is NOT a gameplay feature from Vanilla Civ V or from G&K - If so, it should be a comment in Missing features from Civ V - G&K #4697

Problem Description

see title

Related Issue Links

No response

Desired Solution

see title

Alternative Approaches

just see title again

Additional Context

the ui hangs if < 6 characters are inputted in the authentication popup. not sure why. the server rejects new passwords less than 6 characters in length but people cannot know that. maybe displaying more information in case of server errors will fix such communication issues. also see https://auth.uncivserver.xyz/tools

@yairm210
Copy link
Owner

Okay so, I'm ready to handle this
How do I get the the authentication input?

@touhidurrr
Copy link
Contributor Author

https://auth.uncivserver.xyz is the auth server url. you can set a password for a random uuid in multiplayer settings. After that, remove the password from GameSettings.json and start the client again and an auth popup will appear. Now you can test with wrong passwords.

@touhidurrr
Copy link
Contributor Author

ok. https://auth.uncivserver.xyz is online again. render keeps disabling my services so I moved it to koyeb.

@touhidurrr
Copy link
Contributor Author

Also, kindly consider making a popup ui that does this and use it anywhere where response errors are shown. This will make debugging easier.

@yairm210
Copy link
Owner

yairm210 commented Apr 6, 2025

First issue I notice is that the initial password can be one character, but subsequent ones need to be 6 characters?
Second issue: When I "initially authenticate" the second time with a different password, it's cool with it, I get a success?
I think the entire authentication path has not been tested extensively

@touhidurrr
Copy link
Contributor Author

The initial password can be 0 characters actually. Without a password set, the GET /auth route always returns true. After a password has been set, it returns true or false after validating the password.

@touhidurrr
Copy link
Contributor Author

touhidurrr commented Apr 6, 2025

Ok, so I added comprehensive testing to ensure the behavior is consistent. You can try again now. Now, 0 character passwords should be accepted initially after a minor fix. touhidurrr/UncivServer.xyz@a575aa8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants