Skip to content

[Suggestion] Battle notifications lines regarding translation #13178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ouaz opened this issue Apr 8, 2025 · 1 comment
Open

[Suggestion] Battle notifications lines regarding translation #13178

Ouaz opened this issue Apr 8, 2025 · 1 comment

Comments

@Ouaz
Copy link
Contributor

Ouaz commented Apr 8, 2025

Currently, most of battle notifications are not translated.
Yairm fixed it with f493bdf , and in the same time, simplified the translation work by using more keys and removing multiple similar lines.
Unfortunately the fix was reverted, as it seems there were problems with translation in some languages regarding the [battleAction] keys and the past tense (Spanish, Croatian).

So what about simply removing the past tense and using a passive sentence (the subject does not perform the action of the verb, the action of the verb is done to the subject) with keeping only the past participle (kind of like newspaper headlines ^^).

Using the same system as in f493bdf, but slightly modified:

# Battle actions
attacked = 
raided = 
captured = 
destroyed = 
intercepted = 
destroyed = 
intercepted and destroyed = 

# Enemy types
Enemy [unit] = 
enemy [unit] = 
Enemy city [cityName] = 
enemy city [cityName] = 

# Our types
Our [unit] = 
our [unit] = 
defence unit = 

# Interceptor types
Unknown interceptor = 
Intercepting [interceptorName] =

But use them in passive sentences (as they are already sorted in "War" notification section - meaning "War events"):

# New translation format (possible hp loss is "bundled into" the unit/city name)
[ourCombatant] [battleAction] by [enemyCombatant] = 
Enemy [unit] [battleAction] by [ourType] = 
Intercepting [interceptorType] [battleAction] by our [attackerName]
Enemy [attackerName] [battleAction] by our [interceptorName]
Our [interceptorName] intercepted and was destroyed by an enemy [attackerName]
Our [interceptorName] intercepted and was destroyed by an unknown enemy
Our [attackerName] [battleAction] by [interceptorType]

Examples:

--- War Events---
Our Warrior (-36 HP) attacked by an enemy Swordsman (-10 HP)
Barcelona raided by an enemy Archer
Barcelona captured by an enemy Horseman
Our Worker captured by an enemy Brute
Our Catapult (- 40 HP) destroyed by enemy city Helsinki
Barcelona defence unit destroyed by an enemy Catapult
Enemy Triplan (-80 HP) intercepted and destroyed by our Jet Fighter (-1 HP)
etc.

New battle notification:
Image

This way, translators can place [battleAction] (i.e. the past participle) where they need to, under the form they need to
Exemple: in french, attacked = attaqué(e) (attaqué for male, or attaquée for female).

The downside is that some flavor are lost with the passive sentence and the past participle alone, but it should work in any language.

EDIT: possibly add has been (or was ?) in the english lines.
[ourCombatant] has been [battleAction] by [enemyCombatant]

Translators can translate as they wish.

@Ouaz Ouaz added the bug label Apr 8, 2025
@yairm210
Copy link
Owner

yairm210 commented Apr 9, 2025

Can you post this in the #translation channel on Discord? Last time I thought I had a good system, UNTIL I posted there and got the feedback
Languages Are Weird so it's possible this will encounter the same probems
(Also not a Bug ;) )

@yairm210 yairm210 added enhancement and removed bug labels Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants