Skip to content

Links on Contributing page need are not a11y compliant #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
StephNathai opened this issue Oct 20, 2023 · 2 comments
Closed

Links on Contributing page need are not a11y compliant #78

StephNathai opened this issue Oct 20, 2023 · 2 comments

Comments

@StephNathai
Copy link
Contributor

StephNathai commented Oct 20, 2023 •
edited
Loading

Issue: Links on the Yargs Contributing page are failing the contrast accessibility check due to the fact that links must be distinguishable without relying on color to be a11y compliant.

Solution: Underline all 6 links that noncompliant. This will reduce a11y issues on this page by 50%
@StephNathai StephNathai mentioned this issue Oct 20, 2023
Merged
@bcoe
Copy link
Member

bcoe commented Apr 11, 2025

@StephNathai finally landed your PR, is this good to close now?

@StephNathai
Copy link
Contributor Author

@bcoe yep good to close, thanks!

@bcoe bcoe closed this as completed Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcoe @StephNathai