fix(pnp): esm - support import attributes (#6268)

**What's the problem this PR addresses?**

In Node.js v22 import assertions were replaced with import attributes so
we need to add support for those as well.

Fixes #6267

**How did you fix it?**

Added support for the `importAttributes` property.

**Checklist**
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).
- [x] I have set the packages that need to be released for my changes to
be effective.
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.

Author: merceyz

.yarn/versions/a5b83769.yml

@@ -0,0 +1,27 @@
+releases:
+  "@yarnpkg/cli": patch
+  "@yarnpkg/plugin-pnp": patch
+  "@yarnpkg/pnp": patch
+
+declined:
+  - "@yarnpkg/plugin-compat"
+  - "@yarnpkg/plugin-constraints"
+  - "@yarnpkg/plugin-dlx"
+  - "@yarnpkg/plugin-essentials"
+  - "@yarnpkg/plugin-init"
+  - "@yarnpkg/plugin-interactive-tools"
+  - "@yarnpkg/plugin-nm"
+  - "@yarnpkg/plugin-npm-cli"
+  - "@yarnpkg/plugin-pack"
+  - "@yarnpkg/plugin-patch"
+  - "@yarnpkg/plugin-pnpm"
+  - "@yarnpkg/plugin-stage"
+  - "@yarnpkg/plugin-typescript"
+  - "@yarnpkg/plugin-version"
+  - "@yarnpkg/plugin-workspace-tools"
+  - "@yarnpkg/builder"
+  - "@yarnpkg/core"
+  - "@yarnpkg/doctor"
+  - "@yarnpkg/nm"
+  - "@yarnpkg/pnpify"
+  - "@yarnpkg/sdks"

packages/acceptance-tests/pkg-tests-specs/sources/pnp-esm.test.ts

@@ -243,7 +243,7 @@ describe(`Plug'n'Play - ESM`, () => {
   );
 
   (loaderFlags.HAS_UNFLAGGED_JSON_MODULES ? test : test.skip)(
-    `it should not resolve JSON modules without an import assertion`,
+    `it should not resolve JSON modules without an import assertion/attribute`,
     makeTemporaryEnv(
       {
         type: `module`,
@@ -259,14 +259,14 @@ describe(`Plug'n'Play - ESM`, () => {
 
         await expect(run(`node`, `./index.js`)).rejects.toMatchObject({
           code: 1,
-          stderr: expect.stringContaining(`ERR_IMPORT_ASSERTION_TYPE_MISSING`),
+          stderr: expect.stringContaining(loaderFlags.SUPPORTS_IMPORT_ATTRIBUTES_ONLY ? `ERR_IMPORT_ATTRIBUTE_MISSING` : `ERR_IMPORT_ASSERTION_TYPE_MISSING`),
         });
       },
     ),
   );
 
   (loaderFlags.HAS_UNFLAGGED_JSON_MODULES ? test : test.skip)(
-    `it should resolve JSON modules with an import assertion`,
+    `it should resolve JSON modules with an import assertion/attribute`,
     makeTemporaryEnv(
       {
         type: `module`,
@@ -277,7 +277,7 @@ describe(`Plug'n'Play - ESM`, () => {
         await xfs.writeFilePromise(
           ppath.join(path, `index.js` as Filename),
           `
-          import foo from './foo.json' assert { type: 'json' };
+          import foo from './foo.json' ${loaderFlags.SUPPORTS_IMPORT_ATTRIBUTES ? `with` : `assert`} { type: 'json' };
           console.log(foo.name);
           `,
         );

packages/yarnpkg-pnp/sources/esm-loader/built-loader.js

@@ -1,9 +1,9 @@
-import {VirtualFS, npath}                                                      from '@yarnpkg/fslib';
-import fs                                                                      from 'fs';
-import {fileURLToPath, pathToFileURL}                                          from 'url';
+import {VirtualFS, npath}                                                                                                                   from '@yarnpkg/fslib';
+import fs                                                                                                                                   from 'fs';
+import {fileURLToPath, pathToFileURL}                                                                                                       from 'url';
 
-import {HAS_JSON_IMPORT_ASSERTION_REQUIREMENT, WATCH_MODE_MESSAGE_USES_ARRAYS} from '../loaderFlags';
-import * as loaderUtils                                                        from '../loaderUtils';
+import {HAS_JSON_IMPORT_ASSERTION_REQUIREMENT, SUPPORTS_IMPORT_ATTRIBUTES, SUPPORTS_IMPORT_ATTRIBUTES_ONLY, WATCH_MODE_MESSAGE_USES_ARRAYS} from '../loaderFlags';
+import * as loaderUtils                                                                                                                     from '../loaderUtils';
 
 // The default `load` doesn't support reading from zip files
 export async function load(
@@ -13,6 +13,9 @@ export async function load(
     importAssertions?: {
       type?: 'json';
     };
+    importAttributes?: {
+      type?: 'json';
+    };
   },
   nextLoad: typeof load,
 ): Promise<{ format: string, source?: string, shortCircuit: boolean }> {
@@ -26,10 +29,21 @@ export async function load(
   if (!format)
     return nextLoad(urlString, context, nextLoad);
 
-  if (HAS_JSON_IMPORT_ASSERTION_REQUIREMENT && format === `json` && context.importAssertions?.type !== `json`) {
-    const err = new TypeError(`[ERR_IMPORT_ASSERTION_TYPE_MISSING]: Module "${urlString}" needs an import assertion of type "json"`) as TypeError & { code: string };
-    err.code = `ERR_IMPORT_ASSERTION_TYPE_MISSING`;
-    throw err;
+  if (HAS_JSON_IMPORT_ASSERTION_REQUIREMENT && format === `json`) {
+    if (SUPPORTS_IMPORT_ATTRIBUTES_ONLY) {
+      if (context.importAttributes?.type !== `json`) {
+        const err = new TypeError(`[ERR_IMPORT_ATTRIBUTE_MISSING]: Module "${urlString}" needs an import attribute of "type: json"`) as TypeError & { code: string };
+        err.code = `ERR_IMPORT_ATTRIBUTE_MISSING`;
+        throw err;
+      }
+    } else {
+      const type = `importAttributes` in context ? context.importAttributes?.type : context.importAssertions?.type;
+      if (type !== `json`) {
+        const err = new TypeError(`[ERR_IMPORT_ASSERTION_TYPE_MISSING]: Module "${urlString}" needs an import ${SUPPORTS_IMPORT_ATTRIBUTES ? `attribute` : `assertion`} of type "json"`) as TypeError & { code: string };
+        err.code = `ERR_IMPORT_ASSERTION_TYPE_MISSING`;
+        throw err;
+      }
+    }
   }
 
   // https://github.com/nodejs/node/pull/44366/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778bR477-R479

packages/yarnpkg-pnp/sources/esm-loader/hooks/load.ts

@@ -26,3 +26,9 @@ export const ALLOWS_NON_FILE_PARENT = major > 18 || (major === 18 && minor >= 1)
 
 // https://github.com/nodejs/node/pull/49869
 export const ALLOWS_EXTENSIONLESS_FILES = major >= 21 || (major === 20 && minor >= 10) || (major === 18 && minor >= 19);
+
+// https://github.com/nodejs/node/pull/50140
+export const SUPPORTS_IMPORT_ATTRIBUTES = major >= 21 || (major === 20 && minor >= 10) || (major === 18 && minor >= 20);
+
+// https://github.com/nodejs/node/pull/52104
+export const SUPPORTS_IMPORT_ATTRIBUTES_ONLY = major >= 22;